Commit Graph

23301 Commits

Author SHA1 Message Date
Alayan
e64e2d8cd5
Fix #4931
The assert could be triggered when a new sign-in request was sent before the first one was resolved, usually when using the enter key to request the sign in. Since it can happen in normal operations to have the player profile status different from signing out or signed out, an assert is incorrect.

Also fix server-only compilation for the previous commit.
2024-04-28 21:43:42 +02:00
Alayan
01d62be5de
Fix crashing when turning the modern renderer on or off before benchmarking 2024-04-28 18:32:51 +02:00
CodingJellyfish
9206b923f7 Use xmlDecode for news 2024-04-28 15:57:42 +08:00
CodingJellyfish
18094c505a Add resizing code for networking lobby 2024-04-28 13:25:20 +08:00
CodingJellyfish
f6949972b3 Add resizing code for label widget 2024-04-28 11:15:41 +08:00
CodingJellyfish
97ca195e20 Fix dynamic ribbon widget being shown above a dialog after resized 2024-04-27 15:05:52 +08:00
CodingJellyfish
10b6c4b1e1 Fix focus bug when multiplayer handling is not needed 2024-04-26 23:24:51 +08:00
Alayan
543ee92e00
Confirm the performance report saving to the user
Also fix a compilation issue with compilers not recognizing uint
2024-04-26 16:50:50 +02:00
Alayan
792c1e0926
Compute new performance metrics and improve saving of profiler data
* Format the standard CPU and GPU profiler data as CSV, to simplify its analysis
* Include the internal identifier name of the track in the report name, or 'menu' if there is no active track. This uses the current track at the time of report saving. It is possible to keep the profiler on through multiple tracks and menus, but it's on people enabling the artist debug mode and the profiler to use it sensibly
* Stop the profiler when saving data, if it's not already stopped
* Compute, when profiling is stopped, for all integer FPS values up to 1000, three key metrics:
 - The number of frames too slow to reach this FPS value
 - The proportion of total time spent in frames slower than this FPS value
 - The proportion of total time spent in frames beyond the maximum duration associated with this FPS value
* Compute three key indicator values:
 - Steady FPS (highest FPS with no more than 1% time spent in slower frames and no more than 0.1% time spent beyond the maximum duration)
 - Mostly stable FPS (highest FPS with no more than 12% time spent in slower frames and no more than 2% time spent beyond the maximum duration)
 - Typical FPS (highest FPS with no more than 50% time spent in slower frames and no more than 10% time spent beyond the maximum duration)
* Save an additional 'perf-report' containing this new data

 Traditional performance measurements, such as average FPS and 1% lows (which are typically based on the 1% slowest frames, not on the 1% slowest gameplay time), are flawed because they unduly reward outputting more fast frames. Increasing the number of fast frames without speeding up the slow frames is useless when it comes to making the game feel smooth, which is especially critical in a racing game.

 Missing features:
 - Displaying a summary of the performance test instead of the normal end screen
 - Confirm to the user that the report has been successfully saved
 - And more advanced options.
2024-04-26 16:11:55 +02:00
Alayan
62d0281a18
Adapt the end screen in benchmark mode (part 1)
- Customize the race result screen to offer three options : leave to main menu, save test data, and return to video settings
- Ensure all three options do as they say
- Ensure that the benchmark mode and the profiler are always turned off when leaving through the end screen
2024-04-26 13:39:39 +02:00
CodingJellyfish
e68acaa02a Add resizing code for dynamic ribbon widget 2024-04-26 13:05:36 +08:00
CodingJellyfish
26b24a63ea Add onResize for options screen video 2024-04-26 11:34:08 +08:00
CodingJellyfish
8e5304d4a9 Fix icon button widget crash 2024-04-26 10:38:41 +08:00
CodingJellyfish
5adbb3f16b Add resizing code for spinner widget 2024-04-25 10:13:24 +08:00
CodingJellyfish
0dffd116a9 Remove unneeded hacks 2024-04-24 23:32:34 +08:00
CodingJellyfish
e0be4cfc4f Reset coordinates before they are updated by layout manager 2024-04-24 22:51:51 +08:00
Alayan
893c5a7b5d
Move help and option files in subfolders 2024-04-24 13:46:49 +02:00
Alayan
171ac3c0b0
Adapt the pause menu in benchmark mode
* Use explicit activation and desactivation functions for the profiler to improve code clarity and robustness
* In the pause dialog, only display the 'back to race' and 'exit' buttons in benchmark mode
* Relabel the buttons in the pause menu in benchmark mode
* Use 'Performance test' in user-facing texts to ensure better translations
* Fix parts of the UI disappearing when leaving the pause menu in benchmark mode

Additional known issue introduced in the previous benchmark commit:
* With big text sizes, the performance test button overflows in the graphics settings.
2024-04-24 13:29:05 +02:00
CodingJellyfish
db2cc69d89 Refactor sprite scaling in STKModifiedSpriteBank
Make it proportional to font height so that it can be auto-resized
2024-04-23 15:30:35 +08:00
CodingJellyfish
1319c9845b Remove list header properly 2024-04-23 10:18:19 +08:00
CodingJellyfish
85e52de194 Add more resizing code to CGUISTKListBox 2024-04-22 11:35:19 +08:00
CodingJellyfish
f6836998f0 Use a better setOverrideFont in ribbon widget 2024-04-22 10:56:01 +08:00
CodingJellyfish
34119e1c5f Remove unneeded if in Widget::resize 2024-04-21 14:40:10 +08:00
CodingJellyfish
0d2fd6f628 Recalculate glyph layouts when list box resized 2024-04-21 14:08:39 +08:00
CodingJellyfish
af1238d688 Backport irrlicht changes to CGUISTKListBox 2024-04-21 14:05:34 +08:00
CodingJellyfish
2a60d6508b Add resizing code for list widget 2024-04-21 13:24:07 +08:00
CodingJellyfish
3641183121 Add resizing code for ribbon widget 2024-04-20 18:55:31 +08:00
CodingJellyfish
0cea06d935 Add resizing code for icon button widget 2024-04-19 20:21:54 +08:00
CodingJellyfish
52edb8507e Remove the remaining unneeded header file includes 2024-04-19 17:28:11 +08:00
CodingJellyfish
f70c2abe54 Remove unneeded header file includes in online screens 2024-04-19 15:55:56 +08:00
CodingJellyfish
913a082528 Keep multiplayer in kart selection screen after reloading 2024-04-19 13:35:37 +08:00
CodingJellyfish
2f87966ff6 Add basic code for widget and screen resize 2024-04-19 13:18:31 +08:00
Deve
78c6f16d79 Fixed a crash when entering story mode 2024-04-18 19:27:18 +02:00
Deve
754a11030e Update gradle and android build script 2024-04-18 17:20:09 +02:00
CodingJellyfish
6be521fc96
Fix #5054 (#5055) 2024-04-17 14:09:18 +02:00
Alayan
a6cecd2279
First steps for a benchmark mode
* Add a button in the graphics options to start a benchmark
* Added logic to play a custom replay for benchmarking
* Added logic to automatically start and end the profiling as the race starts and ends, when in benchmark mode
* Disable the profiler drawings in benchmark mode, they take additional resources and are useless
* Keep the race going when the pause menu is opened, as it would otherwise distort the results
* Added logic to clean up the profiler data each time profiling is switched back from off to on. This avoids multiple profiling sessions piling up in one report, for example when benchmarking tw
* Added a sped up Black Forest replay for use during the benchmark

Missing features and known issues:
* The end screen should display a benchmark result summary instead of a normal end screen
* Entering and leaving the pause menu in benchmark mode makes some parts of the race UI disappear
* The end screen should send the player back to the graphics settings, not the main menu
* Pausing and quitting can leave the profiler enabled when it should not be
* The options in the pause menu should be customized in benchmark mode
* The replay used for benchmarking should be configurable in a data file
* Automatically testing multiple graphics settings and providing an overall summary
* And more advanced options.
2024-04-16 05:46:30 +02:00
CodingJellyfish
8577408cec
LOD improvements (#5038)
* Quick cull invisible LOD nodes
* Reduce dynamic cast
* Fix for Vulkan

Maintainer's comment: Helps only in select tracks and more in already fast frames than in the more problematic slow frames, but an improvement nonetheless.
2024-04-15 16:30:08 +02:00
Alayan
6cf094ab78
Add new setting values for increased view distances
Add 3 new setting values, increasing the distance at which a lower level of detail is used by factors of 1.6, 2.0 and 3.0 (default is 1.25). This allows players for which getting enough FPS is not an issue to reduce pop-in and improve the looks of tracks.

In local testing with a strong CPU and a weak GPU, the performance impact of increasing the view distances is small and well worth it, but this may vary from system to system. More testing is needed on different systems, but this suggests room to increase minimum, default and maximum values in future releases.

This patch also slightly changes the auto-computation of LoD distance, making the transition around a distance of 250 smoother.
2024-04-15 01:48:58 +02:00
kimden
31bdb52bfd Make sure handleAllVotes returns true at least once 2024-04-02 01:00:32 +04:00
kimden
c520c441d3 Don't pick first vote if vote majority is achieved but no vote coincides completely 2024-04-02 00:43:58 +04:00
kimden
4ee7c51131 Fix random choice of several equal votes in handleAllVotes 2024-04-02 00:42:33 +04:00
oldherl
979077abab Update Cantarell font
Update to Cantarell 0.303.
Upstream releases only include VF files now.
This single weight file was extracted from debian package fonts-cantarell_0.303.1-1_all.deb
2024-03-20 16:53:31 +11:00
Benau
1a8dbbdc74 Fix #5024 2024-02-23 22:30:43 +08:00
jacekpoz
a254c7afc2
make loopback checking more readable (#5016)
* make loopback checking more readable

* follow coding style

---------

Co-authored-by: jacekpoz <jacekpoz@cock.li>
2024-02-07 23:18:25 +08:00
Benau
e1454a007e Fix memory corruption when vector being resized 2024-01-25 10:51:10 +08:00
CodingJellyfish
ec8362915d
Fix #4984 & #4995 (#4998) 2024-01-18 01:13:23 +08:00
Sonter
6573ebe09e
Fix #4960 (#5003)
Adjust linked buttons.

Enum MultitouchButtonType is here: https://github.com/supertuxkart/stk-code/blob/master/src/input/multitouch_device.hpp
2024-01-18 01:12:55 +08:00
Xiangquan Xiao
fab7915011 Minor fix on coding styles. 2024-01-07 14:08:59 -05:00
CodingJellyfish
2e89eeed1a
Fix #3471 v2 (#4989)
Add factor to fonts for scaling to higher size
2024-01-08 01:13:13 +08:00
CodingJellyfish
3928a49d5e
Fix #4923 (#4981) 2024-01-06 12:17:57 +08:00