We can see what is the feedback if it's fast enough for users. It still looks much better than without advanced lighting even when resolution is lower.
IMO auto scale doesn't have much sense on desktop computers, because advanced lighting was enabled by default for a long time and graphics level 3 should be fast enough as it is. And still now rtts scale it's easily configurable in options.
I fixed deactivated "render resolution" spinner when you enter graphics options when advanced lighting is disabled.
I also added a function that reads dpi on android and it sets rtts scale based on this value. SDL is not initialized yet in this place, so getDisplayDPI() is not possible.
Auto mode adjusts based on your display's DPI in order to hit a target DPI. Currently it will default to Always Full for render resolution, but High Quality or even Quality might make a good default, community testing is needed.
* few improvements of option UI
* small fix
* show the correct spinner text when not activated
* camera name for translation
* clean the code (loop camera spinner)
* Allow setting [again] track reverse mode via command line
* Make composer field in music information files optional
* Add support for loop end of music
* Remove print statements used for checking current music play time
* Support playing different music on race results screen
Also make them configurable in stk_config.xml
* Allow configuring grand prix win/lose and feature unlocked music in stk_config.xml
* Fix coding indentation style
* Fix warning when scrolling track screenshots in grand prix results
* Display the rank a player kart finishes in if not in 1st place
* Add gamerzilla support to achievements.
* Move all gamerzilla code into one file. Should we want to support another achievement system like Steam, it can be isolated to the WebAchievementsStatus class.
* Add WebAchievementsStatus files.
* Add version number to achievements file. Update graphics. Generate achievement list from internal system.
We should let VSync/m_max_fps (which defaults to 120) do their job. If a monitor has a refresh rate even slightly higher than 60FPS (e.g. 60.0007FPS), throttling will introduce stutters, even more so at modern high refresh rates (75, 90, 120, etc.)
This also cleans up the code, e.g. the var name `m_throttle_fps` was also being used in the main loop for a different function, despite having the same var name.
With the font size set to "Very Large" and the theme set to "Cartoon", the Apply button went slightly outside of the main box. This fixes that by putting the two checkboxes on the same row, which saves a bit of valuable horizontal space.