The SFX manager and SFXOpenAL would check if SFXs are enabled before pausing (looping) sound effects, so disabling SFXs in the options would fail to stop looping SFxs.
Furthermore, 'OnSoundEnabledBack' would pause all looping SFXs. This commit checks for the pause status of the World (if applicable) to decide if the looping SFXs should be immediately resumed (networking) or not (real pause).
Also clean some comments and move some code around.
This patch doesn't address sound resuming when going from the pause menu to the options in networked mode, whereas it doesn't in a normal race. This is what caused the bug to trigger in the first place, but it's very minor by itself and the design of the SFX code could have triggered other future issues too.
* WIP support for Nintendo Switch
* OpenAL is usable
* Remove some debug code, add manual crash when DEBUG_NXLINK is on
* Remove more debug logs
* Support touch, account name detection, language detection. Remove resolution settings
* Stylistic changes
* SFXManager: update on main thread
* Add build script, remove crypto.hpp changes, disable opengl recorder on switch
* make: use sudo where needed, libs=>lib, portlib=>portlibs
* make: build harfbuzz with freetype
* main: remove DEBUG_NXLINK
* socket_address: this comment is no longer relevant
* Fix indentation in SDL, remove extra debug logs from InputManager
* InputManager: make log debug, not info
* CMakeLists: add mbedtls include dirs on switch
* main: deinitialize stuff
* main_loop: fix format
* Allow setting [again] track reverse mode via command line
* Make composer field in music information files optional
* Add support for loop end of music
* Remove print statements used for checking current music play time
* Support playing different music on race results screen
Also make them configurable in stk_config.xml
* Allow configuring grand prix win/lose and feature unlocked music in stk_config.xml
* Fix coding indentation style
* Fix warning when scrolling track screenshots in grand prix results
* Display the rank a player kart finishes in if not in 1st place
