ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bugfix: addPersistent/addToCache would call Profile::merge(), which

Browse Source 
deletes the original profile --> the profile accessed after this call
was invalid.
This commit is contained in:
hiker
2014-02-28 08:51:02 +11:00
parent 76787599d9
commit bef02c116c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/online/profile.cpp
View File

@@ -224,14 +224,15 @@ void Profile::storeFriends(const XMLNode * input)
if (m_is_current_user)
{
profile = new Profile(friends_xml->getNode(i), C_RELATION_INFO);
m_friends.push_back(profile->getID());
ProfileManager::get()->addPersistent(profile);
}
else
{
profile = new Profile(friends_xml->getNode(i)->getNode("user"), C_DEFAULT);
m_friends.push_back(profile->getID());
ProfileManager::get()->addToCache(profile);
}
m_friends.push_back(profile->getID());
} // for i in nodes
m_has_fetched_friends = true;
m_state = S_READY;