ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash in karts sorting caused by inconsistent comparison predicate

Browse Source
This commit is contained in:
auria.mg
2018-10-07 20:48:18 -04:00
parent efe68fef94
commit 0cb89e1a4f
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/states_screens/race_gui.cpp
View File

@@ -601,10 +601,14 @@ void RaceGUI::drawGlobalMiniMap()
// are drawn above them
World::KartList karts = world->getKarts();
std::sort(karts.begin(), karts.end(), []
(const std::shared_ptr<AbstractKart> a,
const std::shared_ptr<AbstractKart> b)->bool
(const std::shared_ptr<AbstractKart>& a,
const std::shared_ptr<AbstractKart>& b)->bool
{
return !a->getController()->isLocalPlayerController();
bool aIsLocalPlayer = a->getController()->isLocalPlayerController();
bool bIsLocalPlayer = b->getController()->isLocalPlayerController();
// strictly greater than, so return false if equal
return !aIsLocalPlayer && aIsLocalPlayer != bIsLocalPlayer;
});
for (unsigned int i = 0; i < karts.size(); i++)