Closes#4708
This updates jsoncpp, mbedtls, TCLAP and SQLiteCpp to their latest stable release. A few additional changes were needed:
* jsoncpp deprecated Reader, FastWriter and StyledWriter which I've replaced
with some helper functions in JsonUtils.cpp
* SQLiteCpp changed how it builds with external sqlite libraries, now expecting
them to be installed. The simplest path was to remove sqlite from cuberite's
submodule and just use SQLiteCpp's internal version.
Closes#4236
CMake now creates a header file in the build directory under the path "include/Globals.h" which just includes "src/Globals.h" with an absolute path. Then instead of adding "src/" to the include directories, it adds "include/".
#include "Globals.h" still works by including the build generated file and any other src-relative path will not work.
* Change reinterpret_cast -> static_cast wherever possible
* Remove more unnecessary `const_cast`s.
reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there.
* Fix switch warnings
* Fix a variety of -Wswitch and -Wswitch-enum warnings
* Remove unneeded -Wno-error flags
* Reorganise some eMonsterType switches
* Alpha sort eMonsterType cases in WriteMobMetadata
and in cNBTChunkSerializer::AddMonsterEntity
* List all mob types in protocol 1.12 and NBTChunkSerializer
* cStructGenTrees::GetNumTrees: remove switch default
* cWSSAnvil::LoadOldMinecartFromNBT: Log unhandled minecart type
* Added GetPacketId method to protocol, implemented for all protocols.
* Moved GetPacketID methods into a single file, alpha-sorted.
* Fixed 1.12.1 HandlePacket switch statement.
* Added SendLogin to the GetPacketId framework.
* Added SpawnObject to GetPacketId framework.
* Added missing sendEntityEquipment packet ID update for 1.12.1
* Added LeashEntity packet ID change to 1.12.1
* Alphabetized packet enum, added SpawnGlobalEntity to GetPacketId framework
* Fixed clang errors
* Indented cases, expanded comment for GetPacketId
* Changed dyslexic comment.
- NBT: Added saving / loading of material
- Added the material in the item handler of the boat
- Drop the correct boat if destroyed
- APIDoc: Added desc and functions
peterbell10
Bond-009
Mat
Mattes D
Lane Kolbly
satoshinm
mathiascode
Tiger Wang
Lukas Pioch
mathiascode
Pokechu22