mirror of
https://github.com/rkd77/elinks.git
synced 2025-02-02 15:09:23 -05:00
2f04a38c6f
To reproduce: - Configure with --enable-debug. - Go to http://elinks.cz/ - Set the cursor on the "About" link and press d to download, - ELinks asks where to save the file. Cancel that with Esc. This leaves session.download_uri != NULL. - Go to /etc/passwd - ELinks asks what to do with the file. Choose to download. - ELinks asks where to save the file. Type the name of a new file and press Enter. - Again go to /etc/passwd - ELinks asks what to do with the file. Choose to download. - ELinks asks where to save the file. Type the same name as before and press Enter. - ELinks asks whether to resume or overwrite. Choose to resume. This changes session.download_uri and leaks the original URI. - Quit ELinks. It reports memory leaks: 0x88936d8:28 @ alloc'd at /home/Kalle/src/elinks-0.12/src/util/hash.c:89 0x88dac00:95 @ alloc'd at /home/Kalle/src/elinks-0.12/src/protocol/uri.c:1551 0x88c33a8:4104 @ alloc'd at /home/Kalle/src/elinks-0.12/src/util/hash.c:41 This commit fixes the leak, but it's still a bug that lun_resume() can replace the session.download_uri that will be used by another pending download. In particular, this might happen if the user first presses d to download, and then while ELinks is asking for the file name, a web script changes window.location to a different URI and that causes ELinks to ask what to do with the file. So I'm leaving the FIXME comment in for now.
ELinks - an advanced web browser ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ELinks is an advanced and well-established feature-rich text mode web (HTTP/FTP/..) browser. ELinks can render both frames and tables, is highly customizable and can be extended via scripts. It is very portable and runs on a variety of platforms. The ELinks official website is available at http://elinks.cz/ Please see the SITES file for mirrors or other recommended sites. If you want to install ELinks on your computer, see the INSTALL file for further instructions. A good start point is documentation files available in doc/, especially the file named index.txt. If you want to request features or report bugs, see community information at http://elinks.cz/community.html and feedback information available at http://elinks.cz/feedback.html. If you want to write some patches, please first read the doc/hacking.txt document. If you want to add a new language or update the translation for an existing one, please read po/README document. If you want to write some documentation, well, you're welcome! ;) Historical notes ~~~~~~~~~~~~~~~~ Initially, ELinks was a development version of Links (Lynx-like text WWW browser), with more liberal features policy and development style. Its purpose was to provide an alternative to Links, and to test and tune various new features, but still provide good rock-solid releases inside stable branches. Why not contribute to Links instead? Well, first I made a bunch of patches for the original Links, but Mikulas wasn't around to integrate them, so I started releasing my fork. When he came back, a significant number of them got refused because Mikulas did not like them, as he just wouldn't have any use for them himself. He wants to keep Links with a relatively closed feature set and merge only new features which he himself needs. It has advantages that the tree is very narrow and the code is small and contains very little bloat. ELinks, on the contrary, aims to provide a full-featured web browser, superior to both lynx and w3m and with the power (but not slowness and memory usage) of Mozilla, Konqueror and similar browsers. However, to prevent drastic bloating of the code, the development is driven in the course of modularization and separation of add-on modules (like cookies, bookmarks, ssl, scripting etc). For more details about ELinks history, please see http://elinks.cz/history.html If you are more interested in the history and various Links clones and versions, you can examine the website at http://links.sf.net/ vim: textwidth=80