This patch addresses the design flaw pointed out by Vitaly in 2016,
where two independent interpreters were reading the same file(s)
and coming to different conclusions about the location of the built
package. The coupling between programs is now much more fragile,
though. Only by ensuring stability of the user-facing layer
(specifically how the success of a build is reported) can we guarantee a
regex match with the current pattern. Changes to the user-facing layer
of pkgmk will require corresponding changes to the regex matching here.
Commit 4145a63e (delegate to pkgmk) also addressed the problem of two
independent parsers, but that solution is no longer viable when pkgmk is
invoked under rootlesskit. Defining in /etc/prt-get.conf the line
"addcommand doas /usr/bin/pkgadd" leads to problems when pkgmk inside a
user namespace is told to run this addcommand on the built package.
Specifically, inside the user namespace the file /etc/doas.conf appears
to have the wrong owner. Rather than fiddle with /etc/subuid and
/etc/subgid to fix the apparent owner, it seems more viable in the long
run to revert the delegate-to-pkgmk solution, and move the eventual
pkgadd invocation back to the parent process.
Documentation
tutorials, examples, and manual pages
Description
Languages
Roff
48.1%
Perl
31.4%
Shell
19.9%
Awk
0.6%