ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash: a reference to a string in a widget was used after the

Browse Source 
widget was deleted.
This commit is contained in:
hiker 2014-07-15 09:10:54 +10:00
parent 146e99b13d
commit ccb8d0e973
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/states_screens/dialogs/gp_info_dialog.cpp
View File

@ -259,15 +259,19 @@ void GPInfoDialog::onEnterPressedInternal()
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
GUIEngine::EventPropagation GPInfoDialog::processEvent(const std::string& eventSource) GUIEngine::EventPropagation GPInfoDialog::processEvent(const std::string& event_source)
{ {
if (eventSource == "start" || eventSource == "continue") if (event_source == "start" || event_source == "continue")
{ {
// Save GP identifier, since dismiss will delete this object. // Save GP identifier, since dismiss will delete this object.
std::string gp_id = m_gp->getId(); std::string gp_id = m_gp->getId();
// Also create a copy of the string: it is a reference to data
// in a widget in the dialog - so if we call dismiss, this reference
// becomes invalid!
std::string save_source = event_source;
ModalDialog::dismiss(); ModalDialog::dismiss();
race_manager->startGP(grand_prix_manager->getGrandPrix(gp_id), false, race_manager->startGP(grand_prix_manager->getGrandPrix(gp_id), false,
(eventSource == "continue")); (save_source == "continue"));
return GUIEngine::EVENT_BLOCK; return GUIEngine::EVENT_BLOCK;
} }