ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix behavior when no acceleration/braking above the "stop" speed limit

Browse Source 
The kart accelerating when going backwards was a sign issue (missing fabsf) and was already fixed in bb1aac3857

Setting the engine force to 0 in all cases causes issues when not accelerating/braking at higher speeds.
This commit is contained in:
Alayan-stk-2 2018-11-18 03:40:46 +01:00 committed by GitHub
parent f4b02c096a
commit cc1f2f63b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/karts/kart.cpp
View File

@ -2798,15 +2798,22 @@ void Kart::updateEnginePowerAndBrakes(int ticks)
// lift the foot from throttle, let friction slow it down
assert(!std::isnan(m_controls.getAccel()));
assert(!std::isnan(engine_power));
// Engine must be 0, otherwise braking is not used at all
applyEngineForce(0);
// If not giving power (forward or reverse gear), and speed is low
// we are "parking" the kart, so in battle mode we can ambush people
if (std::abs(m_speed) < 5.0f)
{
// Engine must be 0, otherwise braking is not used at all
applyEngineForce(0);
m_vehicle->setAllBrakes(20.0f);
}
else
{
// This ensure that parachute and air friction are applied
// and that the kart gracefully slows down
applyEngineForce(engine_power-braking_power);
m_vehicle->setAllBrakes(0);
}
} // no braking and no acceleration
} // not accelerating
} // updateEnginePowerAndBrakes