ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always discard unknown synchronous message instead of keeping it

Browse Source 
Synchronous message can only be EVENT_TYPE_MESSAGE anyway
This commit is contained in:
Benau 2019-05-13 14:02:04 +08:00
parent fff6c1d51f
commit bb65ba927e
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/protocols/client_lobby.cpp
View File

@ -147,6 +147,8 @@ void ClientLobby::doneWithResults()
bool ClientLobby::notifyEvent(Event* event)
{
assert(m_game_setup); // assert that the setup exists
if (event->getType() != EVENT_TYPE_MESSAGE)
return true;
NetworkString &data = event->data();
assert(data.size()); // assert that data isn't empty
@ -174,7 +176,6 @@ bool ClientLobby::notifyEvent(Event* event)
case LE_START_RACE: startGame(event); break;
case LE_REPORT_PLAYER: reportSuccess(event); break;
default:
return false;
break;
} // switch
return true;
@ -196,8 +197,6 @@ bool ClientLobby::notifyEventAsynchronous(Event* event)
{
default: break;
} // switch
return true;
} // message
else if (event->getType() == EVENT_TYPE_DISCONNECTED)
{
@ -211,9 +210,8 @@ bool ClientLobby::notifyEventAsynchronous(Event* event)
STKHost::get()->setErrorMessage(
m_disconnected_msg.at(event->getPeerDisconnectInfo()));
STKHost::get()->requestShutdown();
return true;
} // disconnection
return false;
return true;
} // notifyEventAsynchronous
//-----------------------------------------------------------------------------

2
src/network/protocols/server_lobby.cpp
View File

@ -563,7 +563,7 @@ bool ServerLobby::notifyEvent(Event* event)
{
assert(m_game_setup); // assert that the setup exists
if (event->getType() != EVENT_TYPE_MESSAGE)
return false;
return true;
NetworkString &data = event->data();
assert(data.size()); // message not empty