ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify m_icon_node handling in item class

Browse Source 
Item::handleNewMesh already creates new m_icon_node everytime
This commit is contained in:
Benau 2022-09-04 11:12:07 +08:00
parent 79bf026c74
commit 9a7e2f6c39
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/items/item.cpp
View File

@ -280,17 +280,6 @@ Item::Item(ItemType type, const Vec3& xyz, const Vec3& normal,
m_spark_nodes.push_back(billboard);
}
if (!icon.empty())
{
m_icon_node = irr_driver->addBillboard(core::dimension2df(1.0f, 1.0f),
icon, m_node);
m_icon_node->setPosition(core::vector3df(0.0f, 0.5f, 0.0f));
m_icon_node->setVisible(false);
((scene::IBillboardSceneNode*)m_icon_node)
->setColor(ItemManager::getGlowColor(type).toSColor());
}
} // Item(type, xyz, normal, mesh, lowres_mesh)
//-----------------------------------------------------------------------------
@ -420,8 +409,9 @@ void Item::handleNewMesh(ItemType type)
if (m_icon_node)
m_node->removeChild(m_icon_node);
m_icon_node = NULL;
auto icon = ItemManager::getIcon(type);
if (!icon.empty())
{
m_icon_node = irr_driver->addBillboard(core::dimension2df(1.0f, 1.0f),