ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace xml.dom.minidom.parse which is known to be vulnerable to XML attacks. (#3933)

Browse Source 
This code is only run during the development process when updating translations base and the source XML files are trusted data. There doesn't seem to be a downside to the change, however.
This commit is contained in:
ghostslayer989 2019-06-28 06:36:08 -04:00 committed by Alayan-stk-2
parent fb99661d5d
commit 74f227590e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/po/extract_strings_from_XML.py
View File

@ -86,7 +86,7 @@ for file in filenames:
isAchievements = True
try:
doc = xml.dom.minidom.parse(file)
doc = defusedxml.minidom.parse(file)
except Exception as ex:
print "============================================"
print "/!\\ Expat doesn't like ", file, "! Error=", type(ex), " (", ex.args, ")"