ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix 'Replay with UID of lu' error

Browse Source 
- Correctly format the log to display the actual UID
- Fix getReplaydIdByUid being called with an UID of 0, when no replay to compare has been selected
This commit is contained in:
Alayan 2023-12-06 19:57:29 +01:00
parent 4ca872f23d
commit 6d38bfec8c
No known key found for this signature in database
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/replay/replay_play.cpp
View File

@ -543,6 +543,6 @@ unsigned int ReplayPlay::getReplayIdByUID(uint64_t uid)
}
}
Log::error("Replay", "Replay with UID of " PRIu64 " not found.", uid);
Log::error("Replay", "Replay with UID of %" PRIu64 " not found.", uid);
return 0;
} //setReplayFileByUID
} //getReplayIdByUID

13
src/states_screens/ghost_replay_selection.cpp
View File

@ -294,10 +294,15 @@ void GhostReplaySelection::loadList()
unsigned int best_index = 0;
// getReplayIdByUID will send 0 if the UID is incorrect,
// and m_is_comparing will be false if it is incorrect,
// so it always work
unsigned int compare_index = ReplayPlay::get()->getReplayIdByUID(m_replay_to_compare_uid);
// Only compute the compare index if we are actually going to compare.
// This avoids spurious errors trying to find a replay with UID 0.
unsigned int compare_index = 0;
if (m_is_comparing)
// In case the requested replay is not found, compare_index will be 0.
compare_index = ReplayPlay::get()->getReplayIdByUID(m_replay_to_compare_uid);
// It's better to do this when not comparing than to do it repeatedly in the loop,
// it will simply be unused if not comparing.
const ReplayPlay::ReplayData& rd_compare = ReplayPlay::get()->getReplayData(compare_index);
for (unsigned int i = 0; i < ReplayPlay::get()->getNumReplayFile() ; i++)