ilikecats/stk-code_catmod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UI/UX: Fix race UX when something is unlocked

Browse Source 
Challenge completion status is already shown on the race results screen, changing the icon and text of the Continue button just causes confusion.

Fixes https://github.com/supertuxkart/stk-code/issues/4859
This commit is contained in:
QwertyChouskie 2023-04-20 14:49:51 -07:00
parent d825c32e76
commit 2c9e581c60
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/states_screens/race_result_gui.cpp
View File

@ -274,15 +274,18 @@ void RaceResultGUI::enableAllButtons()
// If something was unlocked
// -------------------------
// Note: Only returns greater than 0 for regular races, despite GPs
// showing feature unlocked cutscene. GPs have their own logic.
int n = (int)PlayerManager::getCurrentPlayer()
->getRecentlyCompletedChallenges().size();
if (n > 0 &&
(RaceManager::get()->getMajorMode() != RaceManager::MAJOR_MODE_GRAND_PRIX ||
RaceManager::get()->getTrackNumber() + 1 == RaceManager::get()->getNumOfTracks() ) )
{
middle->setLabel(n == 1 ? _("You completed a challenge!")
: _("You completed challenges!"));
middle->setImage("gui/icons/cup_gold.png");
middle->setLabel(_("Continue"));
middle->setImage("gui/icons/green_check.png");
middle->setVisible(true);
operations->select("middle", PLAYER_ID_GAME_MASTER);
}
@ -419,17 +422,18 @@ void RaceResultGUI::eventCallback(GUIEngine::Widget* widget,
return;
}
// If something was unlocked, the 'continue' button was
// actually used to display "Show unlocked feature(s)" text.
// If something was unlocked, the 'continue' button is
// used to trigger the unlocked feature(s) cutscene.
// ---------------------------------------------------------
PlayerProfile *player = PlayerManager::getCurrentPlayer();
// Note: Only returns greater than 0 for regular races, despite GPs
// showing feature unlocked cutscene. GPs have their own logic.
int n = (int)player->getRecentlyCompletedChallenges().size();
if (n > 0 &&
(RaceManager::get()->getMajorMode() != RaceManager::MAJOR_MODE_GRAND_PRIX ||
RaceManager::get()->getTrackNumber() + 1 == RaceManager::get()->getNumOfTracks() ) )
{
if (action == "middle")
{