324 Commits

Author SHA1 Message Date
Brad Dutton
3ee59350a1 php 8.1 updates 2022-01-08 20:33:23 -08:00
Brad Dutton
8a5a326386 Merge pull request #1 from trasher/short_tags
Drop short_tags
2020-10-10 20:27:00 -07:00
bwdutton
761de1b42f get the CI tests fully working again 2020-02-01 14:17:33 -08:00
bwdutton
9c6259b7bd fix broken admin comment nav links https://github.com/bwdutton/gallery3/issues/2 2019-09-11 14:27:49 -07:00
Johan Cwiklinski
6746792bdf Drop short_tags 2018-05-19 17:01:37 +02:00
Bharat Mediratta
9e0631ab0d Provide a "default moderate" option for comments. The default behavior
is unchanged, but you now have the option to set all new comments to
be unpublished and then moderate them through the Admin > Content >
Comments interface.

Fixes #2126.
2014-05-28 14:54:02 -04:00
Bharat Mediratta
9396342250 Drop the requirement to have the install() function set the module
version.  It's redundant.  Fixes #1985.
2013-01-31 19:55:53 -05:00
Bharat Mediratta
49f6ce2d94 gallery.menalto.com -> galleryproject.org
codex.gallery2.org -> codex.galleryproject.org

Fixes #1957.
2013-01-22 18:39:24 -05:00
Bharat Mediratta
d45a737779 Update copyright to 2013. Fixes #1953. 2013-01-21 01:22:01 -05:00
Bharat Mediratta
b7e89613fc Installer for comment module version 6 still set rss_visible to "both"
not "all".  Fix that now and rebuild the installer package.  Fixes #1917.
2012-10-08 14:04:40 -07:00
Bharat Mediratta
71e33d9cb6 Fix up per item feed urls. Fixes #1906. 2012-08-02 12:58:28 -07:00
Bharat Mediratta
5400c4be26 Oops, fix up a bug originally added in
7d66ab2e94 when I tweaked the name of
the rss_available variable to be rss_visible, but got it wrong.  Bump
the comment module to 6 so that we run the installer and clean up old
vars.

Fixes #1854.
2012-05-07 13:45:13 -07:00
Bharat Mediratta
6effd5f75e Update date format to make it RFC822 compliant. Thanks to moullas. Fixes #1798. 2012-05-07 13:30:39 -07:00
Bharat Mediratta
7d66ab2e94 Improve comment RSS feed visibility, initially added by Thomas E. Horner in
fc942aacda.

Change some variable names, refactor out visibility checking code, actually
check visibility at generation time instead of just suppressing the UI,
update module.info

Fixes #1829.
2012-03-29 13:06:44 -07:00
Bharat Mediratta
60286bfba3 Merge commit 'fc942aa' 2012-03-29 06:37:00 -07:00
Bharat Mediratta
bf2bb3e1ea Update copyright to 2012. #1822 2012-02-27 09:48:23 -08:00
Thomas E. Horner
fc942aacda availability of rss is now configurable 2011-07-08 09:33:51 +02:00
Bharat Mediratta
743e2f88d8 Overhaul the Admin > Content > Comments page. Use a tabbed interface
for consistency with other parts of the admin UI (ie: G2 import).

The UI is now Ajax driven because that's how jQuery tabs works best in
this case.  This requires a little finagling in JS to get the
paginator links to load properly.  While I'm in there, add a paginator
at the top of the table, make the buttons in the delete tab sane and
smooth scroll back to the top of the tab when switching pages.

Fixes #1702
2011-04-26 21:02:43 -07:00
Bharat Mediratta
5cf38ed816 Stop using Pagination() and instead use $theme->pager() in views.
Move the pager() function up to Gallery_View and replace
themes/admin_wind/views/pager.html.php (Pagination based) with a
modified version from the wind theme in
themes/admin_wind/views/paginator.html.php.  Fixes #1718.
2011-04-26 09:48:21 -07:00
Bharat Mediratta
c07af35a19 Oops, fix broken codex urls. For #1698. 2011-04-23 14:53:39 -07:00
Bharat Mediratta
ba20d5a500 Oops, this is the rest of the modules and themes for #1696 and #1698. 2011-04-23 14:46:07 -07:00
Bharat Mediratta
c12c43a415 A little more work on kandsten's fix for IPv6 support in
10785b1e82:

- some style cleanup
- bump the module version in module.info
- rebuild the installer.sql
2011-03-27 11:38:37 -07:00
Kriss Andsten
10785b1e82 Extend comment module field lenghts to fit IPv6 remote host addresses and long (but legally so) hostnames. 2011-03-27 11:34:52 -07:00
Bharat Mediratta
423daa52d5 Update copyright to 2011. 2011-01-21 23:01:06 -08:00
Bharat Mediratta
ee13b934f4 Fix all the head() and admin_head() theme callbacks to return the
results of the $theme->css() and $theme->script() calls.  This handles
the case where combining scripts/css returns HTML instead of putting
it in the queue for combination.  Fixes #1611.
2011-01-15 13:14:43 -08:00
Bharat Mediratta
b42fcb9cda Use db::expr instead of "new Database_Expression". Resolves #1560. 2010-12-28 23:10:05 -08:00
Bharat Mediratta
dff1a53696 All modules should be named Xxx_Core for extensibility. Fixes #1458. 2010-10-25 21:05:31 -07:00
Bharat Mediratta
8ee25157ec Fix a bug in the way that we calculate expiration dates for old
comments by using Database_Expression.  Fixes ticket #1386.
2010-09-18 14:29:52 -07:00
Bharat Mediratta
3e3098956c Convert the guest_url ORM validation failure back to the url form
parameter and put in a message requiring a valid url.  Fixes ticket
2010-09-16 14:19:28 -07:00
Bharat Mediratta
db75ac642a Use the title of the root album as the site title for all RSS feeds.
Fixes ticket #1307.
2010-09-04 13:40:39 -07:00
Bharat Mediratta
dc80cde379 Add "captcha_protect_form" event that the recaptcha module grabs and
uses to add a captcha to the end of the first group in the form.  If
there are no groups, it adds the captcha at the end of the form.
Updated user_profile and comment forms to use it.
2010-08-22 13:00:08 -07:00
Bharat Mediratta
b6a5014047 Fix a pagination bug. Fixes ticket #1280. 2010-08-09 00:29:28 -07:00
Bharat Mediratta
2dda8e22a7 Use the gallery helper date/time functions wherever we format date
time for the browser.  Fixes ticket #1278.
2010-08-08 16:54:31 -07:00
Bharat Mediratta
e5a1da71ed Convert tabs to spaces to fix File_Structure_Test. 2010-08-08 15:05:55 -07:00
Bharat Mediratta
7607e1f932 Full pass over all the JSON encoding and JS dialog code. We now abide
by the following rules:

1) An initial dialog or panel load can take either HTML or JSON, but
   the mime type must accurately reflect its payload.

2) dialog form submits can handle a pure HTML response, but the mime
   type must also be correct.  This properly resolves the problem
   where the reauth code gets a JSON response first from the reauth
   code, and then an HTML response when you reauth and continue on to
   a given form -- try it out with Admin > Settings > Advanced.

3) All JSON replies must set the mime type correctly.  The json::reply
   convenience function does this for us.

4) By default, any HTML content sent back in the JSON response should be
   in the "html" field, no longer the "form" field.

The combination of these allows us to stop doing boilerplate code like
this in our controllers:

  // Print our view, JSON encoded
  json::reply(array("form" => (string) $view));

instead, controllers can just return HTML, eg:

  // Print our view
  print $view;

That's much more intuitive for developers.
2010-07-31 21:16:17 -07:00
Tim Almdal
91a2c04a24 More patches as part of #1225. Change the 'core' modules to use the json::reply
method to set the content type header and encode the response as a json object
2010-07-31 15:44:55 -07:00
Bharat Mediratta
74e821b03e Rename the feed variable from "children" to "comments" since that
makes more semantic sense.
2010-06-20 17:21:25 -07:00
Bharat Mediratta
7938a57dbe Oops. Remove debug line. 2010-06-20 10:57:48 -07:00
Bharat Mediratta
7500273228 Simplify the descendent logic. viewable() already joins with the
items table so there's no need for a subquery.  The subquery could
generate way too many ids since it didn't pay attention to
permissions.  This isn't a security problem since we were restricting
the item ids according to permissions in the outer query, but it's
wasteful.
2010-06-20 10:55:10 -07:00
Bharat Mediratta
f0a99ffc27 Undo "else" clause -- we should keep the logic simple and easy to
follow, even if it's redundant.

Expand a <ul> to multiple lines.
2010-06-18 14:31:04 -07:00
Tim Almdal
70f56ba43a Fix for ticket #1163. Don't all guests to a comment when there are no comments and the comment access permission is register users. 2010-06-17 14:22:35 -07:00
Bharat Mediratta
a27189ce9f Remove comment_rest::post() -- that's in comments_rest now. 2010-06-16 20:02:52 -07:00
Bharat Mediratta
1aeaa7daab Add REST support for comments. You can view, add, edit and delete
comments.
2010-06-16 18:05:15 -07:00
Tim Almdal
8ee60e6b5d slap my wrist... i forgot a debugging statement 2010-06-16 11:17:18 -07:00
Tim Almdal
ea8653f947 Fix for ticket #1131. If the rss feed is for an item, then retrieve the item. Using the left and right pointers find all the comments for the child items. Thanks to jankoprowski for the initial investigation. 2010-06-16 08:39:09 -07:00
Bharat Mediratta
94ada2361d Fix a bug in the upgrader where we weren't bumping the version number
during the upgrade path, so the 2nd stanza (version 2 to version 3) was never getting executed.
2010-06-15 16:14:30 -07:00
Bharat Mediratta
87fde3f360 Create a UI under Admin > Settings > Comments where you can limit
comments only to registered users.  It's simplistic, but is better
than adding a permission since generally this setting will be used
Gallery-wide.

Fixes ticket #1002
2010-06-05 23:35:32 -07:00
Bharat Mediratta
ab204d2720 Rename the admin_comments view to admin_manage_comments to match the controller. 2010-05-16 23:01:57 -07:00
Bharat Mediratta
2157285d9b Rename admin/comments to admin/manage_comments to make room for
admin/comments to be a settings page.
2010-05-16 22:53:19 -07:00
Bharat Mediratta
ad0e7254eb Require a well-formed email address for all comments. 2010-05-14 16:19:53 -07:00