stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-05 20:49:09 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rename mark_safe() to mark_clean()

Browse Source
This commit is contained in:
Andy Staudacher
2009-08-31 00:42:18 -07:00
parent 6d26b0dd6e
commit ddb84c84e1
17 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/akismet/helpers/akismet.php
View File

@@ -94,7 +94,7 @@ class akismet_Core {
if (empty($api_key)) {
site_status::warning(
t("Akismet is not quite ready! Please provide an <a href=\"%url\">API Key</a>",
array("url" => html::mark_safe(url::site("admin/akismet")))),
array("url" => html::mark_clean(url::site("admin/akismet")))),
"akismet_config");
} else {
site_status::clear("akismet_config");

2
modules/digibug/views/admin_digibug.html.php
View File

@@ -16,7 +16,7 @@
<p>
<?= t("You don't need an account with Digibug, but if you <a href=\"%signup_url\">register with Digibug</a> and enter your Digibug id in the <a href=\"%advanced_settings_url\">Advanced Settings</a> page you can make money off of your photos!",
array("signup_url" => "http://www.digibug.com/signup.php",
"advanced_settings_url" => html::mark_safe(url::site("admin/advanced_settings")))) ?>
"advanced_settings_url" => html::mark_clean(url::site("admin/advanced_settings")))) ?>
</p>
</div>
</div>

2
modules/exif/helpers/exif.php
View File

@@ -164,7 +164,7 @@ class exif_Core {
if ($remaining) {
site_status::warning(
t('Your Exif index needs to be updated. <a href="%url" class="gDialogLink">Fix this now</a>',
array("url" => html::mark_safe(url::site("admin/maintenance/start/exif_task::update_index?csrf=__CSRF__")))),
array("url" => html::mark_clean(url::site("admin/maintenance/start/exif_task::update_index?csrf=__CSRF__")))),
"exif_index_out_of_date");
}
}

4
modules/g2_import/views/admin_g2_import.html.php
View File

@@ -39,7 +39,7 @@
<?= t("Your most common thumbnail size in Gallery 2 is %g2_pixels pixels, but your Gallery 3 thumbnail size is set to %g3_pixels pixels. <a href=\"%url\">Using the same value</a> will speed up your import.",
array("g2_pixels" => $g2_sizes["thumb"]["size"],
"g3_pixels" => $thumb_size,
"url" => html::mark_safe(url::site("admin/theme_options")))) ?>
"url" => html::mark_clean(url::site("admin/theme_options")))) ?>
</li>
<? endif ?>
@@ -48,7 +48,7 @@
<?= t("Your most common intermediate size in Gallery 2 is %g2_pixels pixels, but your Gallery 3 thumbnail size is set to %g3_pixels pixels. <a href=\"%url\">Using the same value</a> will speed up your import.",
array("g2_pixels" => $g2_sizes["resize"]["size"],
"g3_pixels" => $resize_size,
"url" => html::mark_safe(url::site("admin/theme_options")))) ?>
"url" => html::mark_clean(url::site("admin/theme_options")))) ?>
</li>
<? endif ?>
</ul>

2
modules/gallery/controllers/admin_languages.php
View File

@@ -111,7 +111,7 @@ class Admin_Languages_Controller extends Admin_Controller {
$group->input("api_key")
->label(empty($api_key)
? t("This is a unique key that will allow you to send translations to the remote server. To get your API key go to %server-link.",
array("server-link" => html::mark_safe(html::anchor($server_link))))
array("server-link" => html::mark_clean(html::anchor($server_link))))
: t("API Key"))
->value($api_key)
->error_messages("invalid", t("The API key you provided is invalid."));

6
modules/gallery/helpers/MY_html.php
View File

@@ -51,12 +51,12 @@ class html extends html_Core {
*
* Example:<pre>
* // Parameters to t() are automatically escaped by default.
* // If the parameter is marked as safe, it won't get escaped.
* // If the parameter is marked as clean, it won't get escaped.
* t('Go <a href="%url">there</a>',
* array("url" => html::mark_safe(url::current())))
* array("url" => html::mark_clean(url::current())))
* </pre>
*/
static function mark_safe($html) {
static function mark_clean($html) {
return SafeString::of_safe_html($html);
}

2
modules/gallery/helpers/graphics.php
View File

@@ -443,7 +443,7 @@ class graphics_Core {
if (!module::get_var("gallery", "graphics_toolkit")) {
site_status::warning(
t("Graphics toolkit missing! Please <a href=\"%url\">choose a toolkit</a>",
array("url" => html::mark_safe(url::site("admin/graphics")))),
array("url" => html::mark_clean(url::site("admin/graphics")))),
"missing_graphics_toolkit");
}
}

4
modules/gallery/tests/Html_Helper_Test.php
View File

@@ -32,8 +32,8 @@ class Html_Helper_Test extends Unit_Test_Case {
$this->assert_true($safe_string instanceof SafeString);
}
public function mark_safe_test() {
$safe_string = html::mark_safe("hello <p >world</p>");
public function mark_clean_test() {
$safe_string = html::mark_clean("hello <p >world</p>");
$this->assert_true($safe_string instanceof SafeString);
$safe_string_2 = html::clean($safe_string);
$this->assert_equal("hello <p >world</p>",

2
modules/gallery/tests/Xss_Security_Test.php
View File

@@ -195,7 +195,7 @@ class Xss_Security_Test extends Unit_Test_Case {
in_array($tokens[$token_number + 2][1],
array("clean", "purify", "js_string", "clean_attribute")) &&
self::_token_matches("(", $tokens, $token_number + 3)) {
// Not checking for mark_safe(). We want such calls to be marked dirty (thus reviewed).
// Not checking for mark_clean(). We want such calls to be marked dirty (thus reviewed).
$method = $tokens[$token_number + 2][1];
$frame->expr_append("::$method(");

10
modules/gallery/views/admin_block_welcome.html.php
View File

@@ -5,16 +5,16 @@
<ul>
<li>
<?= t("General Settings - choose your <a href=\"%graphics_url\">graphics</a> and <a href=\"%language_url\">language</a> settings.",
array("graphics_url" => html::mark_safe(url::site("admin/graphics")),
"language_url" => html::mark_safe(url::site("admin/languages")))) ?>
array("graphics_url" => html::mark_clean(url::site("admin/graphics")),
"language_url" => html::mark_clean(url::site("admin/languages")))) ?>
</li>
<li>
<?= t("Appearance - <a href=\"%theme_url\">choose a theme</a>, or <a href=\"%theme_options_url\">customize the way it looks</a>.",
array("theme_url" => html::mark_safe(url::site("admin/themes")),
"theme_options_url" => html::mark_safe(url::site("admin/theme_options")))) ?>
array("theme_url" => html::mark_clean(url::site("admin/themes")),
"theme_options_url" => html::mark_clean(url::site("admin/theme_options")))) ?>
</li>
<li>
<?= t("Customize - <a href=\"%modules_url\">install modules</a> to add cool features!",
array("modules_url" => html::mark_safe(url::site("admin/modules")))) ?>
array("modules_url" => html::mark_clean(url::site("admin/modules")))) ?>
</li>
</ul>

2
modules/gallery/views/permissions_browse.html.php
View File

@@ -29,7 +29,7 @@
<ul id="gMessage">
<li class="gError">
<?= t("Oh no! Your server needs a configuration change in order for you to hide photos! Ask your server administrator to enable <a %mod_rewrite_attrs>mod_rewrite</a> and set <a %apache_attrs><i>AllowOverride FileInfo Options</i></a> to fix this.",
array("mod_rewrite_attrs" => html::mark_safe("href=\"http://httpd.apache.org/docs/2.0/mod/mod_rewrite.html\" target=\"_blank\"", "apache_attrs" => "href=\"http://httpd.apache.org/docs/2.0/mod/core.html#allowoverride\" target=\"_blank\""))) ?>
array("mod_rewrite_attrs" => html::mark_clean("href=\"http://httpd.apache.org/docs/2.0/mod/mod_rewrite.html\" target=\"_blank\"", "apache_attrs" => "href=\"http://httpd.apache.org/docs/2.0/mod/core.html#allowoverride\" target=\"_blank\""))) ?>
</li>
</ul>
<? endif ?>

2
modules/gallery/views/upgrader.html.php
View File

@@ -18,7 +18,7 @@
<h1> <?= t("That's it!") ?> </h1>
<p>
<?= t("Your <a href=\"%url\">Gallery</a> is up to date.",
array("url" => html::mark_safe(url::site("albums/1")))) ?>
array("url" => html::mark_clean(url::site("albums/1")))) ?>
</p>
</div>
</div>

2
modules/recaptcha/helpers/recaptcha.php
View File

@@ -43,7 +43,7 @@ class recaptcha_Core {
if (empty($public_key) || empty($private_key)) {
site_status::warning(
t("reCAPTCHA is not quite ready! Please configure the <a href=\"%url\">reCAPTCHA Keys</a>",
array("url" => html::mark_safe(url::site("admin/recaptcha")))),
array("url" => html::mark_clean(url::site("admin/recaptcha")))),
"recaptcha_config");
} else {
site_status::clear("recaptcha_config");

2
modules/search/helpers/search.php
View File

@@ -58,7 +58,7 @@ class search_Core {
if ($remaining) {
site_status::warning(
t('Your search index needs to be updated. <a href="%url" class="gDialogLink">Fix this now</a>',
array("url" => html::mark_safe(url::site("admin/maintenance/start/search_task::update_index?csrf=__CSRF__")))),
array("url" => html::mark_clean(url::site("admin/maintenance/start/search_task::update_index?csrf=__CSRF__")))),
"search_index_out_of_date");
}
}

2
modules/server_add/helpers/server_add.php
View File

@@ -25,7 +25,7 @@ class server_add_Core {
if (empty($paths)) {
site_status::warning(
t("Server Add needs configuration. <a href=\"%url\">Configure it now!</a>",
array("url" => html::mark_safe(url::site("admin/server_add")))),
array("url" => html::mark_clean(url::site("admin/server_add")))),
"server_add_configuration");
} else {
site_status::clear("server_add_configuration");

2
modules/user/views/login.html.php
View File

@@ -8,7 +8,7 @@
</li>
<? else: ?>
<li class="first">
<?= t('Logged in as %name', array('name' => html::mark_safe(
<?= t('Logged in as %name', array('name' => html::mark_clean(
'<a href="' . url::site("form/edit/users/{$user->id}") .
'" title="' . t("Edit Your Profile")->for_html_attr() .
'" id="gUserProfileLink" class="gDialogLink">' .

2
modules/user/views/reset_password.html.php
View File

@@ -10,7 +10,7 @@
</p>
<p>
<?= t("We received a request to reset your password for <a href=\"%site_url\">%site_url</a>. If you made this request, you can confirm it by <a href=\"%confirm_url\">clicking this link</a>. If you didn't request this password reset, it's ok to ignore this mail.",
array("site_url" => html::mark_safe(url::base(false, "http")),
array("site_url" => html::mark_clean(url::base(false, "http")),
"confirm_url" => $confirm_url)) ?>
</p>
</body>