midfavila
/
ubase
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Remove explicit_bzero() calls

This commit is contained in:
sin 2014-06-03 12:13:48 +01:00
parent bd4b6f4e47
commit 2f10d16b9f
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
login.c
View File

@ -85,16 +85,12 @@ main(int argc, char *argv[])
eprintf("denied\n"); eprintf("denied\n");
} }
cryptpass = crypt(pass, spw->sp_pwdp); cryptpass = crypt(pass, spw->sp_pwdp);
explicit_bzero(pass, strlen(pass));
if (!cryptpass) if (!cryptpass)
eprintf("crypt:"); eprintf("crypt:");
if (strcmp(cryptpass, spw->sp_pwdp) != 0) if (strcmp(cryptpass, spw->sp_pwdp) != 0)
eprintf("login failed\n"); eprintf("login failed\n");
explicit_bzero(cryptpass, strlen(cryptpass));
explicit_bzero(spw, sizeof *spw);
} else { } else {
cryptpass = crypt(pass, pw->pw_passwd); cryptpass = crypt(pass, pw->pw_passwd);
explicit_bzero(pass, strlen(pass));
if (!cryptpass) if (!cryptpass)
eprintf("crypt:"); eprintf("crypt:");
if (strcmp(cryptpass, pw->pw_passwd) != 0) if (strcmp(cryptpass, pw->pw_passwd) != 0)

6
su.c
View File

@ -101,7 +101,6 @@ main(int argc, char *argv[])
if (strcmp(cryptpass, spw->sp_pwdp) != 0) if (strcmp(cryptpass, spw->sp_pwdp) != 0)
eprintf(randreply()); eprintf(randreply());
} }
explicit_bzero(spw, sizeof *spw);
} else { } else {
if (uid) { if (uid) {
cryptpass = crypt(pass, pw->pw_passwd); cryptpass = crypt(pass, pw->pw_passwd);
@ -112,11 +111,6 @@ main(int argc, char *argv[])
} }
} }
if (uid) {
explicit_bzero(pass, strlen(pass));
explicit_bzero(cryptpass, strlen(cryptpass));
}
dosu: dosu:
if (initgroups(usr, pw->pw_gid) < 0) if (initgroups(usr, pw->pw_gid) < 0)
eprintf("initgroups:"); eprintf("initgroups:");