b6b977f63d
I've been wanting to do this for a while now, as tar(1) used to
be one of messiest and cruftiest tools.
First off, before walking through the audit, I'll talk about
what the DIRFIRST-flag for recurse() does.
It basically calls fn() on the first-level-dir before calling
it's subentries. It's necessary here, because else the order
of the tar-files would've been wrong (it would try to create
dir/file before creating dir/).
Now, to the audit:
1) Update manpage, fix mistake that compression is also available
for compressing. It's only available for extracting.
2) Define the major, minor and makedev macros from glibc by ourselves.
No need to rely on them, as they are common sense.
decomp()
3) Simple refactorization.
putoctal()
4) Add a truncation check for snprintf().
archive()
5) BUGFIX: Add checks to any checkable function, don't blindly call
them, this is harmful and there are 100 ways to exploit that.
6) Use estrlcpy() instead of snprintf() wherever possible, fix
alignment.
7) BUGFIX: Terminate the result-buffer of readlink(), check if
it even succeeded.
8) Fix sizeof()-formatting.
unarchive()
9) BUGFIX: Add checks to any checkable function, don't blindly call
them, this is harmful and there are 100 ways to exploit that.
10) BUGFIX: strtoul can happily return negative numbers. Add checks
for that and also if the full string has been processed.
11) Remove calls to perror(). We have eprintf, use it.
12) BUGFIX: "minor = strtoul(h->mode, 0, 8);". We need h->minor of
course.
13) Fix typo "usupported", remove fprintf-call.
print()
14) Check fread().
xt()
15) Get rid of snprintf-magic. Use estrlcat().
16) BUGFIX: check for ferror() on the tarfile.
usage()
17) Update it. The old usage() was like 1000 years old.
main()
18) Add DIRFIRST-flag to the recursor.
19) Don't print usage() when a mode is re-set. We allow this in
general.
20) Add function checks and fix error messages.
21) Add tarfilename-global for proper error-messages.
42 lines
839 B
C
42 lines
839 B
C
/* See LICENSE file for copyright and license details. */
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
struct history {
|
|
struct history *prev;
|
|
dev_t dev;
|
|
ino_t ino;
|
|
};
|
|
|
|
struct recursor {
|
|
void (*fn)(const char *, struct stat *st, void *, struct recursor *);
|
|
struct history *hist;
|
|
int depth;
|
|
int follow;
|
|
int flags;
|
|
};
|
|
|
|
enum {
|
|
SAMEDEV = 1 << 0,
|
|
DIRFIRST = 1 << 1,
|
|
};
|
|
|
|
extern int cp_aflag;
|
|
extern int cp_fflag;
|
|
extern int cp_pflag;
|
|
extern int cp_rflag;
|
|
extern int cp_vflag;
|
|
extern int cp_follow;
|
|
extern int cp_status;
|
|
|
|
extern int rm_fflag;
|
|
extern int rm_rflag;
|
|
extern int rm_status;
|
|
|
|
extern int recurse_status;
|
|
|
|
void recurse(const char *, void *, struct recursor *);
|
|
|
|
int cp(const char *, const char *, int);
|
|
void rm(const char *, struct stat *st, void *, struct recursor *);
|