sbase/libutil
FRIGN 11e2d472bf Add *fshut() functions to properly flush file streams
This has been a known issue for a long time. Example:

printf "word" > /dev/full

wouldn't report there's not enough space on the device.
This is due to the fact that every libc has internal buffers
for stdout which store fragments of written data until they reach
a certain size or on some callback to flush them all at once to the
kernel.
You can force the libc to flush them with fflush(). In case flushing
fails, you can check the return value of fflush() and report an error.

However, previously, sbase didn't have such checks and without fflush(),
the libc silently flushes the buffers on exit without checking the errors.
No offense, but there's no way for the libc to report errors in the exit-
condition.

GNU coreutils solve this by having onexit-callbacks to handle the flushing
and report issues, but they have obvious deficiencies.
After long discussions on IRC, we came to the conclusion that checking the
return value of every io-function would be a bit too much, and having a
general-purpose fclose-wrapper would be the best way to go.

It turned out that fclose() alone is not enough to detect errors. The right
way to do it is to fflush() + check ferror on the fp and then to a fclose().
This is what fshut does and that's how it's done before each return.
The return value is obviously affected, reporting an error in case a flush
or close failed, but also when reading failed for some reason, the error-
state is caught.

the !!( ... + ...) construction is used to call all functions inside the
brackets and not "terminating" on the first.
We want errors to be reported, but there's no reason to stop flushing buffers
when one other file buffer has issues.
Obviously, functionales come before the flush and ret-logic comes after to
prevent early exits as well without reporting warnings if there are any.

One more advantage of fshut() is that it is even able to report errors
on obscure NFS-setups which the other coreutils are unable to detect,
because they only check the return-value of fflush() and fclose(),
not ferror() as well.
2015-04-05 09:13:56 +01:00
..
concat.c Add *fshut() functions to properly flush file streams 2015-04-05 09:13:56 +01:00
cp.c Audit cp() in libutil 2015-03-19 17:57:12 +01:00
crypt.c fix some signed/unsigned warnings and style fixes 2015-03-27 22:48:05 +01:00
ealloc.c add estrndup 2015-02-11 01:17:21 +00:00
enmasse.c Remove apathmax() and implicitly agetcwd() 2015-03-18 15:20:35 +01:00
eprintf.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
eregcomp.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
estrtod.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
fnck.c Refactor enmasse() and recurse() to reflect depth 2015-03-02 22:50:38 +01:00
fshut.c Add *fshut() functions to properly flush file streams 2015-04-05 09:13:56 +01:00
getlines.c libutil/getlines: style fix 2015-03-29 21:55:34 +02:00
human.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
md5.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
mode.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
putword.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
reallocarray.c Implement mallocarray() 2015-03-10 22:19:19 +01:00
recurse.c Audit tar(1), add DIRFIRST-flag to recurse() 2015-03-21 01:30:47 +01:00
rm.c Refactor recurse() again 2015-03-19 01:08:19 +01:00
sha1.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
sha256.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
sha512.c Rename util/ to libutil/ 2014-11-17 16:48:34 +00:00
strcasestr.c Argh - include strings.h 2014-11-21 00:03:30 +00:00
strlcat.c Add estrlcat() and estrlcpy() 2015-03-17 11:24:49 +01:00
strlcpy.c Add estrlcat() and estrlcpy() 2015-03-17 11:24:49 +01:00
strsep.c Import strsep() from musl libc 2015-01-25 17:48:11 +00:00
strtonum.c Use strtonum and libutf in test(1), refactor code and manpage 2015-02-09 22:21:23 +01:00
unescape.c Add \e, \", \' and hex-escapes (\xH[H]) to unescape() 2015-02-14 22:55:37 +01:00