midfavila/sbase
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Audit uudecode(1)

Browse Source 
Style cleanup, Manpage refactoring.
This commit is contained in:
FRIGN 2015-03-18 00:10:36 +01:00
parent 4af8889396
commit 1b71559431
3 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README
View File

@ -84,7 +84,7 @@ The following tools are implemented ('*' == finished, '#' == UTF-8 support,
#*| unexpand yes none #*| unexpand yes none
=*| uniq yes none =*| uniq yes none
=*| unlink yes none =*| unlink yes none
=* uudecode yes none =*| uudecode yes none
=* uuencode yes none =* uuencode yes none
#* wc yes none #* wc yes none
= xargs no -I, -L, -p, -s, -t, -x = xargs no -I, -L, -p, -s, -t, -x

24
uudecode.1
View File

@ -1,4 +1,4 @@
.Dd February 13, 2015 .Dd March 18, 2015
.Dt UUDECODE 1 .Dt UUDECODE 1
.Os sbase .Os sbase
.Sh NAME .Sh NAME
@ -13,23 +13,27 @@
.Nm .Nm
reads reads
.Ar file .Ar file
(or by default, the standard input) and writes a decoded and writes a decoded version to the file specified in the uuencoded header.
version to the file specified in the uuencoded header. In case that In case the file already exists, it is truncated. Otherwise a new file is
the file already exists, it is truncated. Otherwise a new file is created. The permissions of the created/accessed file are changed to
created. After the operation the permissions of the created/accessed reflect the mode in the header.
are changed to reflect the mode in the header. If no
.Ar file
is given
.Nm
reads from stdin.
.Sh OPTIONS .Sh OPTIONS
.Bl -tag -width Ds .Bl -tag -width Ds
.It Fl m .It Fl m
Use Base64 for decoding. Use Base64 for decoding.
.It Fl o Ar output .It Fl o Ar output
Use the file specified by Write to
.Ar output .Ar output
instead of standard output. rather than the file specified in the header.
.El .El
.Sh IMPLEMENTATION NOTES .Sh IMPLEMENTATION NOTES
For safety currently uudecode operates only on regular files and For safety uudecode operates on regular files and stdout only.
stdout. Trying to uudecode to a link, directory, or special file Trying to uudecode to a link, directory, or special file
yields an error. yields an error.
.Sh SEE ALSO .Sh SEE ALSO
.Xr uuencode 1 .Xr uuencode 1

13
uudecode.c
View File

@ -17,7 +17,7 @@ parsefile(const char *fname)
struct stat st; struct stat st;
int ret; int ret;
if (strcmp(fname, "/dev/stdout") == 0 || strcmp(fname, "-") == 0) if (!strcmp(fname, "/dev/stdout") || !strcmp(fname, "-"))
return stdout; return stdout;
ret = lstat(fname, &st); ret = lstat(fname, &st);
/* if it is a new file, try to open it */ /* if it is a new file, try to open it */
@ -36,8 +36,7 @@ tropen:
} }
static void static void
parseheader(FILE *fp, const char *s, char **header, mode_t *mode, parseheader(FILE *fp, const char *s, char **header, mode_t *mode, char **fname)
char **fname)
{ {
char bufs[PATH_MAX + 18]; /* len header + mode + maxname */ char bufs[PATH_MAX + 18]; /* len header + mode + maxname */
char *p, *q; char *p, *q;
@ -212,7 +211,7 @@ uudecode(FILE *fp, FILE *outfp)
} }
/* check for end or fail */ /* check for end or fail */
len = getline(&bufb, &n, fp); len = getline(&bufb, &n, fp);
if (len < 3 || strncmp(bufb, "end", 3) != 0 || bufb[3] != '\n') if (len < 3 || strncmp(bufb, "end", 3) || bufb[3] != '\n')
eprintf("invalid uudecode footer \"end\" not found\n"); eprintf("invalid uudecode footer \"end\" not found\n");
free(bufb); free(bufb);
} }
@ -227,11 +226,9 @@ int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
FILE *fp = NULL, *nfp = NULL; FILE *fp = NULL, *nfp = NULL;
char *fname, *header;
const char *ifname;
mode_t mode = 0; mode_t mode = 0;
char *fname, *header, *ifname, *ofname = NULL;
void (*d) (FILE *, FILE *) = NULL; void (*d) (FILE *, FILE *) = NULL;
char *ofname = NULL;
ARGBEGIN { ARGBEGIN {
case 'm': case 'm':
@ -248,7 +245,7 @@ main(int argc, char *argv[])
if (argc > 1) if (argc > 1)
usage(); usage();
if (argc == 0) { if (!argc) {
fp = stdin; fp = stdin;
ifname = "<stdin>"; ifname = "<stdin>";
} else { } else {