midfavila/sbase
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Remove fflush-check from fshut()

Browse Source 
Basically, it's a conflict between POSIX and ISO C what do to when
input streams are passed to fflush().
POSIX mandates that the seeking-position should be synced, but ISO C
says it's undefined behaviour.
We love POSIX, but the standard-documents specify that in all conflict
cases, ISO C wins, so this breaks with EBADF on BSD's.

musl and glibc follow POSIX behaviour, which makes sense, but involves
numerous portability concerns.

To get around this, we just don't check fflush() and rely on the fact
that no implementation sets ferror on the file-stream in fflush if it
is an input stream, so every issue caught in fflush() is caught later
with ferror() and fclose().

Add a comment to fshut() because this stuff is so complicated, it
took us a day to figure out.
This commit is contained in:
FRIGN 2015-04-05 00:04:58 +02:00 committed by sin
parent 28c5d560fb
commit 0c470f5563
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libutil/fshut.c
View File

@ -7,10 +7,12 @@ int fshut(FILE *fp, const char *fname)
{ {
int ret = 0; int ret = 0;
if (fflush(fp) && !ret) { /* fflush() is undefined for input streams by ISO C,
weprintf("fflush %s:", fname); * but not POSIX 2008 if you ignore ISO C overrides.
ret = 1; * Leave it unchecked an rely on the following
} * functions to detect errors.
*/
fflush(fp);
if (ferror(fp) && !ret) { if (ferror(fp) && !ret) {
weprintf("ferror %s:", fname); weprintf("ferror %s:", fname);