flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

Minor startup streamlining

Browse Source 
* LOGD'd unneeded debugging messages, streamlining startup
+ Added a basic timer for how long in seconds it took to start up
+ Added two checks for plural (plugin/s, second/s)
This commit is contained in:
Tiger Wang 2013-09-28 20:36:01 +01:00
parent 21b23ff1e7
commit cc5c56d545
8 changed files with 60 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/CraftingRecipes.cpp
View File

@ -310,7 +310,7 @@ void cCraftingRecipes::GetRecipe(const cPlayer * a_Player, const cCraftingGrid &
void cCraftingRecipes::LoadRecipes(void) void cCraftingRecipes::LoadRecipes(void)
{ {
LOG("-- Loading crafting recipes from crafting.txt --"); LOGD("Loading crafting recipes from crafting.txt...");
ClearRecipes(); ClearRecipes();
// Load the crafting.txt file: // Load the crafting.txt file:
@ -338,7 +338,7 @@ void cCraftingRecipes::LoadRecipes(void)
} }
AddRecipeLine(LineNum, Recipe); AddRecipeLine(LineNum, Recipe);
} // for itr - Split[] } // for itr - Split[]
LOG("-- %d crafting recipes loaded from crafting.txt --", m_Recipes.size()); LOG("Loaded %d crafting recipes", m_Recipes.size());
} }

4
source/FurnaceRecipe.cpp
View File

@ -51,7 +51,7 @@ cFurnaceRecipe::~cFurnaceRecipe()
void cFurnaceRecipe::ReloadRecipes(void) void cFurnaceRecipe::ReloadRecipes(void)
{ {
ClearRecipes(); ClearRecipes();
LOG("-- Loading furnace recipes --"); LOGD("Loading furnace recipes...");
std::ifstream f; std::ifstream f;
char a_File[] = "furnace.txt"; char a_File[] = "furnace.txt";
@ -175,7 +175,7 @@ void cFurnaceRecipe::ReloadRecipes(void)
{ {
LOGERROR("ERROR: FurnaceRecipe, syntax error" ); LOGERROR("ERROR: FurnaceRecipe, syntax error" );
} }
LOG("Got %u furnace recipes, and %u fuels.", m_pState->Recipes.size(), m_pState->Fuel.size()); LOG("Loaded %u furnace recipes and %u fuels", m_pState->Recipes.size(), m_pState->Fuel.size());
} }

2
source/Generating/ComposableGenerator.cpp
View File

@ -294,7 +294,7 @@ void cComposableGenerator::InitHeightGen(cIniFile & a_IniFile)
); );
CacheSize = 4; CacheSize = 4;
} }
LOGINFO("Using a cache for Heightgen of size %d.", CacheSize); LOGD("Using a cache for Heightgen of size %d.", CacheSize);
m_UnderlyingHeightGen = m_HeightGen; m_UnderlyingHeightGen = m_HeightGen;
m_HeightGen = new cHeiGenCache(m_UnderlyingHeightGen, CacheSize); m_HeightGen = new cHeiGenCache(m_UnderlyingHeightGen, CacheSize);
} }

8
source/GroupManager.cpp
View File

@ -43,7 +43,7 @@ cGroupManager::~cGroupManager()
cGroupManager::cGroupManager() cGroupManager::cGroupManager()
: m_pState( new sGroupManagerState ) : m_pState( new sGroupManagerState )
{ {
LOG("-- Loading Groups --"); LOGD("-- Loading Groups --");
cIniFile IniFile("groups.ini"); cIniFile IniFile("groups.ini");
if (!IniFile.ReadFile()) if (!IniFile.ReadFile())
{ {
@ -57,7 +57,7 @@ cGroupManager::cGroupManager()
std::string KeyName = IniFile.GetKeyName( i ); std::string KeyName = IniFile.GetKeyName( i );
cGroup* Group = GetGroup( KeyName.c_str() ); cGroup* Group = GetGroup( KeyName.c_str() );
LOG("Loading group: %s", KeyName.c_str() ); LOGD("Loading group: %s", KeyName.c_str() );
Group->SetName( KeyName ); Group->SetName( KeyName );
char Color = IniFile.GetValue( KeyName, "Color", "-" )[0]; char Color = IniFile.GetValue( KeyName, "Color", "-" )[0];
@ -73,7 +73,6 @@ cGroupManager::cGroupManager()
for( unsigned int i = 0; i < Split.size(); i++) for( unsigned int i = 0; i < Split.size(); i++)
{ {
Group->AddCommand( Split[i] ); Group->AddCommand( Split[i] );
//LOG("%s", Split[i].c_str() );
} }
} }
@ -84,7 +83,6 @@ cGroupManager::cGroupManager()
for( unsigned int i = 0; i < Split.size(); i++) for( unsigned int i = 0; i < Split.size(); i++)
{ {
Group->AddPermission( Split[i] ); Group->AddPermission( Split[i] );
//LOGINFO("Permission: %s", Split[i].c_str() );
} }
} }
@ -98,7 +96,7 @@ cGroupManager::cGroupManager()
} }
} }
} }
LOG("-- Groups Successfully Loaded --"); LOGD("-- Groups Successfully Loaded --");
} }

10
source/PluginManager.cpp
View File

@ -95,7 +95,7 @@ void cPluginManager::FindPlugins(void)
void cPluginManager::ReloadPluginsNow(void) void cPluginManager::ReloadPluginsNow(void)
{ {
LOG("Loading plugins"); LOG("-- Loading Plugins --");
m_bReloadPlugins = false; m_bReloadPlugins = false;
UnloadPluginsNow(); UnloadPluginsNow();
@ -135,11 +135,15 @@ void cPluginManager::ReloadPluginsNow(void)
if (GetNumPlugins() == 0) if (GetNumPlugins() == 0)
{ {
LOG("No plugins loaded"); LOG("-- No Plugins Loaded --");
}
else if ((GetNumPlugins() > 1) || (GetNumPlugins() == 0))
{
LOG("-- Loaded %i Plugins --", GetNumPlugins());
} }
else else
{ {
LOG("Loaded %i plugin(s)", GetNumPlugins()); LOG("-- Loaded 1 Plugin --");
} }
} }

64
source/Root.cpp
View File

@ -21,6 +21,7 @@
#include "../iniFile/iniFile.h" #include "../iniFile/iniFile.h"
#include <iostream> #include <iostream>
#include <time.h>
@ -91,6 +92,17 @@ void cRoot::InputThread(void * a_Params)
void cRoot::Start(void) void cRoot::Start(void)
{ {
time_t timer;
struct tm y2k;
double seconds;
double finishseconds;
y2k.tm_hour = 0; y2k.tm_min = 0; y2k.tm_sec = 0;
y2k.tm_year = 100; y2k.tm_mon = 0; y2k.tm_mday = 1;
time(&timer);
seconds = difftime(timer,mktime(&y2k));
cDeadlockDetect dd; cDeadlockDetect dd;
delete m_Log; delete m_Log;
m_Log = new cMCLogger(); m_Log = new cMCLogger();
@ -125,7 +137,7 @@ void cRoot::Start(void)
LOG("Starting server..."); LOG("Starting server...");
if (!m_Server->InitServer(IniFile)) if (!m_Server->InitServer(IniFile))
{ {
LOGERROR("Failed to start server, shutting down."); LOGERROR("Failure starting server, aborting...");
return; return;
} }
IniFile.WriteFile(); IniFile.WriteFile();
@ -138,45 +150,51 @@ void cRoot::Start(void)
if (WebIniFile.GetValueB("WebAdmin", "Enabled", false)) if (WebIniFile.GetValueB("WebAdmin", "Enabled", false))
{ {
LOG("Creating WebAdmin..."); LOGD("Creating WebAdmin...");
m_WebAdmin = new cWebAdmin(8080); m_WebAdmin = new cWebAdmin(8080);
} }
LOG("Loading settings..."); LOGD("Loading settings...");
m_GroupManager = new cGroupManager(); m_GroupManager = new cGroupManager();
m_CraftingRecipes = new cCraftingRecipes; m_CraftingRecipes = new cCraftingRecipes;
m_FurnaceRecipe = new cFurnaceRecipe(); m_FurnaceRecipe = new cFurnaceRecipe();
LOG("Loading worlds..."); LOGD("Loading worlds...");
LoadWorlds(); LoadWorlds();
LOG("Loading plugin manager..."); LOGD("Loading plugin manager...");
m_PluginManager = new cPluginManager(); m_PluginManager = new cPluginManager();
m_PluginManager->ReloadPluginsNow(); m_PluginManager->ReloadPluginsNow();
LOG("Loading MonsterConfig..."); LOGD("Loading MonsterConfig...");
m_MonsterConfig = new cMonsterConfig; m_MonsterConfig = new cMonsterConfig;
// This sets stuff in motion // This sets stuff in motion
LOG("Starting Authenticator..."); LOGD("Starting Authenticator...");
m_Authenticator.Start(); m_Authenticator.Start();
LOG("Starting worlds..."); LOGD("Starting worlds...");
StartWorlds(); StartWorlds();
LOG("Starting deadlock detector..."); LOGD("Starting deadlock detector...");
dd.Start(); dd.Start();
LOG("Starting server..."); LOGD("Finalising startup...");
m_Server->Start(); m_Server->Start();
#if !defined(ANDROID_NDK) #if !defined(ANDROID_NDK)
LOG("Starting InputThread..."); LOGD("Starting InputThread...");
m_InputThread = new cThread( InputThread, this, "cRoot::InputThread" ); m_InputThread = new cThread( InputThread, this, "cRoot::InputThread" );
m_InputThread->Start( false ); // We should NOT wait? Otherwise we can´t stop the server from other threads than the input thread m_InputThread->Start( false ); // We should NOT wait? Otherwise we can´t stop the server from other threads than the input thread
#endif #endif
LOG("Initialization done, server running now."); time(&timer);
finishseconds = difftime(timer,mktime(&y2k));
finishseconds -= seconds;
if ((finishseconds > 1) || (finishseconds == 0)) { LOG("Startup complete, took %.f seconds!", finishseconds); }
else { LOG("Startup complete, took 1 second!"); }
while (!m_bStop && !m_bRestart) // These are modified by external threads while (!m_bStop && !m_bRestart) // These are modified by external threads
{ {
cSleep::MilliSleep(1000); cSleep::MilliSleep(1000);
@ -190,37 +208,37 @@ void cRoot::Start(void)
LOG("Shutting down server..."); LOG("Shutting down server...");
m_Server->Shutdown(); m_Server->Shutdown();
LOG("Shutting down deadlock detector..."); LOGD("Shutting down deadlock detector...");
dd.Stop(); dd.Stop();
LOG("Stopping world threads..."); LOGD("Stopping world threads...");
StopWorlds(); StopWorlds();
LOG("Stopping authenticator..."); LOGD("Stopping authenticator...");
m_Authenticator.Stop(); m_Authenticator.Stop();
LOG("Freeing MonsterConfig..."); LOGD("Freeing MonsterConfig...");
delete m_MonsterConfig; m_MonsterConfig = NULL; delete m_MonsterConfig; m_MonsterConfig = NULL;
LOG("Stopping WebAdmin..."); LOGD("Stopping WebAdmin...");
delete m_WebAdmin; m_WebAdmin = NULL; delete m_WebAdmin; m_WebAdmin = NULL;
LOG("Unloading recipes..."); LOGD("Unloading recipes...");
delete m_FurnaceRecipe; m_FurnaceRecipe = NULL; delete m_FurnaceRecipe; m_FurnaceRecipe = NULL;
delete m_CraftingRecipes; m_CraftingRecipes = NULL; delete m_CraftingRecipes; m_CraftingRecipes = NULL;
LOG("Forgetting groups..."); LOGD("Forgetting groups...");
delete m_GroupManager; m_GroupManager = 0; delete m_GroupManager; m_GroupManager = 0;
LOG("Unloading worlds..."); LOGD("Unloading worlds...");
UnloadWorlds(); UnloadWorlds();
LOG("Stopping plugin manager..."); LOGD("Stopping plugin manager...");
delete m_PluginManager; m_PluginManager = NULL; delete m_PluginManager; m_PluginManager = NULL;
cItemHandler::Deinit(); cItemHandler::Deinit();
cBlockHandler::Deinit(); cBlockHandler::Deinit();
LOG("Destroying server..."); LOG("Cleaning up...");
//delete HeartBeat; HeartBeat = 0; //delete HeartBeat; HeartBeat = 0;
delete m_Server; m_Server = 0; delete m_Server; m_Server = 0;
LOG("Shutdown done."); LOG("Shutdown successful!");
} }
delete m_Log; m_Log = 0; delete m_Log; m_Log = 0;

7
source/Server.cpp
View File

@ -206,9 +206,8 @@ bool cServer::InitServer(cIniFile & a_SettingsIni)
return false; return false;
} }
LOG("Starting up server."); LOGD("Compatible clients: %s", MCS_CLIENT_VERSIONS);
LOGINFO("Compatible clients: %s", MCS_CLIENT_VERSIONS); LOGD("Compatible protocol versions %s", MCS_PROTOCOL_VERSIONS);
LOGINFO("Compatible protocol versions %s", MCS_PROTOCOL_VERSIONS);
if (cSocket::WSAStartup() != 0) // Only does anything on Windows, but whatever if (cSocket::WSAStartup() != 0) // Only does anything on Windows, but whatever
{ {
@ -292,7 +291,7 @@ void cServer::PrepareKeys(void)
// TODO: Save and load key for persistence across sessions // TODO: Save and load key for persistence across sessions
// But generating the key takes only a moment, do we even need that? // But generating the key takes only a moment, do we even need that?
LOG("Generating protocol encryption keypair..."); LOGD("Generating protocol encryption keypair...");
time_t CurTime = time(NULL); time_t CurTime = time(NULL);
CryptoPP::RandomPool rng; CryptoPP::RandomPool rng;

2
source/WebAdmin.cpp
View File

@ -286,7 +286,7 @@ bool cWebAdmin::Init(int a_Port)
} }
LOG("Starting WebAdmin on port %i", m_Port); LOGD("Starting WebAdmin on port %i", m_Port);
#ifdef _WIN32 #ifdef _WIN32
HANDLE hThread = CreateThread( HANDLE hThread = CreateThread(