flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

Check for nil in cWorld:SpawnSplitExperienceOrbs binding (#4354)

Browse Source 
Adds explicit nil check for 'position' parameter to prevent crashes if invalid.

Fixes #4352
This commit is contained in:
Mark Asp 2019-07-28 08:09:51 -05:00 committed by peterbell10
parent 9dc1343bda
commit c00b365617
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Bindings/ManualBindings_World.cpp
View File

@ -890,7 +890,7 @@ static int tolua_cWorld_SpawnSplitExperienceOrbs(lua_State* tolua_S)
}
cWorld * self = nullptr;
Vector3d * Position;
Vector3d * Position = nullptr;
int Reward;
L.GetStackValues(1, self, Position, Reward);
if (self == nullptr)
@ -898,6 +898,11 @@ static int tolua_cWorld_SpawnSplitExperienceOrbs(lua_State* tolua_S)
tolua_error(tolua_S, "Invalid 'self' in function 'SpawnSplitExperienceOrbs'", nullptr);
return 0;
}
if (Position == nullptr)
{
tolua_error(tolua_S, "Error in function 'SpawnSplitExperienceOrbs' arg #2. Value must not be nil.", nullptr);
return 0;
}
// Execute and push result:
L.Push(self->SpawnExperienceOrb(Position->x, Position->y, Position->z, Reward));