existing the Solaris base, and similarly to what happened with NSPR, made
a bad assumption on undefined behavior. This broke locking in various
places in Java, for example, causing the the debugging support to be
totally broken. It is worth someone who knows the Java codebase taking
a look to see what other things could have been broken by this on
FreeBSD 5.x+.
The assumption is that pthread_mutex_trylock(3) on a default-type
mutex will fail with EBUSY. This assumption is wrong for our
libpthread, which returns EDEADLK if the owner thread is trying to
acquire the mutex again with trylock. The behavior of performing a
locking operation on a self-locked default-type mutex is explicitly
undefined for pthread_mutex_lock(3).
The POSIX specification is still not very clear. It defines
pthread_mutex_trylock(3) in terms of pthread_mutex_lock(3) yet
does not say what the defined behavior should be for a self-locked
pthread_mutex_trylock(3) for any of the various mutex types, so it is
ambiguous whether the result is clearly undefined or clearly to return
EBUSY.
It is a one line change whether or not to make libpthread return
EDEADLK in this case, where it seems that most implementations do not.
Reference: http://www.opengroup.org/onlinepubs/009695399/functions/pthread_mutex_lock.html
in the DOCSDIR.
- Rename the start script from antivir-milter.sh to avmilter.sh to be
consistent with naming of the rest of the installed AntiVir Milter
files and directories.
- Now that AntiVir Milter supports using a different location from
/etc for the ignore, scan and warn config files no longer install
them in the EXAMPLESDIR but in PREFIX/etc/avmilter (i.e. install
as sample files, copy over when not already existent, etc.).
- Change the location of the AntiVir Milter config file (avmilter.conf)
but not that of the scan engine (antivir.conf; shared between different
AntiVir products) from PREFIX/etc to PREFIX/etc/avmilter in order to
have all AntiVir Milter config files in one place but don't directly
populate PREFIX/etc with them.
If you had previously changed PREFIX/etc/avmilter.conf you have to
bring over your changes to PREFIX/etc/avmilter/avmilter.conf but note
that some variables have been renamed. If you used ignore, scan and/or
warn files in /etc you can now move them to PREFIX/etc/avmilter.
Approved by: netchild
