mirror of
https://github.com/profanity-im/profanity.git
synced 2024-10-27 20:30:13 -04:00
23fa4750ff
## Summary Partial fix for https://github.com/profanity-im/profanity/issues/1939 > When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded. Download a file twice with `/url save`, the second download will not print download progress to the window. The cause is `HTTPDownload`'s `silent` variable is not initialized; so, `silent` points to a second-hand stack memory address with old data. `silent` references data, so the `if` statement will fail in **src/tools/http_download.c:206** and download progress will not print to the window. The fix is to initialize `silent` in both encrypted and unencrypted file download scenarios. ## Testing Valgrind: Yes - `/url save` without OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/url save` with OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py` **SUCCESS**: Try once and download progress is hidden.
193 lines
6.7 KiB
C
193 lines
6.7 KiB
C
/*
|
|
* aesgcm_download.c
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
|
|
* Copyright (C) 2020 William Wennerström <william@wstrm.dev>
|
|
*
|
|
* This file is part of Profanity.
|
|
*
|
|
* Profanity is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Profanity is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Profanity. If not, see <https://www.gnu.org/licenses/>.
|
|
*
|
|
* In addition, as a special exception, the copyright holders give permission to
|
|
* link the code of portions of this program with the OpenSSL library under
|
|
* certain conditions as described in each individual source file, and
|
|
* distribute linked combinations including the two.
|
|
*
|
|
* You must obey the GNU General Public License in all respects for all of the
|
|
* code used other than OpenSSL. If you modify file(s) with this exception, you
|
|
* may extend this exception to your version of the file(s), but you are not
|
|
* obligated to do so. If you do not wish to do so, delete this exception
|
|
* statement from your version. If you delete this exception statement from all
|
|
* source files in the program, then also delete it here.
|
|
*
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <curl/curl.h>
|
|
#include <gio/gio.h>
|
|
#include <pthread.h>
|
|
#include <assert.h>
|
|
#include <errno.h>
|
|
|
|
#include "profanity.h"
|
|
#include "event/client_events.h"
|
|
#include "tools/http_common.h"
|
|
#include "tools/aesgcm_download.h"
|
|
#include "omemo/omemo.h"
|
|
#include "config/preferences.h"
|
|
#include "ui/ui.h"
|
|
#include "ui/window.h"
|
|
#include "common.h"
|
|
|
|
#define FALLBACK_MSG ""
|
|
|
|
void*
|
|
aesgcm_file_get(void* userdata)
|
|
{
|
|
AESGCMDownload* aesgcm_dl = (AESGCMDownload*)userdata;
|
|
|
|
char* https_url = NULL;
|
|
char* fragment = NULL;
|
|
|
|
// Convert the aesgcm:// URL to a https:// URL and extract the encoded key
|
|
// and tag stored in the URL fragment.
|
|
if (omemo_parse_aesgcm_url(aesgcm_dl->url, &https_url, &fragment) != 0) {
|
|
cons_show_error("Download failed: Cannot parse URL '%s'.", aesgcm_dl->url);
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Download failed: Cannot parse URL '%s'.",
|
|
aesgcm_dl->url);
|
|
return NULL;
|
|
}
|
|
|
|
// Create a temporary file used for storing the ciphertext that is to be
|
|
// retrieved from the https:// URL.
|
|
gchar* tmpname = NULL;
|
|
gint tmpfd;
|
|
if ((tmpfd = g_file_open_tmp("profanity.XXXXXX", &tmpname, NULL)) == -1) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Downloading '%s' failed: Unable to create "
|
|
"temporary ciphertext file for writing "
|
|
"(%s).",
|
|
https_url, g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
// Open the target file for storing the cleartext.
|
|
FILE* outfh = fopen(aesgcm_dl->filename, "wb");
|
|
if (outfh == NULL) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Downloading '%s' failed: Unable to open "
|
|
"output file at '%s' for writing (%s).",
|
|
https_url, aesgcm_dl->filename,
|
|
g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
// We wrap the HTTPDownload tool and use it for retrieving the ciphertext
|
|
// and storing it in the temporary file previously opened.
|
|
HTTPDownload* http_dl = malloc(sizeof(HTTPDownload));
|
|
http_dl->window = aesgcm_dl->window;
|
|
http_dl->worker = aesgcm_dl->worker;
|
|
http_dl->id = strdup(aesgcm_dl->id);
|
|
http_dl->url = strdup(https_url);
|
|
http_dl->filename = strdup(tmpname);
|
|
http_dl->cmd_template = NULL;
|
|
http_dl->silent = FALSE;
|
|
aesgcm_dl->http_dl = http_dl;
|
|
|
|
http_file_get(http_dl); // TODO(wstrm): Verify result.
|
|
|
|
FILE* tmpfh = fopen(tmpname, "rb");
|
|
if (tmpfh == NULL) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Downloading '%s' failed: Unable to open "
|
|
"temporary file at '%s' for reading (%s).",
|
|
aesgcm_dl->url, tmpname,
|
|
g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
gcry_error_t crypt_res;
|
|
crypt_res = omemo_decrypt_file(tmpfh, outfh,
|
|
http_dl->bytes_received, fragment);
|
|
|
|
if (fclose(tmpfh) == EOF) {
|
|
cons_show_error(g_strerror(errno));
|
|
}
|
|
|
|
close(tmpfd);
|
|
remove(tmpname);
|
|
g_free(tmpname);
|
|
|
|
if (crypt_res != GPG_ERR_NO_ERROR) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Downloading '%s' failed: Failed to decrypt "
|
|
"file (%s).",
|
|
https_url, gcry_strerror(crypt_res));
|
|
}
|
|
|
|
if (fclose(outfh) == EOF) {
|
|
cons_show_error(g_strerror(errno));
|
|
}
|
|
|
|
free(https_url);
|
|
free(fragment);
|
|
|
|
if (aesgcm_dl->cmd_template != NULL) {
|
|
gchar** argv = format_call_external_argv(aesgcm_dl->cmd_template,
|
|
aesgcm_dl->filename,
|
|
aesgcm_dl->filename);
|
|
|
|
// TODO: Log the error.
|
|
if (!call_external(argv)) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id,
|
|
"Downloading '%s' failed: Unable to call "
|
|
"command '%s' with file at '%s' (%s).",
|
|
aesgcm_dl->url,
|
|
aesgcm_dl->cmd_template,
|
|
aesgcm_dl->filename,
|
|
"TODO: Log the error");
|
|
}
|
|
|
|
g_strfreev(argv);
|
|
free(aesgcm_dl->cmd_template);
|
|
}
|
|
|
|
free(aesgcm_dl->id);
|
|
free(aesgcm_dl->filename);
|
|
free(aesgcm_dl->url);
|
|
free(aesgcm_dl);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
void
|
|
aesgcm_download_cancel_processes(ProfWin* window)
|
|
{
|
|
http_download_cancel_processes(window);
|
|
}
|
|
|
|
void
|
|
aesgcm_download_add_download(AESGCMDownload* aesgcm_dl)
|
|
{
|
|
http_download_add_download(aesgcm_dl->http_dl);
|
|
}
|