1
1
mirror of https://github.com/profanity-im/profanity.git synced 2025-02-02 15:08:15 -05:00
ike08 23fa4750ff Fix unable to download item twice
## Summary

Partial fix for https://github.com/profanity-im/profanity/issues/1939  

> When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded.  

Download a file twice with `/url save`, the second download will not print download progress to the window.  

The cause is `HTTPDownload`'s `silent` variable is not initialized; so, `silent` points to a second-hand stack memory address with old data. `silent` references data, so the `if` statement will fail in **src/tools/http_download.c:206** and download progress will not print to the window.  

The fix is to initialize `silent` in both encrypted and unencrypted file download scenarios.  

## Testing

Valgrind: Yes  

- `/url save` without OMEMO  
  **SUCCESS**: Try three times with the same URL and download status will display every time.  

- `/url save` with OMEMO  
  **SUCCESS**: Try three times with the same URL and download status will display every time.  

- `/plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py`  
  **SUCCESS**: Try once and download progress is hidden.
2024-02-28 07:23:59 -07:00
2021-12-24 13:49:07 +01:00
2016-03-09 12:55:57 +01:00
2024-02-28 07:23:59 -07:00
2024-02-19 17:41:06 +01:00
2022-02-01 15:01:28 +01:00
2023-10-04 17:02:10 +02:00
2023-10-14 18:07:52 +02:00
2023-08-03 08:06:19 +02:00
2021-08-26 00:30:55 +00:00
2022-08-18 15:03:38 +02:00
2022-08-18 15:02:36 +02:00
2019-04-24 01:08:38 +02:00
2024-02-19 17:41:06 +01:00
2023-12-12 18:27:11 +01:00
2023-08-23 10:49:57 +02:00
2023-08-25 20:11:26 +02:00
2023-03-10 11:20:59 +01:00
2020-05-21 09:16:18 +02:00

Profanity

Build Status GitHub contributors Packaging status

Profanity is a console based XMPP client inspired by Irssi.

If you like Profanity consider becoming a sponsor or donate some money.

alt tag

See the User Guide for information on installing and using Profanity.

Project

This project is about freedom, privacy and choice. We want to enable people to chat with one another in a safe way. Thus supporting encryption (OTR, PGP, OMEMO, OX) and being decentralized, meaning everyone can run their own server. We believe XMPP is a great proven protocol with an excellent community serving this purpose well.

Feel free to follow us on twitter, join our mailing list and/or MUC.

Installation

Our user guide contains an install section and a section for building from source yourself.

Donations

We would highly appreciate it if you support us via GitHub Sponsors. Especially if you make feature requests or need help using Profanity. Sponsoring enables us to spend time on Profanity.

An alternative way to support us would be to ask for our IBAN or use Bitcoin: bc1qx265eat7hfasqkqmk9qf38delydnrnuvzhzy0x.

Issues backed by a sponsor will be tagged with the sponsored label. Feature requests that we consider out of scope, either because of interest or because of time needed to implement them, will be marked with the unfunded label.

Another way to sponsor us or get an issue solved is to comment on an issue that you are willing to sponsor it.

Tasks from our sponsors will be tackled first.

Thank you! <3

How to contribute

We tried to sum things up on our helpout page. Additionally you can check out our blog where we have articles like: How to get a backtrace and Contributing a Patch via GitHub. For more technical details check out our CONTRIBUTING.md file.

Getting help

To get help, first read our User Guide then check out the FAQ. If you have are having a problem then first search the issue tracker. If you don't find anything there either come to our MUC or create a new issue depending on what your problem is.

Website

URL: https://profanity-im.github.io

Repo: https://github.com/profanity-im/profanity-im.github.io

Blog

URL: https://profanity-im.github.io/blog

Repo: https://github.com/profanity-im/blog

Mailinglist

Mailing List: https://lists.posteo.de/listinfo/profanity

Chatroom

MUC: profanity@rooms.dismail.de

Plugins

Plugins repository: https://github.com/profanity-im/profanity-plugins

Description
No description provided
Readme 24 MiB
Languages
C 97.4%
Python 1.4%
Makefile 0.6%
M4 0.5%
Shell 0.1%