Michael Vetter
558d672733
Merge pull request #1515 from mwuttke97/fix_omemo_empty_devlist
...
[OMEMO] Fix sending messages
2021-04-08 10:20:42 +02:00
Maximilian Wuttke
025c2fb1e0
Msg sending: don't write to chatwin nor to log if sending failed
...
Currently, only `chat_log_omemo_msg_out` can fail (i.e. return `NULL`
instead of a stanza id). In this case, the message is neither printed to
the chat window nor added to the log (since it wasn't sent).
2021-04-08 00:30:03 +02:00
Maximilian Wuttke
e8664e2730
OMEMO: Fail if message keys couldn't be encrypted for any recipient device
...
If the message (key) can't be encrypted for any device, sending the
message is refused and an informative error message is presented to the
user.
Also, don't encrypt for the same device, since the OMEMO XEP disallows
this.
2021-04-08 00:29:58 +02:00
Maximilian Wuttke
9e0d0ed466
OMEMO: Remove duplicate session initalisation
...
The function `omemo_start_session` was effectively called twice in the
`/msg` command: Once in `chatwin_new` and afterwards in `cmd_msg`. I've
removed the second call.
2021-04-08 00:23:07 +02:00
Michael Vetter
1ec606540e
Get rid of asprintf and _GNU_SOURCE define
...
_GNU_SOURCE was even in some files where it was not needed at all
(http*).
Let's replace asprintf() with g_strdup_printf().
2021-03-30 17:38:13 +02:00
Michael Vetter
3c1e4bac3a
Fix segfault in cmd_autoaway()
...
Two mistakes were here:
* `/autoaway time away` without a time argument segfaulted
* `/autoaway message away` without a mesage set to (null). We have
`/autoaway message off to set it off.
Also use g_strcmp0() instead of strcmp().
2021-03-29 10:48:42 +02:00
Michael Vetter
a09d49d884
Merge pull request #1514 from profanity-im/fix/1512-rpi
...
Include config.h in omemo files
2021-03-26 20:07:18 +01:00
Michael Vetter
057c9ad776
Add config.h in files were it was missing
...
Related to https://github.com/profanity-im/profanity/issues/1512
2021-03-26 19:54:22 +01:00
Michael Vetter
eaf76555bd
Include config.h in omemo files
...
So that off_t is defined in all files (so far http_upload.c and
http_download.c too) the same way.
Fix https://github.com/profanity-im/profanity/issues/1512
Thanks @pasis for finding the solution!
2021-03-26 19:54:04 +01:00
Michael Vetter
acda845b2a
iq: use define for 'cancel'
2021-03-26 10:05:24 +01:00
Michael Vetter
3884a4d35b
message: parse stanzaid in MUC case
...
There was a todo for this in message.c which got forgotten.
This was most likely also the reason why there were NULL entries for
this in the DB which DebXWoody mentioned in the MUC.
Thus comparison was with NULL and no new entries were added to the
database.
Edit:
After checking pull requests I see Stefans draft PR:
https://github.com/profanity-im/profanity/pull/1505
So let's add him as co-author.
Co-authored-by: Stefan Kropp <stefan@debxwoody.de>
2021-03-25 17:09:52 +01:00
Michael Vetter
c72351375d
Merge pull request #1513 from profanity-im/fix-possible-segfault1
...
Fix potential problems caused by unexpected stanzas
2021-03-25 17:04:22 +01:00
Michael Vetter
a1a37cf9bf
ox: fix memleak in ox_announce_public_key
2021-03-25 17:02:59 +01:00
Michael Vetter
8df5e99981
message: make _handle_error safer
2021-03-25 16:50:10 +01:00
Michael Vetter
3a6bce5a09
event: make log_database_get_previous_chat safer
2021-03-25 16:47:35 +01:00
Michael Vetter
901f9d3d8c
database: make log_database_get_previous_chat safer
2021-03-25 16:46:18 +01:00
Michael Vetter
e93d4ff331
database: simplify _log_database_add_outgoing
2021-03-25 16:45:30 +01:00
Michael Vetter
c0e339130e
database: simplify log_database_add_incoming
2021-03-25 16:44:36 +01:00
Michael Vetter
e09f3fb615
avatar: make _avatar_request_item_result_handler safer
2021-03-25 16:35:43 +01:00
Michael Vetter
44343a5c37
avatar: make _avatar_metadata_handler safer
2021-03-25 16:34:20 +01:00
Michael Vetter
b584a1ecd0
ox: make _ox_public_key_result safer
2021-03-25 16:30:19 +01:00
Michael Vetter
10df93ee3e
ox: guard printing of fingerprint
2021-03-25 16:25:18 +01:00
Michael Vetter
fb81b80499
ox: improve error log in _ox_metadata_result
2021-03-25 16:24:07 +01:00
Michael Vetter
31a78e2629
ox: add logging prefix
2021-03-25 16:22:47 +01:00
Michael Vetter
f81ed759f5
stanza: guard mallocs
...
If this happens we have more serious problems :-)
But anyways..
2021-03-25 16:14:40 +01:00
Michael Vetter
d23c3dd065
stanza: simplify stanza_get_muc_destroy_alternative_room
2021-03-25 15:59:48 +01:00
Michael Vetter
caa2c7afd0
stanza: replae strcmp with g_strcmp0
...
since its NULL safe
2021-03-25 15:55:18 +01:00
Michael Vetter
1f96e14ce7
message: simplify _handle_headline
2021-03-25 15:43:57 +01:00
Michael Vetter
b2a02424ed
message: make _receipt_request_handler safer
2021-03-25 15:38:48 +01:00
Michael Vetter
099260a4e3
message: make _handle_receipt_received safer
2021-03-25 15:37:54 +01:00
Michael Vetter
2236242407
message: make _handle_groupchat safer
2021-03-25 15:36:17 +01:00
Michael Vetter
ca9c946ddc
message: simplify _handle_conference
2021-03-25 15:33:30 +01:00
Michael Vetter
2601fc5571
message: make _handle_form safer
2021-03-25 15:27:59 +01:00
Michael Vetter
b1bd1ecca8
message: make _message_handler safer
2021-03-25 15:26:16 +01:00
Michael Vetter
11382a8bf3
mesage: make _handle_ox_chat safer
...
And on the way fix a memleak
2021-03-25 15:20:53 +01:00
Michael Vetter
8a6d256fc1
message: make _handle_chat safer
2021-03-25 15:07:09 +01:00
Michael Vetter
ee87e5b036
message: make _handle_muc_private_message safer
2021-03-25 15:03:35 +01:00
Michael Vetter
d2dc440535
message: fix potential segfault in _receipt_request_handler
2021-03-25 11:56:38 +01:00
Michael Vetter
e396e863dd
message: safeguard _handle_receipt_received
...
This shouldnt be necessary since we check for the receipt outside
alreayd. Let's be on the safe side though in case code gets changed
later.
2021-03-25 11:54:59 +01:00
Michael Vetter
9cfe5ec787
message: reorder _handle_groupchat
2021-03-25 11:51:42 +01:00
Michael Vetter
96b228728e
message: fix possible segfault in _handle_conference
2021-03-25 11:43:42 +01:00
Michael Vetter
f21a99eaf8
message: fix possible segfault in _handle_muc_user
2021-03-25 11:38:22 +01:00
Michael Vetter
e656bdb83c
message: fix possible segfault in _message_handler
2021-03-25 11:34:14 +01:00
Michael Vetter
2ea08fd994
Merge pull request #1510 from profanity-im/fix/1210-muc-register
...
Register nickname with MUC
2021-03-25 11:20:10 +01:00
Michael Vetter
fde0a0d1c6
Add support to register with a room
...
`/affiliation register` can now be used to register a nickname with a
MUC.
Tested with a server without forms. Couldn't find a server which
supports forms yet.
Implements https://github.com/profanity-im/profanity/issues/1210
2021-03-25 11:05:58 +01:00
Michael Vetter
064174efa3
debug build: build without -fsanitize=address
...
Sorry :-)
Seems then we can't use valgrind since that does its own ASAN things.
So maybe developers needs to set some flags by themselves to find these
memory issues.
https://fuzzing-project.org/tutorial-cflags.html might be of help.
Regards: https://github.com/profanity-im/profanity/issues/1512
2021-03-24 17:20:54 +01:00
Michael Vetter
5f7840bc3f
debug build: build with -fsanitize=address
...
Let's compile with this flag to detect memory erros in the debug build.
See https://clang.llvm.org/docs/AddressSanitizer.html
Regards: https://github.com/profanity-im/profanity/issues/1512
2021-03-24 17:08:19 +01:00
Michael Vetter
18172f5260
Merge pull request #1511 from mwuttke97/doc_bookmark_join
...
Command doc: Improve description and examples of `/bookmark` and `/join`
2021-03-24 14:31:22 +01:00
Maximilian Wuttke
b8f3e8e0ac
Command doc: Improve description and examples of /bookmark and /join
2021-03-21 10:59:06 +01:00
Michael Vetter
051e31ffc0
Merge pull request #1508 from profanity-im/fix/1507-voice-accept
...
Support to approve MUC voice requests
2021-03-17 16:36:44 +01:00
