1
0
mirror of https://github.com/irssi/irssi.git synced 2024-12-04 14:46:39 -05:00
Commit Graph

4757 Commits

Author SHA1 Message Date
Will Storey
7e6d24420c Remove resolve_reverse_lookup setting
This setting seems ill advised and breaks TLS verification.

Fixes #1034.
2019-10-12 17:09:48 -07:00
Will Storey
f9db4019af Remove else since prior condition returns 2019-10-12 17:03:40 -07:00
Will Storey
34effcec01 Fill more connection information in one spot 2019-10-12 15:46:42 -07:00
Will Storey
1639425217 Do not copy TLS settings to reconnection record
This was causing us to use the TLS settings from one server on another
which is not always appropriate. Instead, we now treat it like other
connection information and do not copy it. We get the TLS settings later
as appropriate when connecting.

Note there is still probably more that could be cleaned up here. For
example, the unix socket might be better treated as connection info too.

Fixes #1027.
2019-10-12 15:46:42 -07:00
Will Storey
4476fbbad9 Fix indentation 2019-10-12 15:46:39 -07:00
ailin-nemui
145d1040ac add ignore check, emphasis and fix a memory leak 2019-10-11 22:37:09 +02:00
Will Storey
e4d34380e5 Mark unused function deprecated 2019-10-05 14:32:35 -07:00
Will Storey
2af7db2dfa Remove unused function 2019-10-05 14:32:35 -07:00
ailin-nemui
a68be4dcca missing free 2019-10-05 23:30:25 +02:00
ailin-nemui
03eb8d032a fix the fix 2019-10-01 11:09:25 +02:00
Dan Collins
7e694fd223 Fix hilight behavior for STATUSMSG
This patch allows irc_op_public messages to properly trigger
hilights when the message mentions the current nick or one of our
hilights. This is done by copying the required code from
sig_message_public. This is important because Freenode has begun
using this message type for messages that can only be seen by ops
due to the +z channel mode, and ops will want to be notified of
watchwords even in that type of message.

To test, make two connections to Freenode, join a new channel. The
first client to join that channel will be an op. To establish a
baseline, use the non-opped client to attempt to "ping" the opped
client by addressing it by name and using terms in /hilight. Then,
set channel mode to +mz and use the non-opped client to send the
messages again. Without this patch, no message will "ping" the opped
client with +mz set. With this patch, "pings" should operate
normally, causing a bell, hilighting the window number, and so on.

What I don't know is whether there is any other code from
sig_message_public that should be copied over too. In particular,
the lines related to "ignore_check_plus", "emphasis", and
"printnick", I don't know if they are needed here. I also don't know
if there are any other message types that these changes should be
    applied to.
2019-09-28 20:00:06 -04:00
Joseph Bisch
ed65499d76 Add missing g_string_free param 2019-09-26 21:51:36 -04:00
Joseph Bisch
f6cca3de4e Properly free sasl_buffer GString 2019-09-24 21:35:40 -04:00
ailin-nemui
8a1a96c12c
Merge pull request #1120 from ailin-nemui/invalid-cap-free
free params
2019-09-16 11:42:48 +02:00
ailin-nemui
9ff224d05d silence glib log output during fuzzing on oss-fuzz 2019-09-10 13:08:35 +02:00
ailin-nemui
96562e460b
Merge pull request #1124 from ailin-nemui/extended-join
fix crash in join due to incorrect free
2019-09-05 18:19:03 +02:00
ailin-nemui
69dec1de33 add new meson build option -Dfuzzer-link-language=cpp for oss-fuzz 2019-09-04 22:48:03 +02:00
ailin-nemui
f875d252d2 fix crash in join due to incorrect free 2019-09-04 14:57:56 +02:00
ailin-nemui
6d58052c4a enable self-message support 2019-09-04 14:27:06 +02:00
ailin-nemui
948e7bb317 free params 2019-08-30 22:14:26 +02:00
ailin-nemui
c271609a49 add some dummy objects to server-fuzz 2019-08-30 22:11:27 +02:00
ailin-nemui
1e9cd62aac
Merge pull request #1117 from ailin-nemui/theme-align
limit special-vars alignment memory to not exhaust fuzzer
2019-08-30 21:20:33 +02:00
ailin-nemui
887950db0f limit special-vars alignment memory to not exhaust fuzzer 2019-08-30 20:30:02 +02:00
ailin-nemui
3447904a5c fix warning in fe-fuzz/server-fuzz 2019-08-30 20:29:03 +02:00
ailin-nemui
401fff7c34 Merge branch 'fix-double-cap' into 'master'
fix use after free receiving caps

See merge request irssi/irssi!35
2019-08-29 17:31:27 +02:00
ailin-nemui
5a4e7ab659 fix use after free receiving caps
fixes GL#34
2019-08-27 23:34:03 +02:00
ailin-nemui
570d6714ec
Merge pull request #1114 from ailin-nemui/startup-crash
fix crash on startup when resizing before active_win
2019-08-27 15:12:04 +02:00
ailin-nemui
44b060ce17 fix crash on startup when resizing before active_win 2019-08-27 12:42:20 +02:00
ailin-nemui
447e357e07
Merge pull request #1107 from ailin-nemui/extended-join
make extended account info visible and formattable
2019-08-26 23:02:20 +02:00
ailin-nemui
3f0afa91f3
Merge pull request #1092 from ailin-nemui/outgoing-tags
sending of tag messages and customisable maximum irc message length
2019-08-26 22:01:53 +02:00
ailin-nemui
487d9434bd revert the change to perl-common that would stop it from creating ghost chatnets
see 00a7efc69f
2019-08-23 22:26:27 +02:00
ailin-nemui
54781a34ee
Merge pull request #1101 from ailin-nemui/auto
fix autotools build
2019-08-19 15:35:33 +02:00
ailin-nemui
38df7bfd29 make extended account info visible and formattable 2019-08-18 11:24:48 +02:00
ailin-nemui
504d50c9a3 up abi 2019-08-16 22:40:49 +02:00
ailin-nemui
d5329bc811 fix crashes when nick is missing 2019-08-16 21:37:53 +02:00
ailin-nemui
255d850c4d fix crash in setname 2019-08-16 21:19:40 +02:00
ailin-nemui
b6f1bf8fcd fix autotools build 2019-08-15 21:44:33 +02:00
ailin-nemui
e20900a7ca make a setting to disable account-notify 2019-08-15 17:30:38 +02:00
ailin-nemui
44d480ca99 use account-notify capability 2019-08-15 17:30:38 +02:00
ailin-nemui
8f65f58a4a improve message wording 2019-08-15 17:26:20 +02:00
ailin-nemui
4dbbbf47a4 add chghost capability support 2019-08-15 17:26:20 +02:00
ailin-nemui
5f13614d47 move away message to fe-common/core 2019-08-15 16:43:19 +02:00
ailin-nemui
61d215acdd support cap away-notify 2019-08-15 16:43:17 +02:00
ailin-nemui
6c37099407 more variables 2019-08-15 16:39:26 +02:00
ailin-nemui
200020da93 use better number parsing 2019-08-15 16:33:50 +02:00
ailin-nemui
da9adec47f sending of tag messages and customisable maximum irc message length 2019-08-15 16:33:50 +02:00
ailin-nemui
d418989f0c
Merge pull request #1090 from ailin-nemui/incoming-tags
incoming irc message tags support
2019-08-15 16:32:01 +02:00
ailin-nemui
506f2fb327
Merge pull request #1094 from ailin-nemui/cap-invite-notify
show invites of other users when provided
2019-08-15 16:31:29 +02:00
ailin-nemui
0f361d2673 refactor quit message into a separate function 2019-08-15 16:01:48 +02:00
ailin-nemui
2576064982 add missing signal_remove 2019-08-15 10:57:54 +02:00
ailin-nemui
eb3a44a713 clarifying comment 2019-08-15 10:56:15 +02:00
ailin-nemui
24154ced0d irc message tags support 2019-08-15 10:56:15 +02:00
ailin-nemui
e62e55c0ab show invites of other users when provided 2019-08-14 23:55:40 +02:00
ailin-nemui
47518b4b75 request the setname capability 2019-08-14 23:40:39 +02:00
ailin-nemui
6e32c1f638
Merge pull request #1097 from ailin-nemui/cap-extended-joins
use extended-join capability
2019-08-14 21:08:11 +02:00
ailin-nemui
76bcd01da0 up abi 2019-08-14 21:07:27 +02:00
ailin-nemui
ebd17348a6
Merge pull request #1089 from ailin-nemui/refstrings
implement reference counted strings
2019-08-14 20:53:13 +02:00
ailin-nemui
ad7ad063ca implement reference counted strings
- on glib >=2.58, use the implementation provided by glib
- otherwise, a hash table will contain the strings
2019-08-14 20:50:44 +02:00
ailin-nemui
0a12bf682d
Merge pull request #1095 from ailin-nemui/cap-queue
fix cap queue order
2019-08-14 17:58:52 +02:00
ailin-nemui
4ae1dbbd00 fix cap queue order 2019-08-14 16:34:18 +02:00
ailin-nemui
2f82d9cd33
Merge pull request #1088 from ailin-nemui/noformat
add a new "print noformat" signal to be emitted on printtext
2019-08-14 14:24:08 +02:00
ailin-nemui
25270e0465 use extended-join capability 2019-08-13 18:23:34 +02:00
ailin-nemui
ed4297c41b add a new "print noformat" signal to be emitted on printtext 2019-08-13 18:18:00 +02:00
ailin-nemui
27546354ca increase disconnect buffer and get rid of some magic 510 values 2019-08-13 18:17:35 +02:00
ailin-nemui
fa0ecb688d
Merge pull request #1087 from ailin-nemui/time-expando-override
make the $Z time overridable
2019-08-13 18:07:47 +02:00
ailin-nemui
d512647b3f use symbolic defines for capability strings 2019-08-13 17:36:20 +02:00
ailin-nemui
e0ff13f6c1 enable irc cap ls 302 2019-08-13 17:26:51 +02:00
ailin-nemui
a865b07a67 make the $Z time overridable 2019-08-13 16:59:07 +02:00
ailin-nemui
d7fcb846d3
Merge pull request #1078 from ailin-nemui/theme-indent-always
fix cut off text with theme-indent and /set indent_always off
2019-08-04 22:16:55 +02:00
ailin-nemui
f612f2ee51
Merge pull request #1077 from l2dy/memory-leak
Fix memory leaks
2019-07-28 01:26:57 +02:00
ailin-nemui
c92ff1701f fix cut off text with theme-indent and /set indent_always off 2019-07-28 00:55:19 +02:00
Zero King
dde5fff4a5 Fix memory leaks 2019-07-27 18:34:03 +00:00
Zero King
6c7fa15417 Free g_strdup() allocated memory with g_free()
Memory allocated with g_malloc() must be freed with g_free(). The
allocators may use different memory pools.
2019-07-27 18:23:51 +00:00
ailin-nemui
05d50ffa1b
Merge pull request #1075 from ailin-nemui/meson049
do not use ?: to stay compatible with meson 0.49
2019-07-21 00:21:39 +02:00
ailin-nemui
9a90213ba9 do not use ?: to stay compatible with meson 0.49 2019-07-21 00:08:36 +02:00
ailin-nemui
6277ccf67f manually maintain irc loader 2019-07-18 18:04:42 +02:00
ailin-nemui
aa9bb36a0d
Merge pull request #1067 from ailin-nemui/irc-module
modularise irc component
2019-07-18 10:56:40 +02:00
Ailin Nemui
99b2c0b04a fix small overflow 2019-07-18 10:29:30 +02:00
Ailin Nemui
00a7efc69f modularise irc component 2019-07-17 13:37:19 +02:00
Ailin Nemui
db16a0a853 meson build support 2019-07-10 09:25:26 +02:00
ailin-nemui
8551dd99cc
Merge pull request #1057 from ailin-nemui/entry-8bit
restore 8bit support in input entry
2019-06-28 11:29:19 +02:00
ailin-nemui
d23b0d22cc
Merge pull request #1058 from ailin-nemui/sasl-reconnect
copy sasl username and password values
2019-06-28 11:28:30 +02:00
ailin-nemui
8d11060fbc Use the 24bit mIRC colour mappings if colors_ansi_24bit is enabled 2019-06-18 14:55:47 +02:00
ailin-nemui
5a67b983dc copy sasl username and password values 2019-06-17 15:22:27 +02:00
ailin-nemui
38b6284535 restore 8bit support in input entry 2019-06-17 14:58:34 +02:00
ailin-nemui
0ffc515264
Merge pull request #1048 from vague666/set_list_section
Make it possible to list specific section with /set
2019-06-10 12:33:28 +02:00
Doug Freed
1d6aeb08fd fe-text/mainwindows: fix /window balance warning
mainwindow_resize() expects that the mainwindow's height has not yet
been updated, as it updates it itself, and throws a warning otherwise.
2019-06-09 23:10:05 +00:00
vague666
cd5958079c Make it possible to list specific section with /set
update help

Allow partial matching
2019-05-29 13:09:28 +02:00
David Gall
38a81026b9
Syntax Issue
"was is" changed to "was" for otr_msg_not_in_private
2019-05-26 18:59:21 +02:00
ailin-nemui
7e7bc98396
Merge pull request #1020 from teschi/allow_rawlog_lines_to_shrink_again
allow rawlog-buffer to shrink again after lowering "rawlog_lines"
2019-05-23 10:39:45 +02:00
vague666
78ae00910e Make MSGLEVEL_HIDDEN accessible from scripts
Empty line in wrong place

Expose MSGLEVEL_HIDDEN to scripts
2019-05-15 15:12:05 +02:00
ailin-nemui
7654f30d04
Merge pull request #1043 from ailin-nemui/solaris10
fix realpath on old solaris
2019-05-13 15:26:21 +02:00
ailin-nemui
9e13892e28 fix realpath on old solaris
POSIX.1-2001 did not implement realpath(..., NULL) yet.
Fixes #1042
2019-05-13 15:15:46 +02:00
ailin-nemui
20f7792748
Merge pull request #1023 from vague666/update_cmd_cat
Add -out parameter to /CAT
2019-05-13 14:27:49 +02:00
vague666
d45993dba4 Add -out parameter to /CAT
Change flag to -window

Updated help

Typo

call printtext with server

Only use server when target is not NULL
2019-05-09 13:19:48 +02:00
ailin-nemui
4a3a064d55 fix reconnect of multiplexed proxy 2019-05-07 13:37:31 +02:00
ailin-nemui
37f7c7f374 update include guard names 2019-05-01 22:22:22 +02:00
ailin-nemui
03ca37c12e Use full paths to includes in fe-fuzz 2019-05-01 22:08:45 +02:00
ailin-nemui
7e6e1f2e10 Use full paths to includes 2019-05-01 22:08:45 +02:00
ailin-nemui
2db6e99038
Merge pull request #1036 from berkerpeksag/fix-bio-read
Check return value of BIO_read() in set_pubkey_info()
2019-04-24 13:51:06 +02:00
ailin-nemui
796b60dd45
Merge pull request #1025 from vague666/prefer_window_name
Add setting to choose between window name and visible name in actlist
2019-04-15 10:52:52 +02:00
vague666
9d9d99eeb1 move caching to correct place :) 2019-04-08 12:32:58 +02:00
Berker Peksag
530393140a Check return value of BIO_read() in set_pubkey_info()
Fixes #943
2019-04-08 02:40:45 +03:00
ailin-nemui
04ca271d77
Merge pull request #1035 from berkerpeksag/patch-1
Add missing NULL check in mask_match()
2019-04-07 15:30:34 +02:00
Berker Peksag
2b48ddd3c9 Move NULL check for cert above pubkey
This patch was originally proposed by Chi Li.

Fixes #944
2019-04-06 23:20:44 +03:00
Berker Peksag
8789027617
Add missing NULL check in mask_match()
Fixes #902
2019-04-06 21:52:49 +03:00
ailin-nemui
690e441771
Merge pull request #1026 from vague666/perl_hidden_view_access
add access to set hidden_level from perl
2019-04-05 16:02:41 +02:00
ailin-nemui
a2f2d1899b
Merge pull request #1022 from heikkiorsila/scrollback_max_age
Implement a method to delete messages older than given time in scroll…
2019-04-05 15:58:36 +02:00
ailin-nemui
791071f6e4
Merge pull request #1024 from vague666/update_cmd_echo
Remove unused parameter to /ECHO
2019-04-05 15:58:22 +02:00
vague666
c66fe616e1 Bump ABI and add another perl api function 2019-04-02 09:53:42 +02:00
vague666
9cdeed2894 cache bool value 2019-04-02 09:39:03 +02:00
Jacob V Rasmussen
d0bc5b8cf2 Update ssl_* to tls_* in syntax. 2019-04-01 17:52:39 +02:00
vague666
40d800637a add access to set hidden_level from perl 2019-03-22 19:24:18 +01:00
vague666
22502abf2c Add setting to choose between window name and visible name in actlist 2019-03-22 19:10:10 +01:00
vague666
8479ff7a2e Remove unused parameter to /ECHO 2019-03-22 13:11:35 +01:00
Heikki Orsila
6a2823ad3e Implement a method to delete messages older than given time in scrollback history.
The maximum age of messages is controlled by /set scrollback_max_age variable.
E.g. /set scrollback_max_age 7days
2019-03-13 22:59:24 +02:00
teschi
c61a171114 allow rawlog-buffer to shrink again after lowering "rawlog_lines" 2019-02-23 22:24:36 +01:00
Will Storey
c25d24220f Remove unused functions 2019-02-18 11:53:46 -08:00
Will Storey
2db359fbb3 Recognise non-zero as error rather than only -1
The error flag can be something other than -1 in the event of an error.
Not checking for this could lead to us to try connecting to an unknown
IP.
2019-02-18 11:44:31 -08:00
Will Storey
e793d7af9f Fix indentation 2019-02-18 11:44:28 -08:00
ailin-nemui
3664484bef do not stop autolog_ignore_targets from matching itemless targets 2019-02-12 13:28:05 +01:00
Ailin Nemui
8543b874a2 store type of window binds 2019-02-11 17:27:33 +01:00
Alexander Færøy
346211eeeb Use memcpy() instead of strncpy() to silence the compiler warning. 2019-02-09 22:42:13 +01:00
ailin-nemui
a25b4e5db2
Merge pull request #999 from ailin-nemui/mad-protocol
do not touch uninitialised protocols on item restore
2019-02-08 14:37:31 +01:00
ailin-nemui
034752ade3 fix gui_input_get_extent
it was causing a free of data with [transfer=none]
2019-02-04 14:33:41 +01:00
ailin-nemui
5b530737d4 correct fix for #997 2019-02-02 14:51:09 +01:00
ailin-nemui
ff18e79661
Merge pull request #994 from ailin-nemui/fix-993
add more config checks and assertions in statusbar code
2019-02-02 14:34:59 +01:00
ailin-nemui
b1d6cb7f26 add missing NULL check 2019-02-01 13:18:50 +01:00
ailin-nemui
9f9aada83b do not touch uninitialised protocols on item restore 2019-01-29 21:33:39 +01:00
ailin-nemui
f9beedd2d0 add more config checks and assertions 2019-01-22 15:24:52 +01:00
ailin-nemui
3af2ce8731 add activity_hide_visible setting 2019-01-15 21:02:27 +01:00
ailin-nemui
b080405c6a update sidewayssplit syntax 2019-01-09 23:46:57 +01:00
ailin-nemui
d57203e926
Merge pull request #978 from ailin-nemui/fix-974
Fix inconsistent escaping from expand_escapes
2019-01-09 09:29:29 +01:00
ailin-nemui
8c30367452 rename function 2019-01-08 15:48:12 +01:00
ailin-nemui
c044fe397e
Merge pull request #982 from yarda/coverity
Fixed problem found by Coverity Scan
2018-12-18 16:57:36 +01:00
ailin-nemui
35f5e5f278 up abi 2018-12-07 10:01:56 +01:00
ailin-nemui
7e6e3cd503 Add escape_string_escape function for expand_escapes
To avoid expanding, tab completion escapes the completion list. But the
escape_string function escapes too much for the expand_escapes code. Add
a function that only escapes the backslashes.
2018-12-07 10:00:29 +01:00
Jaroslav Škarvada
4f26ad74f5
Fixed problem found by Coverity Scan
Fixes #981

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2018-12-04 21:07:06 +01:00
ailin-nemui
40f5edf105
Merge pull request #979 from ailin-nemui/completion-keep-word
add keep_word setting to completion
2018-12-04 17:01:33 +01:00
ailin-nemui
1c6f256098
Merge pull request #973 from ailin-nemui/perl-wcwidth
expose wcwidth and related to perl
2018-11-29 10:18:16 +01:00
ailin-nemui
dcb412eb8b
Merge pull request #975 from NattyNarwhal/ibmi
Fix irssi build on IBM i and AIX
2018-11-26 18:52:02 +01:00
Calvin Buckley
482a3a5bdd
Remove unneeded comment 2018-11-26 09:56:04 -04:00
Calvin Buckley
a634b34ba4 Rename cap_* funcs to irc_cap_*
Some systems often "namespace" cap_ for themselves, and so irssi's
usage can conflict with their own. Bump ABI for this.
2018-11-25 14:50:47 +00:00
ailin-nemui
10f41e067e fix backward completion 2018-11-25 14:19:57 +01:00
ailin-nemui
88b1649195 add keep_word setting to completion 2018-11-25 14:16:08 +01:00
ailin-nemui
257cb2f5f9
Merge pull request #971 from ailin-nemui/paste-join-lines
fix paste_join_multiline
2018-11-19 16:07:00 +01:00
Calvin Buckley
4380f3820e Fix compilation of irc/core on AIX and IBM i
There's a function in the standard library of these OSes that conflict
with this function. Prefix it with `irc_`.
2018-11-19 13:58:51 +00:00
ailin-nemui
288f220f87 fix width of byte codepoints 2018-11-13 00:14:15 +01:00
ailin-nemui
deaa1da55e cast to unsigned char 2018-11-12 14:11:27 +01:00
ailin-nemui
9e5e5d8625 expose wcwidth and related to perl 2018-11-12 13:14:02 +01:00
ailin-nemui
6c40567dab
Merge pull request #957 from ailin-nemui/rawlog
Improve rawlog performance
2018-11-12 13:02:41 +01:00
ailin-nemui
4537d85b0b reverse queue 2018-11-09 11:32:00 +01:00
ailin-nemui
c1fb9a8402 fix paste_join_multiline 2018-11-09 11:06:13 +01:00
ailin-nemui
8054b5c2bd
Merge pull request #967 from vague666/hide_targets_no_item
allow activity_hide_targets to hide activity in itemless windows
2018-10-29 10:35:08 +01:00
vague666
ec577f9265 typo 2018-10-27 20:52:14 +02:00
vague666
f7966d9c08 allow activity_hide_targets to hide activity in itemless windows 2018-10-27 20:51:29 +02:00
vague666
3061f5d848 make sure only channels are checked 2018-10-27 20:00:15 +02:00
vague666
2093530e75 Make it possible to only autolog saved channels 2018-10-27 16:08:36 +02:00
ailin-nemui
524f31b026
Merge pull request #965 from ailin-nemui/fix-signal-emit
Fix wrong signal emission arg count
2018-10-19 02:08:08 +02:00
Doug Freed
f11b629b2f Fix issues pointed out by e38774cc 2018-10-19 01:06:43 +02:00
ailin-nemui
bc1d82a757
Merge pull request #964 from ailin-nemui/fixes
fix duplicate include guard and link libs of test
2018-10-18 15:15:50 +02:00
ailin-nemui
6ca13dd5cd
Merge pull request #905 from horgh/horgh/topic-regression
Add tests for topic events
2018-10-17 12:31:52 +02:00
ailin-nemui
cbc27062e7 fix duplicate include guard 2018-10-17 00:58:49 +02:00
Will Storey
81f3d6dbc1 Comment colour code meaning 2018-10-08 20:40:37 -07:00
Will Storey
08b4d6c031 Fix some space indentation 2018-10-08 20:23:22 -07:00
ailin-nemui
4eff3f154d
Merge pull request #959 from ailin-nemui/notice-routing
Route notices intended for channels into the channel
2018-10-08 18:18:54 +02:00
ailin-nemui
cdcb50f413 add a setting 2018-10-08 17:41:46 +02:00
ailin-nemui
a30fbd6cfb
Merge pull request #961 from ailin-nemui/no-topic-glitch
Show the proper TXT when topic was unset
2018-10-07 10:23:19 +02:00
ailin-nemui
80f9f16939 Show the proper TXT when topic was unset 2018-10-06 20:14:49 +02:00
ailin-nemui
8b1afbd355 revert core changes 2018-10-06 20:05:54 +02:00
ailin-nemui
08ac2ee5be refactor cnotice test into function 2018-10-05 16:13:47 +02:00
ailin-nemui
d2dbcc1999 Route notices intended for channels into the channel 2018-10-05 15:37:27 +02:00
ailin-nemui
2200bd3656 Make /1/2/3/... a setting 2018-10-05 13:46:39 +02:00
ailin-nemui
cee9d09deb
Merge pull request #955 from ailin-nemui/split-width-bug
fix and document window width on screen width dependency
2018-10-05 10:49:50 +02:00
ailin-nemui
d815c88050
Merge pull request #953 from dwfreed/fix-printtext.h
Use ##__VA_ARGS__ extension to allow for argument-less ...
2018-10-05 10:48:25 +02:00
ailin-nemui
b96a41cf3d
Merge pull request #951 from dwfreed/patch-1
fe-text: clear hidelevel in layout if default
2018-10-05 10:47:12 +02:00
ailin-nemui
1e2547eb92 fixup perl side 2018-10-04 09:33:07 +02:00
ailin-nemui
ff0daf5870 actually create the queue, too 2018-10-04 09:31:08 +02:00
ailin-nemui
95692d4d86 up abi 2018-10-04 09:24:10 +02:00
ailin-nemui
05fd64dd16 improve rawlog perf 2018-10-04 09:24:10 +02:00
ailin-nemui
f207e844f1
Merge pull request #949 from ailin-nemui/help-narrow
Fix insufficient size of help column when the window width is small
2018-10-02 00:09:01 +02:00
ailin-nemui
011372ecdd
Merge pull request #948 from ailin-nemui/invalid-startline
invalidate startline and bottom_startline when hidden
2018-10-02 00:08:30 +02:00
ailin-nemui
ca1ec21dc2 fix and document window width on screen width dependency 2018-10-01 09:14:03 +02:00
Doug Freed
c4bf228e6c Fix check for C99 in printtext.h 2018-09-30 06:52:02 +00:00
Doug Freed
f5e587a83b
Fix 01f961c 2018-09-29 18:37:10 -04:00
ailin-nemui
7ab52e73c6
Merge pull request #947 from ailin-nemui/rsplit-collapse
Fix broken display after resizing many windows very small
2018-09-29 22:03:06 +02:00
ailin-nemui
630c6f7e14
Merge pull request #946 from ailin-nemui/resize-freeze
fix irssi being stuck when resized very small
2018-09-29 22:02:29 +02:00
ailin-nemui
116e202d22
Merge pull request #938 from ailin-nemui/hide-hidden-act
Don't trigger activity on hidden lines by default
2018-09-29 22:02:10 +02:00
Doug Freed
b264540f4e
fe-text: clear hidelevel in layout if default
This is required, otherwise setting the hidelevel to the default will
not be written in the layout and so won't persist.
2018-09-29 07:13:32 -04:00
ailin-nemui
04daf62dbf Fix insufficient size of help column when the window width is small 2018-09-28 14:30:39 +02:00
ailin-nemui
8684ccb45c invalidate startline and bottom_startline when hidden
this was overlooked when adding hidden line support. if the lines are
removed, Irssi has to update the startline. It does that by "scrolling"
the lines to the proper place. The scroll function was adjusted to
calculate 0 for hidden lines, thus it would miss them.
2018-09-28 11:41:30 +02:00
ailin-nemui
76b934d18e Fix broken display after resizing many windows very small 2018-09-26 15:21:08 +02:00
ailin-nemui
db005007cf fix irssi being stuck when resized very small 2018-09-26 14:18:37 +02:00
ailin-nemui
01f961cdf1 Don't trigger activity on hidden lines by default
This is controlled by a new activity_hide_window_hidelevel setting.
2018-09-24 08:18:13 +00:00
ailin-nemui
cdfd75da98
Merge pull request #941 from dwfreed/window_default_hidelevel
Add window_default_hidelevel setting
2018-09-23 11:22:46 +02:00
ailin-nemui
57857856a6
Merge pull request #937 from ailin-nemui/hidden-ignores
correctly separate ignore flags (no_act, hidden) from level
2018-09-23 11:22:31 +02:00
ailin-nemui
f231a59e81 properly document the ignore_match_level so I understand it next time 2018-09-20 17:50:35 +02:00
ailin-nemui
ee92e3aff2
Merge pull request #939 from ailin-nemui/fix-modules
some header fixes for C modules
2018-09-20 17:38:03 +02:00
ailin-nemui
708ba06dbc
Merge pull request #930 from ailin-nemui/fix-928
fix accessing unallocated text when checking entry position
2018-09-20 17:37:50 +02:00
ailin-nemui
a7af259dd1
Merge pull request #929 from ailin-nemui/oddcommands
Remove incorrectly copied automake commands from fuzzer
2018-09-18 21:14:55 +02:00
Doug Freed
cad79f1db7 Fix compilation warning 2018-09-17 14:34:06 +00:00
Doug Freed
074e6cf768 fe-text: only save non-default window hidelevel
This will only save the window hidelevel in the layout if it differs
from window_default_hidelevel.
2018-09-17 14:26:25 +00:00
Doug Freed
cb6279c63b fe-text: add window_default_hidelevel setting
Allows specifying the hidelevel that new windows get by default.
2018-09-17 13:28:46 +00:00
ailin-nemui
011d9437d1 oops 2018-09-17 13:08:43 +02:00
ailin-nemui
7e9f8c694b simplify ignore hidden/no_act code 2018-09-17 12:48:42 +02:00
ailin-nemui
b9a274a81d correctly separate ignore flags (no_act, hidden) from level 2018-09-17 12:26:13 +02:00
ailin-nemui
20dcf4e53e fix compilation of python module 2018-09-14 12:44:41 +02:00
ailin-nemui
c174247502 fix compilation of theme-indent module 2018-09-14 11:59:05 +02:00
ailin-nemui
c80946bcf5 Disconnect SASL properly in case the sasl module got unloaded from server
stops from getting on the network when sasl is unavailable

fixes #629
2018-09-04 15:50:58 +02:00
ailin-nemui
74e8371bde fix accessing unallocated text when checking entry position
fixes #928
2018-09-04 14:12:03 +02:00
ailin-nemui
3f0a4ef197 Remove incorrectly copied automake commands from fuzzer 2018-09-04 10:17:20 +02:00
ailin-nemui
7f14d4d744
Merge pull request #896 from phillid/winch-redraw
Don't ignore SIGWINCH when window size is unchanged
2018-09-04 10:02:52 +02:00
ailin-nemui
d93cd63243
Merge pull request #917 from dequis/wcwidth-wrapper
Add a wrapper of wcwidth() that picks the best implementation
2018-09-04 09:52:21 +02:00
ailin-nemui
e5759a7fb7
Merge pull request #914 from ailin-nemui/textbuffer_lineinfo
properly record line info on empty lines
2018-09-04 09:37:10 +02:00
ailin-nemui
329448939b
Fix gnu wcwidth 2018-09-04 09:36:45 +02:00
ailin-nemui
afb3daaf65
Merge pull request #919 from ailin-nemui/uafs
Use-after-frees
2018-09-04 09:35:47 +02:00
ailin-nemui
8261b2a7c8
Merge pull request #922 from dequis/fix-new-config-file-write
Fix /save not working if the config didn't previously exist
2018-09-04 09:35:21 +02:00
dequis
e2e27d1809 Improve error message when failing to create the config dir 2018-09-02 01:20:09 -03:00
dequis
3351c54a2f Fix /save not working if the config didn't previously exist
realpath() was supposed to resolve symlinks but it also fails with
ENOENT (no such file or directory) if the file just isn't there.
2018-09-01 19:12:17 -03:00
Will Storey
b11932d24f Make channel event functions static again 2018-08-27 21:04:23 -07:00
Will Storey
2ccb312b8b Expose functions for testing 2018-08-27 20:51:18 -07:00
Will Storey
2d6033542e Add functions to override irssi dir and config
Setting up to test is easier this way.
2018-08-27 20:51:18 -07:00
Will Storey
04db359a6d Handle topic info numeric separately from topic & topic numeric
As we called the same function for the topic info numeric, we ended up
losing the topic as that numeric does not include it. We now call a
different function to handle this case more carefully. Fixes #903.
2018-08-27 20:51:18 -07:00
Will Storey
bbca1a5a0f Revert "Revert "Flag topic as unset if it is zero length""
This reverts commit 817179a760.
2018-08-27 20:50:17 -07:00
ailin-nemui
1bbd9f393c
Merge pull request #909 from meribold/master
Fix `/save` replacing symlinks with regular files
2018-08-27 10:13:20 +02:00
dequis
7b70d051da wcwidth-wrapper: avoid cast with a tiny wrapper, julia_wcwidth() 2018-08-27 00:14:01 -03:00
dequis
92804cb1aa gui-windows: make the wcwidth_impl global var into static 2018-08-27 00:01:47 -03:00
dequis
e450a7f8c1 modules_deinit: Fix -Werror=declaration-after-statement 2018-08-24 02:27:45 -03:00
dequis
ade2f87fe5 Fix use after free introduced by the use after free patch 2018-08-24 02:19:42 -03:00
dequis
9dd836b876 Fix "discards ‘const’ qualifier" warnings 2018-08-24 02:11:22 -03:00
ailin-nemui
071ada830b up abi 2018-08-23 14:21:37 +02:00
coypu@sdf.org
610ab2dafa Use-after-frees
Hi folks!

I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.

(in special-vars.c, ret is commands->data sometime)

I hope it's not too much trouble if reported as a confidential bug.
Thanks.
2018-08-23 14:13:48 +02:00
ailin-nemui
b2a429bfb4 update line cache on switching wcwidth implementation 2018-08-23 14:03:53 +02:00
ailin-nemui
3ef0b9b3d0 move "auto" to default instead 2018-08-23 14:03:16 +02:00
ailin-nemui
b95ce3e812 add julia's utf8proc wcwidth implementation 2018-08-23 13:23:35 +02:00
dequis
24f1ed7edb irc-cap: Don't show warning on CAP LIST response 2018-08-23 03:22:30 -03:00
dequis
0d8632943d Add a wrapper of wcwidth() that picks the best implementation
This adds a i_wcwidth() function that replaces mk_wcwidth(), and a
'wcwidth_implementation' setting to pick which one it wraps.

Values:

- old: uses our local mk_wcwidth() which implements unicode 5.0
- system: uses the libc-provided wcwidth(), which may be better or worse
  than ours depending on how up to date the system is.
- auto: tests the system one against two characters that became
  fullwidth in unicode 5.2 and 9.0 respectively. If either of them pass,
  pick the system implementation, otherwise pick ours.

It defaults to auto.

mk_wcwidth() is still preferable in some cases, since the way it uses
ranges for fullwidth characters means most CJK blocks are covered even
if their characters didn't exist back then.

The "system" implementation is also wrapped to never return -1, but to
assume those unknown characters use one cell. Quoting the code:

    /* Treat all unknown characters as taking one cell. This is
     * the reason mk_wcwidth and other outdated implementations
     * mostly worked with newer unicode, while glibc's wcwidth
     * needs updating to recognize new characters.
     *
     * Instead of relying on that, we keep the behavior of assuming
     * one cell even for glibc's implementation, which is still
     * highly accurate and less of a headache overall.
     */
2018-08-23 02:30:26 -03:00
ailin-nemui
af1e4d6e34 initialise the line to zeros 2018-08-21 09:21:23 +02:00
ailin-nemui
a19b503a31 properly record line info on empty lines 2018-08-21 00:31:12 +02:00
Joseph Bisch
4f5f62ac63 Add server-fuzz to fe-fuzz
Based on test-796.c in the tests directory.
2018-08-15 11:11:09 -04:00
ailin-nemui
817179a760
Revert "Flag topic as unset if it is zero length" 2018-08-13 14:43:25 +02:00
Lukas Waymann
7d3eb47ab5 Fix potential rename(3) across file systems
Make sure the temporary file in the `config_write` function is created
on the same file system as the file we `rename` it to later.
2018-08-12 10:55:47 +00:00
Lukas Waymann
764f8215a9 Fix /save replacing symlinks with regular files
A side-effect of 8deb618 is that `/save` may replace configuration files
that are symlinks with regular files.  Fix this by resolving all
symlinks before renaming the temporary file.
2018-08-12 07:22:14 +00:00
David Phillips
10f6326649 Redraw on SIGWINCH when screen size hasn't changed
Some programs and users send SIGWINCH as a request for the client to redraw
in the event of session detachment/reattachment (e.g. abduco). A well-formed
terminal will only send SIGWINCH when the window size has changed, so there
is no need to optimise this case out.
2018-08-06 14:58:56 +12:00
Doug Freed
f3909b8bcb
core/ignore: fix #900 2018-08-03 17:07:06 -04:00
ailin-nemui
0c94d44f52
Merge pull request #892 from dwfreed/fix-ignore-flags
core/ignore: fix ignore_match_level handling of flag levels
2018-08-02 13:42:24 +02:00
ailin-nemui
ffd7ecc8bf
Merge pull request #897 from horgh/horgh/topic-unset
Flag topic as unset if it is zero length
2018-07-31 09:34:15 +02:00
dequis
b114b11e36 channel_change_topic: change one strlen == 0 to *str == '\0' 2018-07-30 23:45:56 -03:00
ailin-nemui
c7e50f48e5
Merge pull request #886 from vague666/set_item_format
remove = from format because people get confused by it
2018-07-25 11:32:06 +02:00
Will Storey
15840ac27b If we receive a 0 length topic, record it as unset
Fixes #888.

Previously we showed that there was a topic set when using /topic, just
an empty one. This was different than how we show such topics when
initially joining a channel. Now we say that the topic is unset in both
cases.
2018-07-24 18:45:22 -07:00
Will Storey
0e187cf9cf Fix typo in comment 2018-07-24 18:29:31 -07:00
Janik Rabe
4f45828ff3
Keep errstr set to NULL if errno is not set
Don't use errno if it is not set and show the default error message
instead. This prevents messages like "SSL handshake failed: Success"
from being shown.
2018-07-18 21:12:38 +03:00
Doug Freed
d84a24444f core/ignore: fix ignore_match_level handling of flag levels 2018-06-29 09:00:38 -04:00
vague666
1ab679bf32 remove = from format because people get confused by it 2018-06-14 20:07:43 +02:00
vague666
ba2554dd14 missing space 2018-06-09 05:55:25 +02:00
vague666
d2e1caf720 simplifying code 2018-06-07 15:17:46 +02:00
vague666
1547248e94 simplify code 2018-06-06 11:03:44 +02:00
vague666
ac3af3fb56 these were bitflags 2018-06-06 10:00:38 +02:00
vague666
db3b671328 Added HIDDEN level to ignores 2018-06-05 15:29:40 +02:00
ailin-nemui
631650bd8a
Revert "record line info on empty lines" 2018-05-07 21:22:43 +02:00
ailin-nemui
e19d6ee219
Merge pull request #873 from ailin-nemui/empty_lines
record line info on empty lines
2018-04-24 13:58:25 +02:00
ailin-nemui
0caf884e92
Merge pull request #871 from dequis/atomic-config-write
Make config_write more atomic to prevent truncation when out of space
2018-04-24 13:58:15 +02:00
ailin-nemui
34b31e8451 record line info on empty lines 2018-04-16 16:22:04 +02:00
dequis
8deb6182c6 Make config_write more atomic to prevent truncation when out of space
This is modeled after glib's g_file_set_contents. It doesn't use that
function directly because the writing is done with GIOChannel
streaming-like writes and g_file_set_contents expects the whole thing to
be in-memory.

Main differences with g_file_set_contents:

- complete lack of win32 special casing (cygwin/WSL should work though)
- no fallocate() (linux only, but we don't know the size upfront, anyway)
- always calls fsync (glib skips it on btrfs or when not overwriting)

Other than that, it's the same old mkstemp + fsync + rename.
2018-04-08 15:52:09 -03:00
dequis
d0151fd5a2 Add fe-cap to show messages for CAP-related events in the UI
Replaces cap.pl
2018-04-08 01:26:11 -03:00
dequis
af5ee997e7 Add "server cap req" signal, emitted before requesting caps 2018-04-08 01:24:48 -03:00
ailin-nemui
b2b1ac6708
Merge pull request #866 from ailin-nemui/reconnects
This is a simple change which might fix #130

The lookup_servers are also disconnected if the lookup/SSL handshake doesn't succeed in time. I'm not perfectly sure if this is the master fix but it does seem to be an issue that servers can be stuck in lookup, especially for SSL. See the issue for a reproducer
2018-04-06 10:50:58 +02:00
ailin-nemui
8bf2162053
Merge pull request #858 from ailin-nemui/sbar
change the statusbar commands so that no accidential status bars are created
2018-04-02 08:36:53 +02:00
ailin-nemui
0c1db8f2ae
Merge pull request #854 from irssi/ahf/otr
OTR support, take 2
2018-03-31 13:04:35 +02:00
dequis
4501917cae otr: rename module.c to otr-module.c 2018-03-31 01:46:34 -03:00
ailin-nemui
c08685a1a3 also reconnect lookup_servers 2018-03-29 23:24:13 +02:00
ailin-nemui
a3b9e2370f up abi 2018-03-29 22:00:40 +02:00
dequis
7d7c6975ed otr: add target param to the unencrypted 'message private' signal
Same case as the previous commit.
2018-03-28 23:36:03 -03:00
dequis
dd7dc7ca7d otr: fix missing 'target' param in 'message private' signal
Fixes warnings like these on '/msg yourself'

-!- Irssi: critical privmsg_get_query: assertion 'nick != NULL' failed
-!- Irssi: critical query_find: assertion 'nick != NULL' failed
2018-03-28 23:06:47 -03:00
dequis
b52cf1015e otr: add KEY_GEN_STARTED state to avoid starting it twice
Fun race condition there, got this when testing with the jabber
xmlconsole open in bitlbee
2018-03-28 22:40:17 -03:00
Dorian Harmans
17920ab5aa Merge remote-tracking branch 'upstream/master' 2018-03-26 22:50:54 +02:00
ailin-nemui
7fc59d2d10
Merge pull request #862 from ailin-nemui/line_is_null
fix a crash when trying to append to a NULL line
2018-03-26 12:46:04 +02:00
Dorian Harmans
25a44dacf4 fix build with LibreSSL 2.7.0 2018-03-23 21:35:35 +01:00
ailin-nemui
138eca0749 fix build 2018-03-20 18:13:26 +01:00
ailin-nemui
ee04cd503f add disabled txt 2018-03-20 17:59:11 +01:00
ailin-nemui
977c2c0a0d refactor common parts 2018-03-20 17:53:03 +01:00
ailin-nemui
501c150ec2 make new status bar actually work 2018-03-20 17:39:08 +01:00
ailin-nemui
7d99ff05cd
Merge pull request #803 from ailin-nemui/bug-796-test
Postpone server cleanup until after unref
2018-03-20 10:30:01 +01:00
ailin-nemui
6ffbd0ab54
Merge pull request #859 from ailin-nemui/delkeys
make default keybinds deletable
2018-03-19 16:23:27 +01:00
ailin-nemui
c8191b3315 abi bump 2018-03-19 10:35:42 +01:00
ailin-nemui
61c58b7690 actually check which of add or modify was called 2018-03-19 10:35:39 +01:00
ailin-nemui
d845ee7361 change the statusbar commands so that no accidenal status bars are created 2018-03-19 09:59:22 +01:00
ailin-nemui
c7ca8102c0 fix a crash when trying to append to a NULL line
reported by @vague666
2018-03-17 13:36:38 +01:00
ailin-nemui
65a139aa9e move no window printing code 2018-03-16 12:54:15 +01:00
Alexander Færøy
8d07f52bae Add ABI check for otr_core module. 2018-03-15 14:01:50 +01:00
ailin-nemui
b7906b8706 in fact hidden levels should not be re-set when you run /set 2018-03-15 10:06:29 +01:00
ailin-nemui
7ec6c500b4 make default keybinds deletable 2018-03-12 17:46:26 +01:00
ailin-nemui
575daf4af7
Merge pull request #852 from dequis/document-cat-seek
Document second parameter (seek position) of /cat command
2018-03-10 13:11:39 +01:00
LemonBoy
76d958a87f More g_strcmp0 -> g_ascii_strcasecmp 2018-03-09 17:36:28 +01:00
LemonBoy
fb9f5174c2 Compare channels/networks fields case-insensitively
Fixes #856
2018-03-08 20:35:00 +01:00
Alexander Færøy
016b42baea Add OTR support.
This patch adds support for the OTR protocol to irssi. This is an import
of the external irssi-otr project that we are now taking over
maintership for.

Major thanks to the original authors of Irssi-OTR: Uli Meis and David
Goulet. Thanks to the OTR community in #OTR on OFTC, thanks to everyone
who have helped testing the patches and submitted UI suggestions.
2018-02-26 23:32:57 +01:00
dequis
097a9f4988 Document second parameter (seek position) of /cat command 2018-02-16 10:09:48 -03:00
ailin-nemui
203f6c5329 also unblock theme elements when processing finished 2018-02-16 13:46:29 +01:00
ailin-nemui
e289d34b9a limit alignment padding to a screenful
Credit to Oss-Fuzz
2018-02-14 15:04:24 +01:00
ailin-nemui
a6fcd5432e improve padding performance
Credit to Oss-Fuzz
2018-02-13 12:31:22 +01:00
ailin-nemui
c01f6df957
Merge pull request #844 from CatboxParadox/perms
dcc get shouldn't fail when file attrs can't be changed
2018-02-13 11:10:21 +01:00
Nei
b0d9cb33cd Merge branch 'security' into 'master'
Security

See merge request irssi/irssi!34
2018-02-13 09:51:22 +00:00
Staron, Martin
3cbcb4fe85 dcc get shouldn't fail when file attrs can't be changed 2018-02-13 08:15:39 +01:00
ailin-nemui
5c5ed64180 try to make sure the server is still good enough to call ischannel when printing netsplit/join 2018-02-09 13:02:00 +01:00
ailin-nemui
946876b1e9
Merge pull request #843 from ailin-nemui/glib238
restore compat with glib <2.40
2018-02-09 11:49:23 +01:00
ailin-nemui
16912e1a91 restore compat with glib <2.40 2018-02-08 14:41:08 +01:00
ailin-nemui
e32e9d63c6 Do not read beyond end of escaped string
Credit to OSS-Fuzz
2018-02-08 14:11:23 +01:00
ailin-nemui
02712942e0
Merge pull request #835 from ailin-nemui/theme-stack
protect theme recursion
2018-02-07 21:23:39 +01:00
ailin-nemui
1e6d787401 ensure cap_supported is existent yet 2018-02-07 11:07:22 +01:00
Nei
12483c688a Merge branch 'sasl-timeout' into 'security'
Fix Sasl timeout error

See merge request irssi/irssi!33
2018-02-06 06:46:11 +00:00
Nei
a73659e0ea Merge branch 'soperise' into 'security'
Soperise

See merge request irssi/irssi!32
2018-02-06 06:45:54 +00:00
Nei
41e2b535ef Merge branch 'nonick' into 'security'
please give us nicks

See merge request irssi/irssi!31
2018-02-06 06:45:32 +00:00
ailin-nemui
f8fbc1e1ab
Merge pull request #775 from LemonBoy/caps_kv
CAP 3.2 support
2018-02-05 22:29:35 +01:00
ailin-nemui
8183180613
Merge pull request #764 from GinjaNinja32/colorful-input
Add color support for input bar
2018-02-05 22:28:08 +01:00
ailin-nemui
cfcc021c81
Merge pull request #824 from dequis/more-netsplit-revert
Revert more of the netsplit print optimisation to fix crashes
2018-02-05 22:26:32 +01:00
ailin-nemui
3c1bc5f916
Merge pull request #836 from ailin-nemui/resize
Fix resizing of windows when used incorrectly
2018-02-05 22:25:33 +01:00
ailin-nemui
442f6f08b4
Merge pull request #837 from ailin-nemui/no-show
check the error condition of mainwindow_create
2018-02-05 22:24:17 +01:00
ailin-nemui
b33ce255a9 check for negative bound 2018-02-04 11:34:20 +01:00
ailin-nemui
c25e122149
Merge pull request #822 from Manishearth/autocomplete-colon
Insert colons after completing nicks preceded by a list of other autocompleted nicks
2018-02-04 11:28:25 +01:00
ailin-nemui
9c494a88a3
Merge pull request #831 from ailin-nemui/openssl-x509
Do not use X509_STORE on OpenSSL < 1.0.2
2018-02-04 11:27:02 +01:00
ailin-nemui
2185c4ddb3 up abi 2018-02-03 23:19:27 +01:00
ailin-nemui
9072e98819 change color -> extents (malloc based) 2018-02-02 13:56:56 +01:00
ailin-nemui
84f03e0146 do not reuse sasl timeout 2018-02-02 11:43:23 +01:00
ailin-nemui
5b5bfef035 check the error condition of mainwindow_create 2018-02-02 10:05:37 +01:00
ailin-nemui
f0bd434eb0 stop the madness 2018-02-02 09:50:08 +01:00
ailin-nemui
4c662acf95 another replaces fix
Credit to OSS-Fuzz
2018-02-01 14:19:40 +01:00
ailin-nemui
12360fb2c0 protect theme recursion 2018-02-01 10:21:31 +01:00
ailin-nemui
8028dcff93
Merge pull request #830 from g-elfling/master
Add Shift-Tab completion to gui-readline
2018-01-30 11:20:40 +01:00
ailin-nemui
126189bb37 we probably should not try to replace replaces
Credit to OSS-Fuzz
2018-01-29 09:28:55 +01:00
dequis
a4f99ae746 Revert more of the netsplit print optimisation to fix crashes
Now iterating over all servers to avoid crashes on server_ischannel(),
which is a macro for server->ischannel(), so it dies horribly when it's
null. Doesn't help that IS_IRC_SERVER() always returns true on null.
2018-01-28 23:06:26 -03:00
ailin-nemui
0909d47e5b Check that server is still existent when using /oper 2018-01-25 16:11:31 +01:00
ailin-nemui
e91da9e409 please give us nicks 2018-01-25 16:05:47 +01:00
Ailin Nemui
af087e1103 fix sequence error 2018-01-25 15:08:26 +01:00
Ailin Nemui
f5aa829bd0 Do not use X509_STORE on OpenSSL < 1.0.2 2018-01-25 15:01:55 +01:00
Niklas Luokkala
6dfe5bc836 modified gui-readline based on the suggestions made to the pull request 2018-01-24 22:12:09 +02:00
LemonBoy
260733475c Accept CAPs with an empty value (KEY=) 2018-01-24 10:55:20 +01:00
LemonBoy
b0b40be82e Deprecate gslist_remove_string
It is not used anymore and it leaks memory.
2018-01-24 10:47:40 +01:00
LemonBoy
474ee8ee70 Address some minor stylish nits 2018-01-24 10:45:54 +01:00
Niklas Luokkala
0ba1b1f2a4 removed unnecessary repetition 2018-01-24 01:49:28 +02:00
Niklas Luokkala
d14dbbd093 Add Shift-Tab completion to gui-readline 2018-01-24 00:15:29 +02:00
Manish Goregaokar
12d08f79bb Insert colons after completing nicks preceded by a list of other autocompleted nicks
When pinging two people, typing `nick1<tab> nick2<tab> message` for
autocompletion will get you `nick1: nick2 message`, which is kinda
confusing.

We only insert the colon after the first autocompleted nick,
because if a nick is used in the middle of the sentence it's mentioning
the person but not targeting the message at them.

However, this breaks down when we try to ping a list of people. There
should be a colon in front of each separating the names from the
message. only having a colon at the end of the nick list works too,
but it seems like the IRC convention is to just use multiple colons.

This patch makes it so that autocompleting a nick after a list of
existing autocompleted nicks at the beginning of the message
will include a colon.
2018-01-20 10:25:06 +05:30
GinjaNinja32
0f1b3873fe Don't accept pos<0 or len<0 in gui_entry_set_color 2018-01-18 10:08:00 +01:00
GinjaNinja32
13b93c8c05 Apply changes based on review feedback 2018-01-18 10:08:00 +01:00
GinjaNinja32
925ae6e6ad Add color support for input bar 2018-01-18 10:08:00 +01:00
Zero King
d983ad1a87 Update Irssi website URLs 2018-01-16 15:23:54 +00:00
Joseph Bisch
182673ed05 Add theme_load to fe-fuzz 2018-01-15 11:59:01 -05:00
Joseph Bisch
4512e2683a
Merge pull request #780 from josephbisch/fuzz-event-get-params
Add event_get_params to fe-fuzz
2018-01-15 10:53:21 -05:00
ailin-nemui
fa8508404f revert netsplit print optimisation
this reverts part of #465

unfortunately we need to further refine the initial patch

 - when filtering by channel, the whole split is cleaned up nevertheless
 - something similar happens for the netjoins
 - furthermore, we cannot wait only for PUBLIC msgs, j/p/q are equivalently relevant for temporal integrity
2018-01-10 20:12:04 +01:00
Jari Matilainen
4041f29711 Changed spaces to tab 2018-01-09 23:16:26 +01:00
Jari Matilainen
f2e73a7046 Add perl access to hidden_level in TEXT_BUFFER_VIEW_REC 2018-01-09 23:15:08 +01:00