Marvin Scholz
63a9014383
Update: Add tests for error functions
2020-09-04 02:08:11 +02:00
Marvin Scholz
c1ce1de619
Fix: Handle invalid error entries in error_get_by_uuid
2020-09-04 02:06:09 +02:00
Marvin Scholz
d22ce7b95d
Update: Refactor error codes to a key-indexed array
...
Instead of storing the ID in the icecast_error_tag, use it as
array index for the error codes lookup list. That way its not
needed anymore to iterate the whole list to lookup errors by id.
2020-09-04 01:27:29 +02:00
Philipp Schafft
987bdec373
Merge branch 'epirat-yp-listenurl-fix'
...
Good work. Thanks to ePirat.
2020-04-30 08:53:57 +00:00
Marvin Scholz
9275dfd8c8
Feature: Improve logging for yp-directory options parsing
2020-04-30 10:52:18 +02:00
Marvin Scholz
349c29ca48
Feature: Add "listen-socket" option for YP directories
2020-04-24 23:45:49 +02:00
Marvin Scholz
495ecbf57d
Fix: Add missing space in YP log message
2020-04-23 19:01:02 +02:00
Marvin Scholz
632f67b0c8
Feature: New config block to define YP directories
...
Adds a new config block, <yp-directory> with the mandatory "url"
attribute and optional <option> entries in the block:
<yp-directory url="http://example.org/yp-cgi ">
<option name="timeout" value="5" />
<option name="touch-interval" value="45" />
</yp-directory>
2020-04-23 18:40:36 +02:00
Marvin Scholz
6d3bf28be1
Update: Use linked list for YP config entries
...
This removes the limit of 25 YP directory entries by using a linked
list like with most other config entries.
2020-04-23 05:14:12 +02:00
Marvin Scholz
4284ea5b3b
Cleanup: Prepare migration to new yp options
2020-04-23 03:18:51 +02:00
Marvin Scholz
f2547c7cb0
Cleanup: Remove unused touch_interval config
2020-04-23 03:03:52 +02:00
Marvin Scholz
271ef864ac
Cleanup: Remove unused server block in directory
...
The director block for YP directories accepted a server block which
was completely unused in the whole codebase, so do not parse it in
the first place.
2020-04-23 03:00:32 +02:00
Philipp Schafft
dcdd96c000
Update: Make listensocket_container_get_by_id() public
2020-04-22 19:35:35 +00:00
Marvin Scholz
f898da63b8
Cleanup: YP: Narrow variable scope
2020-04-21 20:43:01 +02:00
Marvin Scholz
e534df86f8
Fix: YP: Improve error handling
...
In case the url written by client_get_baseurl exceeds the length and
the realloc failed, previously the truncated URL would have been used.
The error case (ret < 0) was not handled at all before.
2020-04-21 20:43:01 +02:00
Marvin Scholz
7563fe9e52
Fix: YP: Send correct listener URL in case of TLS
2020-04-21 20:12:22 +02:00
Marvin Scholz
2b56f73cfb
Cleanup: Do not name variable same as hex function
2020-04-19 04:14:07 +02:00
Marvin Scholz
386a461016
Fix: Fixed check for icecast_kva_t value
2020-04-19 04:10:28 +02:00
Marvin Scholz
e6856c153e
Cleanup: Fix order of arguments in forward declaration
2020-04-19 04:05:24 +02:00
Marvin Scholz
b93ac5a94e
Fix: Fixed check for root node in reportxml
2020-04-19 03:58:31 +02:00
Marvin Scholz
0c3da2df86
Cleanup: Simplify client_complete
...
Instead of using a "have" variable which makes it a bit confusing
to understand whats going on, use a do {} while (0) and break from it
instead.
2020-04-19 03:43:27 +02:00
Marvin Scholz
4b2d38fcfc
Cleanup: Remove duplicated check
2020-04-19 03:32:59 +02:00
Marvin Scholz
3352ddfb36
Cleanup: Remove redundant check
...
It's already checked earlier if auth is non-NULL, so this check
here is not needed.
2020-04-19 03:28:21 +02:00
Marvin Scholz
25f54db863
Fix: Reorder logging initialization to prevent race
...
Without this, the logging on the stats thread would race with the log
initialization on the main thread.
2020-04-19 03:09:49 +02:00
Marvin Scholz
d2b137a8ad
Fix: Fixed memory leak on relay parsing failure
2020-04-19 03:02:03 +02:00
Philipp Schafft
2ffaa92ea6
Fix: Fixed two double-unlock errors
2020-02-14 14:05:01 +00:00
Philipp Schafft
97181fb112
Updated submodules
2020-02-12 11:13:46 +00:00
Philipp Schafft
6ca6283cb4
Fix: Fixed invalid locking.
...
* listensocket_get_listener() must always be called with a matching call
to listensocket_release_listener
* No ticket for this, but may be related to #2372 .
* Found an reported by Xogium on IRC.
See: #2372
2019-11-22 14:48:49 +00:00
Philipp Schafft
ddafdd971f
Fix: Strange patch for ICY
2019-09-17 18:08:57 +00:00
Philipp Schafft
f83fe87ab9
Update: Added some debugging lines
2019-09-17 17:32:00 +00:00
Philipp Schafft
cf9c8cf9ad
Fix: Fixed leak in codec Speex codec probing code.
...
Thanks to Xogium for finding and debugging this!
Fixes : #2377
2019-06-28 08:03:51 +00:00
Philipp Schafft
1b94dea420
Update: Improved connecting-the-dots regarding clients and object IDs
2019-06-26 08:23:29 +00:00
Philipp Schafft
3761582ab8
Update: Mark a few developer level debugging messages as such
2019-05-28 07:55:18 +00:00
Philipp Schafft
fff3a5c6a6
Update: Write a error level message on admin/ based metadata updates we reject
2019-05-28 07:52:47 +00:00
Philipp Schafft
77312c4582
Update: Also show <audio> element on audio/webm
2019-05-28 07:26:51 +00:00
Philipp Schafft
e60a36bfb6
Fix: Corrected log output from <unknown< to <unknown>
2019-05-28 07:02:45 +00:00
Philipp Schafft
dbabf91510
Fix: Only send 100 on request and 200 only on SOURCE
2019-05-14 11:38:08 +00:00
Philipp Schafft
0288af5a93
Feature: Report SOURCE as deprecated in log on level DEBUG
2019-05-14 11:37:57 +00:00
Philipp Schafft
0467ef5657
Feature: Log HTTP method used to start a source
2019-05-14 11:37:06 +00:00
Philipp Schafft
7aaf0c0e86
Merge branch 'openssl-fixups'
2019-04-24 17:22:37 +00:00
Marvin Scholz
8b68c462c4
Fix: Free strings with older OpenSSL versions
2019-04-24 18:52:41 +02:00
Marvin Scholz
e09f48a034
Update: Do not use SSLv23_server_method
...
...with OpenSSL 1.1.0 or newer
Instead use TLS_server_method and
SSL_CTX_set_min_proto_version to limit
the used protocol versions.
2019-04-24 18:52:41 +02:00
Marvin Scholz
e824e48fdf
Cleanup: Remove unnecessary SSL_CTX_get_options
...
According to the documentation the current option state is not cleared
but the options are added to the current options, so gettin the
current options seems redundant to the behavior of SSL_CTX_set_options:
> SSL_CTX_set_options() adds the options set via bitmask in options
> to ctx. Options already set before are not cleared!
2019-04-24 18:52:41 +02:00
Marvin Scholz
14ba90fc93
Cleanup: Simplify adding SSL_OP_NO_COMPRESSION
2019-04-24 18:52:41 +02:00
Marvin Scholz
ed9a4e658c
Cleanup: Simplify OpenSSL context initialisation
...
Assigning the return value of SSLv23_server_method to a variable is
not necessary here and not doing it can get us rid of a lot of
condition code given that the type of the return value changed
at some point.
2019-04-24 18:52:41 +02:00
Marvin Scholz
07304b5193
Update: Do not init OpenSSL since 1.1.0
...
Explicitly initializing the library is not longer needed since
OpenSSL 1.1.0 and the SSL_library_init function is deprecated.
Citing the manual:
> As of version 1.1.0 OpenSSL will automatically allocate all resources
> that it needs so no explicit initialisation is required. Similarly it
> will also automatically deinitialise as required.
Fix #2318
2019-04-24 18:52:41 +02:00
Philipp Schafft
c64e36eae5
Update: Added tap-driver.sh to list of EXTRA_DIST files
2019-04-23 12:45:13 +00:00
Philipp Schafft
e234990932
Update: Source code is now in git
2019-04-23 12:45:13 +00:00
Marvin Scholz
7bccaf9d25
CI: Do not install openssl-dev
...
It conflicts with libressl, which is needed for curl now.
2019-04-04 09:44:42 +02:00
Philipp Schafft
de3a075500
Merge branch 'feature-auth-enforce-auth'
2019-01-16 14:12:15 +00:00