aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2024-09-25 22:55:55 -04:00
Code
fc11a308f1
amfora/NOTES.md
makeworld 543d15abfc 🔀 Refactor to use tab struct 
Squashed commit of the following:

commit 72f36afc9e
Author: makeworld <colecmac@protonmail.com>
Date:   Tue Jul 7 16:15:45 2020 -0400

    🚧 Scroll is applied correctly when navigating around

commit 4b8982723f
Author: makeworld <colecmac@protonmail.com>
Date:   Tue Jul 7 15:34:45 2020 -0400

    🚧 Fix bottomBar code

    Make sure it always resets to a selected link if one was selected before

commit be09ffcf91
Author: makeworld <colecmac@protonmail.com>
Date:   Mon Jul 6 20:30:54 2020 -0400

    🚧 Switch to using tab pointers instead of ints

    Almost finished overall work.

commit ef8ab3da39
Author: makeworld <colecmac@protonmail.com>
Date:   Mon Jul 6 12:10:50 2020 -0400

    🚧 Fixed some bugs, major ones remain

commit d3d47a344d
Author: makeworld <colecmac@protonmail.com>
Date:   Sat Jul 4 20:58:46 2020 -0400

    🚧 Everything uses tab struct, no compile errors, untested

commit 44bf54c12f
Author: makeworld <colecmac@protonmail.com>
Date:   Sat Jul 4 13:24:49 2020 -0400

    🚧 Initial work on tab struct
2020-07-07 21:13:45 -04:00

1.3 KiB
Raw Blame History

Notes

  • URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL

Issues

  • Can't go back or do other things while page is loading - need a way to stop handleURL
  • Change renderer to start style tags on each new line of wrapped link, to prevent left margin from being highlighted

Upstream Bugs

  • Wrapping messes up on brackets
  • Wrapping panics on strings with brackets and Asian characters
    • Filed cview issue 27
    • The panicking was reported and fixed in Amfora issue 20, but the lines are now just not wrapped
  • Text background not reset on ANSI pages
  • Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
    • Filed issue 26
    • Add some bold back into modal text after this is fixed
  • Bookmark keys aren't deleted, just set to ""
  • Help table cells aren't dynamically wrapped