mirror of
https://github.com/makew0rld/amfora.git
synced 2024-09-27 23:05:55 -04:00
543d15abfc
Squashed commit of the following: commit72f36afc9e
Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 16:15:45 2020 -0400 🚧 Scroll is applied correctly when navigating around commit4b8982723f
Author: makeworld <colecmac@protonmail.com> Date: Tue Jul 7 15:34:45 2020 -0400 🚧 Fix bottomBar code Make sure it always resets to a selected link if one was selected before commitbe09ffcf91
Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 20:30:54 2020 -0400 🚧 Switch to using tab pointers instead of ints Almost finished overall work. commitef8ab3da39
Author: makeworld <colecmac@protonmail.com> Date: Mon Jul 6 12:10:50 2020 -0400 🚧 Fixed some bugs, major ones remain commitd3d47a344d
Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 20:58:46 2020 -0400 🚧 Everything uses tab struct, no compile errors, untested commit44bf54c12f
Author: makeworld <colecmac@protonmail.com> Date: Sat Jul 4 13:24:49 2020 -0400 🚧 Initial work on tab struct
23 lines
1.3 KiB
Markdown
23 lines
1.3 KiB
Markdown
# Notes
|
|
|
|
- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL
|
|
|
|
## Issues
|
|
- Can't go back or do other things while page is loading - need a way to stop `handleURL`
|
|
- Change renderer to start style tags on each new line of wrapped link, to prevent left margin from being highlighted
|
|
|
|
## Upstream Bugs
|
|
- Wrapping messes up on brackets
|
|
- Filed [issue 23](https://gitlab.com/tslocum/cview/-/issues/23)
|
|
- Wrapping panics on strings with brackets and Asian characters
|
|
- Filed cview [issue 27](https://gitlab.com/tslocum/cview/-/issues/27)
|
|
- The panicking was reported and fixed in Amfora [issue 20](https://github.com/makeworld-the-better-one/amfora/issues/20), but the lines are now just not wrapped
|
|
- Text background not reset on ANSI pages
|
|
- Filed [issue 25](https://gitlab.com/tslocum/cview/-/issues/25)
|
|
- Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
|
|
- Filed [issue 26](https://gitlab.com/tslocum/cview/-/issues/26)
|
|
- Add some bold back into modal text after this is fixed
|
|
- Bookmark keys aren't deleted, just set to `""`
|
|
- Waiting on [this viper PR](https://github.com/spf13/viper/pull/519) to be merged
|
|
- Help table cells aren't dynamically wrapped
|
|
- Filed [issue 29](https://gitlab.com/tslocum/cview/-/issues/29) |