aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2024-11-03 02:37:23 -05:00
Code
44bf54c12f
amfora/NOTES.md
makeworld 44bf54c12f 🚧 Initial work on tab struct
2020-07-04 13:24:49 -04:00

1.2 KiB
Raw Blame History

Notes

  • Simplify into one struct
    • All the maps and stuff could be replaced with a tab struct
    • And then just one single map of tab number to tab
    • URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL

Upstream Bugs

  • Wrapping messes up on brackets
  • Wrapping panics on strings with brackets and Asian characters
    • Filed cview issue 27
    • The panicking was reported and fixed in Amfora issue 20, but the lines are now just not wrapped
  • Text background not reset on ANSI pages
  • Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
    • Filed issue 26
    • Add some bold back into modal text after this is fixed
  • Bookmark keys aren't deleted, just set to ""
  • Help table cells aren't dynamically wrapped