aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2024-06-19 19:25:24 +00:00
Code
tab-struct
amfora/NOTES.md
makeworld 4b8982723f 🚧 Fix bottomBar code 
Make sure it always resets to a selected link if one was selected before
2020-07-07 15:34:45 -04:00

1.3 KiB
Raw Permalink Blame History

Notes

  • URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL

Issues

  • Can't go back or do other things while page is loading - need a way to stop handleURL
  • Change renderer to start style tags on each new line of wrapped link, to prevent left margin from being highlighted

Upstream Bugs

  • Wrapping messes up on brackets
  • Wrapping panics on strings with brackets and Asian characters
    • Filed cview issue 27
    • The panicking was reported and fixed in Amfora issue 20, but the lines are now just not wrapped
  • Text background not reset on ANSI pages
  • Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
    • Filed issue 26
    • Add some bold back into modal text after this is fixed
  • Bookmark keys aren't deleted, just set to ""
  • Help table cells aren't dynamically wrapped