Commit Graph

11 Commits

Author SHA1 Message Date
Bharat Mediratta
c3c2b45280 Update the copyright to 2010. It's only 3 months into the year :-) 2010-03-03 10:15:34 -08:00
Andy Staudacher
6cbe0f78aa Revert "Fix Kohana's internal cache for Gallery's usage pattern."
This reverts commit 5ddd7c9677.
2010-02-21 21:07:55 -08:00
Andy Staudacher
5ddd7c9677 Fix Kohana's internal cache for Gallery's usage pattern.
Adds a core.internal_cache_read_only config variable to Kohana's internals.

Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run.
 1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
 2. Kohana::setup() loads find_file cache from disk.
 3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
 4. Request processing starts, and thus 80% of all Kohana::find_file() triggered  is_file() invocations start off with an empty find_file cache.

In the case of my small Gallery installation, we're talking about 3100 is_file() invocations per request with or without internal_cache enabled. With this fix, this number is down to 800 invocations.

The basic idea is that we treat the cache as read only and don't write any (possibly dirty) values to it in memory until we're sure that the include path won't change later on in the request processing. Once we know the list of active modules and themes, we can update core.modules and finally flip the read-only state of the cache and start writing to it.
2010-02-21 20:04:06 -08:00
Bharat Mediratta
f77b26e988 Add kohana23_compat module to bring along functionality that got
deleted, but we still want.  Start off with the Pagination library.
2009-11-26 14:38:01 -08:00
Bharat Mediratta
9b6663f87a Update to Kohana r4684 which is now Kohana 2.4 and has substantial
changes.
2009-11-24 19:20:36 -08:00
Bharat Mediratta
a5f1ef4849 Add support for mod_rewrite in the .htaccess file. There are now
instructions for how to tweak RewriteBase correctly.  Once that's
done, index.php will automagically disappear.  \o/
2009-06-24 21:47:47 -07:00
Bharat Mediratta
47810c9aec Try again to properly detect the base url, taking into account the
sites that mangle SCRIPT_NAME
2009-06-08 23:02:16 -07:00
Bharat Mediratta
b6a0bdb802 Use ORIG_SCRIPT_PATH if it's available to detect the base url, for
compatibility with the CGI sapi.
2009-06-05 11:45:18 -07:00
Bharat Mediratta
1848390897 Convert single quotes to double quotes 2009-05-31 00:10:12 -07:00
Bharat Mediratta
7fd6fcaf9b Force modules/gallery to be at the end of the module load path, so
that all other modules can override the core code.
2009-05-28 17:46:17 -07:00
Bharat Mediratta
28b41056e3 Restructure things so that the application is now just another module.
Kohana makes this type of transition fairly straightforward in that
all controllers/helpers/etc are still located in the cascading
filesystem without any extra effort, except that I've temporarily
added a hack to force modules/gallery into the module path.

Rename what's left of "core" to be "application" so that it conforms
more closely to the Kohana standard (basically, just
application/config/config.php which is the minimal thing that you need
in the application directory)

There's still considerable work left to be done here.
2009-05-27 15:07:27 -07:00