Commit Graph

111 Commits

Author SHA1 Message Date
Bharat Mediratta
99b7cdeee1 Fix a copy/paste typo. 2009-05-10 00:13:39 +00:00
Bharat Mediratta
d1a9138925 Don't try to use mb_detect_encoding if the module isn't loaded. Not sure if this is a great solution, but it'll probably cut down on a big class of errors opportunistically 2009-05-08 19:16:48 +00:00
Bharat Mediratta
13f8a0dd7b Detect input encodings from EXIF/IPTC data and convert to utf-8 as
appropriate.  This allows us to switch the exif value column back to
varchar and improves the way that we deal with non-utf8 data in our
embedded EXIF/IPTC data.
2009-05-05 03:30:49 +00:00
Bharat Mediratta
fde7073886 Strip trailing nulls off of some tags. 2009-04-05 04:08:24 +00:00
Bharat Mediratta
f7435112c5 Clean up JS/HTML so that renaming works properly (it had hardcoded
urls before).  Clean up indentation and localization code while I'm
in there.
2009-04-03 22:53:43 +00:00
Bharat Mediratta
921f3a2eee Put csrf token into Admin_View and Theme_View by default, then use it
directly wherever possible instead of access::csrf_token().
2009-03-27 03:43:21 +00:00
Jakob Hilden
b909132f54 tag changes in the tag admin should now work as expected 2009-03-25 04:47:25 +00:00
Bharat Mediratta
7cf0313e7b Remove the in-place tag editing code from the default theme. It
should be implemented in the tags module for now, and then possibly
generalized out to lib later on.
2009-03-17 20:59:24 +00:00
Bharat Mediratta
c81ee12411 Don't allow empty tag names 2009-03-17 20:57:51 +00:00
Bharat Mediratta
8786ee3ffb Initialize $tags properly 2009-03-17 05:25:38 +00:00
Bharat Mediratta
2dba075e8a Fix typo: tag_block -> tag_theme
Overlooked when I renamed this class.
2009-03-17 00:37:39 +00:00
Bharat Mediratta
6a2e8ec1cc Set $item and $tag in the Theme_View so that calls like $theme->item()
which fall through to calling &View::__get() have an lvalue to return,
else you can't return them by reference.

Also, don't show sidebar blocks for pages that don't have an item so
that the rss and tag modules don't break the search page.
2009-03-16 11:17:27 +00:00
Chad Kieffer
c377ffc2a5 Ticket #97. Applied button css where missing. Minor form css improvements. 2009-03-16 05:50:05 +00:00
Tim Almdal
85f2c6b666 Move the setting of the page title into the controller that is
creating the page.  Provide for a default page title if none is
set. This allows less changes to page.html.php as different modules
want to change the page title.
2009-03-12 16:06:13 +00:00
Tim Almdal
b82b60c91a Rename tag.html.php to dynamic.html.php as part of ticket #115
creating Dynamic Albums.  This name change reflects the usage better
and allows multiple dynamic albums (including tags) to use the same
page template.
2009-03-12 15:40:08 +00:00
Tim Almdal
c04ff8e02f Change the pattern to identify tables that need prefix substitution to
mirror the drupal pattern of using braces {}.
2009-02-28 06:37:28 +00:00
Tim Almdal
ad56995baf Correct a type and missed a table name 2009-02-28 03:34:03 +00:00
Tim Almdal
bd15853708 This implements table prefix for all the queries in core, user, exif,
tag, search, comment and notification modules (Ticket #68)
2009-02-27 21:07:18 +00:00
Tim Almdal
2b1f68a654 Continue the journey of replacing raw sql with ORM or Database method
calls (Ticket #68)
2009-02-27 00:19:12 +00:00
Bharat Mediratta
df7b05b40e Move tag CSS into admin theme's screen.css
Use JS to add titles to avoid repeating the same text 10s of times.
2009-02-26 03:38:56 +00:00
Andy Staudacher
e031957354 File structure style fixes 2009-02-24 05:54:19 +00:00
Bharat Mediratta
0e3df4e5d2 Fix pluralized text. 2009-02-15 08:12:48 +00:00
Jakob Hilden
b00bad39e6 improvements on the tag admin 2009-02-11 04:38:02 +00:00
Bharat Mediratta
11226bdd3a Simplify delete into guaranteed 3 queries. 2009-02-10 04:34:34 +00:00
Bharat Mediratta
9f4fdcd8d5 Just reset the tag form after submission; no need to replace it with one from the backend because it's going to be the same form anyway. 2009-02-09 00:30:13 +00:00
Bharat Mediratta
faa12ad17d clean up indentation 2009-02-05 07:59:13 +00:00
Jakob Hilden
5b17619ea8 added inplace edit to tag admin (form still needs to be set to rename using AJAX)
removed unnecessary {element: dialogLinks[i]} from dialog and panelLink handling.  now uses event.currentTarget
2009-02-04 07:14:22 +00:00
Tim Almdal
f97dedf3e4 Fix for Trac Ticket #30 2009-02-02 16:37:09 +00:00
Tim Almdal
7ef2dae070 There doesn't seem to be a photo_created event anymore so change it to
item_created and check for a type of photo before trying to extract tags.
2009-01-31 17:38:20 +00:00
Tim Almdal
38cf6ca403 The start of the notification module. At this point, the icon has been added to the item menu in the sidebar (both photo and album). There is a corresponding icon in themes/default/images that needs to be spruced up. You can add and remove notifications to albums and photos, but nothing happens under the covers for event handling. 2009-01-30 20:52:25 +00:00
Tim Almdal
a8233ed979 Undo the adding underscores to the id on forge generated forms 2009-01-25 06:28:04 +00:00
Chad Kieffer
55cd2afde5 Admin theme style cleanup. Merged separate selected, available, unavailable into a single set of reusable classes. Applied alternating row bg colors. Removed inline CSS from admin views. Moved user admin css into admin_default theme style sheet. 2009-01-24 20:06:13 +00:00
Tim Almdal
cbff78daa8 Supply a form id on all forms. This id can be used by modules other
than the originating module to provide additional functionality to the form.
2009-01-24 17:26:47 +00:00
Bharat Mediratta
3d1ea2904d Rename theme callback helpers from xxx_block to xxx_theme to make room
for us to rename the dashboard helper to be a block helper since
sidebar blocks are not just in the dashboard.
2009-01-18 05:01:00 +00:00
Andy Staudacher
e4a9b19bf9 Changing t() placeholder syntax from {{replace_me}} to %replace_me. 2009-01-15 10:02:41 +00:00
Bharat Mediratta
f3ba69c1d6 Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php
2009-01-14 04:12:02 +00:00
Bharat Mediratta
bc421a615a Implement deleting dashboard blocks.
* Refactor blocks so that they have a separate id vs css_id.  This way
  we can have a unique identifier for each visual block.

* Store blocks with a random id as their unique identifier

* Add Admin_Dashboard::remove_block() and modify
  themes/admin_default/views/block.html.php to call it when you click the
  remove box.
2009-01-12 08:26:38 +00:00
Bharat Mediratta
ae73ef3d57 Updated for new Form_Submit API.
OLD:
  $form->submit("Foo")  -->  <input type="submit" value="Foo">

New:
  $form->submit("foo_button")->("Foo") --> <input type="submit" name="foo_button" value="Foo">

Mostly we don't care what the button is so we leave the name blank.
2009-01-12 07:50:04 +00:00
Andy Staudacher
a631fe29f3 i18n refactoring: Rename all _() (reserved by gettext) calls to t().
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
2009-01-08 17:13:06 +00:00
Bharat Mediratta
fa1ccbd86d Fix up all the various little forms to have submit buttons, fieldset legends, etc etc. 2009-01-06 09:22:29 +00:00
Bharat Mediratta
3381f1d01a Put up an error if you try to reuse an existing tag name 2009-01-04 22:58:18 +00:00
Bharat Mediratta
92ceef27da Allow renaming of tags using a modal dialog. Put up a confirmation
dialog for deleting tags.  Remove the 4 character restriction on tags
(it was getting ignored by the add form anyway since it was mistakenly
referred to as tag_name there).
2009-01-04 08:44:06 +00:00
Bharat Mediratta
2c27469412 Simple admin tags interface. 2009-01-04 01:55:59 +00:00
Bharat Mediratta
d36996fb14 Remove unnecessary comments. 2009-01-04 00:39:54 +00:00
Bharat Mediratta
cd1d023754 Change the preamble for views in two ways:
1) drop unnecessary semicolon
2) start with <?php for extra security in the case that the server itself doesn't
   have short_tags enabled (the app won't work, but we need to make sure that we're
   still secure)
2009-01-01 00:23:29 +00:00
Bharat Mediratta
f29aad03a6 Make some columns smaller so that multi-column keys don't exceed 1024
bytes on some systems.
2008-12-30 01:37:09 +00:00
Chad Kieffer
79e2c4bd47 Fixed indents 2008-12-30 01:21:09 +00:00
Bharat Mediratta
6ab195854d Remove rest::JSON content type; it's causing lots of problems and it doesn't directly help since text/html works just as well for our JSON communications 2008-12-29 22:41:53 +00:00
Bharat Mediratta
3c0be5156b url::site is implicit in Forge actions, don't specify it a 2nd time 2008-12-29 18:38:40 +00:00
Bharat Mediratta
fdc0f83024 Big round of normalization of the way that our controllers
communicate.  Almost all controllers now use JSON to speak to the
theme when we're dealing with form processing.  This means tht we only
send the form back and forth, but we use a JSON protocol to tell the
browser success/error status as well as the location of any newly
created resources, or where the browser should redirect the user.

Lots of small changes:
1) Admin -> Edit Profile is gone.  Instead I fixed the "Modify Profile" link
   in the top right corner to be a modal dialog

2) We use json_encode everywhere.  No more Atom/XML for now.  We can bring those
   back later, though.  For now there's a lot of code duplication but that'll be
   easy to clean up.

3) REST_Controller is no longer abstract.   All methods its subclasses should create
   throw exceptions, which means that subclasses don't have to implement stubs for
   those methods.

4) New pattern: helper method get_add_form calls take an Item_Model,
   not an id since we have to load the Item_Model in the controller
   anyway to check permissions.

5) User/Groups REST resources are separate from User/Group in the site
   admin.  They do different things, we should avoid confusing overlap.
2008-12-25 05:12:46 +00:00