stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-11 07:19:06 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,074 Commits 4 Branches 0 Tags
77ec06166320dee631bbffcf3d57b0e2debcb157
Commit Graph

297 Commits

Author SHA1 Message Date
Bharat Mediratta
8ee25157ec Fix a bug in the way that we calculate expiration dates for old 
comments by using Database_Expression.  Fixes ticket #1386.
 2010-09-18 14:29:52 -07:00
Bharat Mediratta
3e3098956c Convert the guest_url ORM validation failure back to the url form 
parameter and put in a message requiring a valid url.  Fixes ticket
 2010-09-16 14:19:28 -07:00
Bharat Mediratta
db75ac642a Use the title of the root album as the site title for all RSS feeds. 
Fixes ticket #1307.
 2010-09-04 13:40:39 -07:00
Bharat Mediratta
dc80cde379 Add "captcha_protect_form" event that the recaptcha module grabs and 
uses to add a captcha to the end of the first group in the form.  If
there are no groups, it adds the captcha at the end of the form.
Updated user_profile and comment forms to use it.
 2010-08-22 13:00:08 -07:00
Bharat Mediratta
b6a5014047 Fix a pagination bug. Fixes ticket #1280. 2010-08-09 00:29:28 -07:00
Bharat Mediratta
2dda8e22a7 Use the gallery helper date/time functions wherever we format date 
time for the browser.  Fixes ticket #1278.
 2010-08-08 16:54:31 -07:00
Bharat Mediratta
e5a1da71ed Convert tabs to spaces to fix File_Structure_Test. 2010-08-08 15:05:55 -07:00
Bharat Mediratta
7607e1f932 Full pass over all the JSON encoding and JS dialog code. We now abide 
by the following rules:

1) An initial dialog or panel load can take either HTML or JSON, but
   the mime type must accurately reflect its payload.

2) dialog form submits can handle a pure HTML response, but the mime
   type must also be correct.  This properly resolves the problem
   where the reauth code gets a JSON response first from the reauth
   code, and then an HTML response when you reauth and continue on to
   a given form -- try it out with Admin > Settings > Advanced.

3) All JSON replies must set the mime type correctly.  The json::reply
   convenience function does this for us.

4) By default, any HTML content sent back in the JSON response should be
   in the "html" field, no longer the "form" field.

The combination of these allows us to stop doing boilerplate code like
this in our controllers:

  // Print our view, JSON encoded
  json::reply(array("form" => (string) $view));

instead, controllers can just return HTML, eg:

  // Print our view
  print $view;

That's much more intuitive for developers.
 2010-07-31 21:16:17 -07:00
Tim Almdal
91a2c04a24 More patches as part of #1225. Change the 'core' modules to use the json::reply 
method to set the content type header and encode the response as a json object
 2010-07-31 15:44:55 -07:00
Bharat Mediratta
74e821b03e Rename the feed variable from "children" to "comments" since that 
makes more semantic sense.
 2010-06-20 17:21:25 -07:00
Bharat Mediratta
7938a57dbe Oops. Remove debug line. 2010-06-20 10:57:48 -07:00
Bharat Mediratta
7500273228 Simplify the descendent logic. viewable() already joins with the 
items table so there's no need for a subquery.  The subquery could
generate way too many ids since it didn't pay attention to
permissions.  This isn't a security problem since we were restricting
the item ids according to permissions in the outer query, but it's
wasteful.
 2010-06-20 10:55:10 -07:00
Bharat Mediratta
f0a99ffc27 Undo "else" clause -- we should keep the logic simple and easy to 
follow, even if it's redundant.

Expand a <ul> to multiple lines.
 2010-06-18 14:31:04 -07:00
Tim Almdal
70f56ba43a Fix for ticket #1163. Don't all guests to a comment when there are no comments and the comment access permission is register users. 2010-06-17 14:22:35 -07:00
Bharat Mediratta
a27189ce9f Remove comment_rest::post() -- that's in comments_rest now. 2010-06-16 20:02:52 -07:00
Bharat Mediratta
1aeaa7daab Add REST support for comments. You can view, add, edit and delete 
comments.
 2010-06-16 18:05:15 -07:00
Tim Almdal
8ee60e6b5d slap my wrist... i forgot a debugging statement 2010-06-16 11:17:18 -07:00
Tim Almdal
ea8653f947 Fix for ticket #1131. If the rss feed is for an item, then retrieve the item. Using the left and right pointers find all the comments for the child items. Thanks to jankoprowski for the initial investigation. 2010-06-16 08:39:09 -07:00
Bharat Mediratta
94ada2361d Fix a bug in the upgrader where we weren't bumping the version number 
during the upgrade path, so the 2nd stanza (version 2 to version 3) was never getting executed.
 2010-06-15 16:14:30 -07:00
Bharat Mediratta
87fde3f360 Create a UI under Admin > Settings > Comments where you can limit 
comments only to registered users.  It's simplistic, but is better
than adding a permission since generally this setting will be used
Gallery-wide.

Fixes ticket #1002
 2010-06-05 23:35:32 -07:00
Bharat Mediratta
ab204d2720 Rename the admin_comments view to admin_manage_comments to match the controller. 2010-05-16 23:01:57 -07:00
Bharat Mediratta
2157285d9b Rename admin/comments to admin/manage_comments to make room for 
admin/comments to be a settings page.
 2010-05-16 22:53:19 -07:00
Bharat Mediratta
ad0e7254eb Require a well-formed email address for all comments. 2010-05-14 16:19:53 -07:00
ckieffer
f1076590f1 Add page_title to admin views. Closes #1038. 2010-04-30 00:08:37 -06:00
Chad Kieffer
39818dd29f Comment updates. Add empty <li> to empty <ul> for HTML validation, fixes #1066. Minor CSS/JS fixes. Add scrollTo effect when clicking on 'Add a Comment'. 2010-04-21 22:36:52 -06:00
Bharat Mediratta
c3c2b45280 Update the copyright to 2010. It's only 3 months into the year :-) 2010-03-03 10:15:34 -08:00
Bharat Mediratta
d4423eb349 Reset the active user to admin in all test cases where we change the 
user to something else.
 2010-02-23 13:50:57 -08:00
Chad Kieffer
b103306f3d Don't need 'right' class here. Positioning is absolute to the right. 2010-02-18 19:26:07 -07:00
Andy Staudacher
64e5d438c7 HTML validation, avoid empty <ul> 2010-02-14 07:15:58 -08:00
Bharat Mediratta
c050acf30a Fix lots of warnings that pop up when we're in E_STRICT mode. They're 
mostly issues around uninitialized variables, calling non-static
functions in a static context, calling Session functions directly
instead of on its singleton, passing non-variables by reference, and
subclasses not using the same interface as the parent class.
 2010-01-31 16:07:41 -08:00
Tim Almdal
c4e3604315 Strongly type the argument list to the model::validate method. 2010-01-29 14:04:27 -08:00
Tim Almdal
f943a2deef Don't show a link to the user profile for the guest user 2010-01-28 08:14:33 -08:00
Bharat Mediratta
bbe70119ef Localize validation messages. 2010-01-27 23:05:57 -08:00
Bharat Mediratta
31e4c21719 Localize error messages. 2010-01-27 23:03:47 -08:00
Bharat Mediratta
4b32a71afc Convert back to using ORM::factory(..., $id) instead of calling where(). 2010-01-27 22:34:11 -08:00
Bharat Mediratta
1606961153 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 
Conflicts:
	modules/gallery/libraries/MY_ORM.php
 2010-01-25 19:49:17 -08:00
Tim Almdal
7c06e21ec4 Refactor creating the user profile page content into the the event module. The show_user_profile is used to provide content to the user profile page. Add the list of the users comments to the profile page. 2010-01-24 15:27:33 -08:00
Tim Almdal
ed5b07b335 Create a user profile page that is used as a landing page when referencing a user in messages or pages. 
Partial fix for ticket #889 and a fix for #931.
 2010-01-23 21:38:01 -08:00
Bharat Mediratta
fecac4a859 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 
Conflicts:
	modules/gallery/tests/xss_data.txt
 2010-01-23 16:29:10 -08:00
Tim Almdal
603c3049a1 Treat identity providers just like other modules and use the admin_module to 
install and switch to a different identity provider.
 2010-01-22 09:39:29 -08:00
Bharat Mediratta
6dc88be6b6 Stop using MY_ORM::original(). 2010-01-20 22:50:47 -08:00
Bharat Mediratta
76da85a1a0 Extend Gallery_Unit_Test_Case instead of Unit_Test_Case. 2010-01-19 22:38:19 -08:00
Bharat Mediratta
c5f9a466c8 Updated for model based validation. 2010-01-17 19:33:44 -08:00
Bharat Mediratta
c5c17eecc3 Updated for model based validation. 2010-01-17 19:32:05 -08:00
Bharat Mediratta
c863544ec3 Add validation for guest_email and guest_url. 2010-01-17 19:31:49 -08:00
Bharat Mediratta
f68862f4c9 Updated for model based validation. 2010-01-17 19:26:32 -08:00
Bharat Mediratta
3789b85b7d Move rules down into validate() and improve valid_author(). 2010-01-17 12:19:24 -08:00
Bharat Mediratta
1c85cf6397 Convert comment code over to model based validation. 2010-01-16 22:27:07 -08:00
Bharat Mediratta
dcf4b5e71a Don't pass MY_ORM::original() to update event handlers, since after 
parent::save() it'll be reset.  Clone it first.

This is an alternate fix for #978.
 2010-01-16 00:13:28 -08:00
Tim Almdal
a11bf29507 Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where 
clauses and deletes all the entries in the table unless an array of id's are
passed as the parameter.  This fix used the Database_builder to specify any where
conditions. Thanks psvo for find the first one. :-)
 2010-01-09 23:57:16 -08:00