Tim Almdal
57adefc5ba
Revert "Create theme::get_var(), theme::set_var() methods to set the options of the active site theme. Change all refrences to theme options to use these methods. Update the version number of Gallery to 20 and move any them related options to the be stored under the active theme."
...
This reverts commit 26114972c3 .
2009-11-19 11:44:01 -08:00
Tim Almdal
e1cc8a37b2
Revert "Use call_user_func instead of call_user_func_array as we don't need to pass the parameters by reference."
...
This reverts commit 75cc4962a2 .
2009-11-19 11:43:34 -08:00
Tim Almdal
75cc4962a2
Use call_user_func instead of call_user_func_array as we don't need to pass the parameters by reference.
2009-11-19 10:03:39 -08:00
Tim Almdal
26114972c3
Create theme::get_var(), theme::set_var() methods to set the options of the active site theme. Change all refrences to theme options to use these methods. Update the version number of Gallery to 20 and move any them related options to the be stored under the active theme.
2009-11-18 15:36:13 -08:00
Tim Almdal
1692ee1308
Currently Admin_Theme_Options controller assumes that all the themes will provide the same values. This change corrects that assumption and moves the management of the theme options, including creating the form and updating the theme options into the theme.
2009-11-18 14:37:49 -08:00
Tim Almdal
372f589f66
Merge branch 'master' into talmdal_dev
2009-11-18 12:44:16 -08:00
Bharat Mediratta
350f6b5876
Merge branch 'master' of git@github.com:gallery/gallery3
2009-11-18 11:26:34 -08:00
Bharat Mediratta
670312ff10
For album pagination, don't let the last_visible_position exceed the
...
total. Fixes ticket #903 .
2009-11-18 11:26:19 -08:00
Tim Almdal
fc41d09134
Revert "Simplify the maintenance of the xss golden file by having each module contibute its own golden file to a consolidated one. This will make it easier for -contrib modules or themes to be included in the xss security test w/o having to keep modifying a central golden file."
...
This reverts commit 4fe5801c88 .
2009-11-18 10:54:01 -08:00
Tim Almdal
4fe5801c88
Simplify the maintenance of the xss golden file by having each module contibute its own golden file to a consolidated one. This will make it easier for -contrib modules or themes to be included in the xss security test w/o having to keep modifying a central golden file.
2009-11-18 10:34:39 -08:00
Tim Almdal
3f600d46e4
Update the xss golden file so tests pass.
2009-11-18 08:53:35 -08:00
Tim Almdal
4d4e81ca26
Create a helper to load the theme information from theme.info
2009-11-18 08:38:11 -08:00
Chad Kieffer
3aa7a3fcda
Address RTL issues reported in ticket #869 . Placement of checkboxes and radio buttons and sidebar block management lists.
2009-11-17 22:32:25 -07:00
Bharat Mediratta
7c2c77f3c1
Merge branch 'master' of git@github.com:gallery/gallery3
2009-11-17 15:53:30 -08:00
Bharat Mediratta
b8e94302bd
Tweak load_themes() to match exactly "/admin" or the "/admin/" prefix,
...
but not just the "/admin" prefix because that breaks if you add an
image like "admin_photostream".
2009-11-17 15:36:02 -08:00
Chad Kieffer
401c9c21e1
White-space fix and quoting update.
2009-11-17 15:16:40 -07:00
Bharat Mediratta
1067e68292
Redesign the way that we consider page types to create buckets of page
...
types, and a subtype for specifics. Currently the top level bucket
collection, item, other
Here are the core subtypes so far:
collection: album, search, tag
item: movie, photo
other: login, reset, comment-fragment, comment
It's legal to create new page_subtypes whenever you want. Use the
appropriate page_type to get the coarse grain behavior that you want.
2009-11-17 14:04:45 -08:00
Tim Almdal
bf4c518bb5
Store the directory, files and translation cache in the gallery3 cache instead of trying to store it in the task. It is possible with lots of modules and lots of incoming translations to go beyond the 64K limit in the task context. Possible fix for #886 .
2009-11-16 14:25:25 -08:00
Tim Almdal
2e4d29e7dd
If an empty array is passed into set method, then make sure the tag value being stored in the database is null, not "Array"
2009-11-16 14:23:29 -08:00
Tim Almdal
14f1fc30b5
Use some hacky css to get the buttons alighned properly. Fixes ticket #880 .
2009-11-16 07:49:17 -08:00
Bharat Mediratta
9379308f91
Xss data update
2009-11-15 19:36:02 -08:00
Bharat Mediratta
e0f4e6500d
Use text::alternate() instead of hand-rolled even/odd code.
2009-11-15 19:34:44 -08:00
Bharat Mediratta
64ef86a8ee
Updated xss data.
2009-11-15 19:27:35 -08:00
Bharat Mediratta
731ff800cd
Use 'git ls-files' instead of glob() so that we only check files known
...
to Git. This means that local files which we choose to exclude from
git don't have to follow the same permission model.
2009-11-15 19:20:43 -08:00
Bharat Mediratta
5a27ce7e8f
Save/restore $_SERVER before/after tests to avoid contamination.
...
Fix albums/photos tests to make sure we're really getting the
HTTP_REFERER back.
2009-11-15 19:10:56 -08:00
Bharat Mediratta
d7b13ee167
Try to keep users from leaving the upgrade page, or running the
...
upgrade twice.
1) Disable the "Upgrade all" link once clicked
2) Put up a "upgrade in progress" link to show that there's something
happening.
Fixes ticket #837 .
2009-11-15 17:12:26 -08:00
Bharat Mediratta
3481c8b58f
Change "confirmation" to "dialog" in preparation for putting up a
...
"we're working, stay tuned" message.
2009-11-15 16:21:45 -08:00
Bharat Mediratta
9e5714aee8
Tweak upgrader html and css so that we set opacity properly for rows
...
that are done, and disable the upgrade link when there're no actions
to take.
2009-11-15 16:14:30 -08:00
Bharat Mediratta
6ec81006e7
Fix a bug where we were using <? ?> tags in css to figure out whether we
...
should gray out an element.
2009-11-15 16:02:39 -08:00
Bharat Mediratta
9df591c774
Close the confirmation box with a fade, instead of a slide.
2009-11-15 15:35:10 -08:00
Bharat Mediratta
5df00737c9
Fix a couple of errors in the refctored paginator code:
...
1) We weren't showing previous page links for albums when we should have
2) We needed to wrap the results of url::merge() in url::site() so that we
generate server-relative urls.
2009-11-15 15:24:49 -08:00
Bharat Mediratta
aa1ddba155
Oops. Fix a typo that the forced page_type to always be "tag"
2009-11-14 16:36:25 -08:00
Bharat Mediratta
cd8663b81d
Fix pagination so that it does not require any domain specific logic
...
to support tags and search. Instead, just modify the page param to
the current page.
2009-11-14 16:31:56 -08:00
Bharat Mediratta
29efb6ba9f
Rename "pager" to "paginator" so that we differentiate page.html.php
...
from paginator.html.php
2009-11-14 16:20:36 -08:00
Bharat Mediratta
081ce9f6ca
Normalize pagination so that pager.html.php can handle pagination for
...
both albums and movies. Kohana's paginator is not quite sufficient
for this, so create our own pagination logic in Theme_View with only
the stuff we need.
Clearly document the variables available in pager.html so that themers
know how to use it.
Fixes ticket #626 .
2009-11-14 14:25:39 -08:00
Bharat Mediratta
100a66d861
Fix a bunch of little issues in the version 16, 17, and 18 upgraders.
...
- Add a missing loop in 15->16 causing ticket #881
- Comment the blocks correctly
- Remove unnecessary loop from 18->19
2009-11-14 12:03:41 -08:00
Tim Almdal
670629fe10
In order for us to provide a button that is style the way we want it to, we need to make the object transparent and hide its button, then our styling shows through. But what worked the other day no longer works, so until thumb gets a chance to look at the style so the buttons line up, we will just go with the default button so it works.
2009-11-13 14:30:38 -08:00
Tim Almdal
0fe32a61f6
Standardize the name of the blocks.
2009-11-13 13:56:05 -08:00
Tim Almdal
def88149cc
Undo using the md5 hash of the module name and block_id, so duplicate blocks are no allowed again
2009-11-13 09:14:39 -08:00
Tim Almdal
a5a8cfd1bc
Re-generate the install.sql so that the keys of the block lists are an md5 hash of the module_name:block_id. Also change the packager so we delete the _cache variable for the module gallery not core.
2009-11-12 13:14:02 -08:00
Tim Almdal
79f700ef9f
Change the keys of the block arrays in block manager to be a md5 hash of module_name:block_id. This allows easier lookup of blocks to remove when modules
...
are being deactivated. Change the module activation/deactivation to call (activate|deactivate)_blocks instead of just the sidebar blocks. This insures
that when a module is deactivated any admin dashboard blocks are removed as well the site sideboard blocks. Fix for ticket #876 .
2009-11-12 13:13:34 -08:00
Tim Almdal
8f975636d6
Add some padding to the add photo's button so when the focus goes on the flash object, it lines up with the button.
2009-11-11 20:30:57 -08:00
Tim Almdal
031d9aba5e
Make the browse button look more like the current one.
2009-11-11 20:21:40 -08:00
Tim Almdal
421a975c0e
Improve error handling.
2009-11-11 18:47:10 -08:00
Tim Almdal
9546e19e34
Pass two of uploadify... remove the default.css file, removed the folder option and create a status area where succesful uploads are listed.
2009-11-10 12:49:13 -08:00
Tim Almdal
d8beb6f530
First cut at replacing swfupload with uploadify. Probably need to review the css and remove extra swfupload selectors. Also changed the dialog so tags can be entered for all the files being uploaded. Probably need to add better start processing so the batch is started before the first image is loaded. Maybe add a module variable so the number of simultaneous uploads can be initiated (currently hard ocded to 10.
2009-11-09 13:54:55 -08:00
Tim Almdal
26f8240e34
Revert "Try an new approach to extending forms. Create an extend_form event. For the first attempt replace the comment_add_form and item_add_form events."
...
This reverts commit 809e738536 .
2009-11-09 11:52:43 -08:00
Tim Almdal
0dbf0d5173
Merge branch 'master' into talmdal_dev
2009-11-09 06:50:19 -08:00
Bharat Mediratta
d349400531
Fix an accidental old use of $photo in the extension renaming code.
2009-11-08 14:02:09 -08:00
Chad Kieffer
9fe328ba1c
Merge branch 'master' of github.com:gallery/gallery3
2009-11-08 09:01:01 -07:00