1
0
mirror of https://github.com/v2fly/v2ray-core.git synced 2024-06-30 02:55:23 +00:00

prevent empty read in Reader

This commit is contained in:
Darien Raymond 2018-03-29 10:40:18 +02:00
parent fc7da93d06
commit babd0107cf
No known key found for this signature in database
GPG Key ID: 7251FFA14BB18169

View File

@ -23,6 +23,7 @@ const xlSize = 128 * 1024
func (r *BytesToBufferReader) readSmall() (MultiBuffer, error) {
b := New()
for {
err := b.Reset(ReadFrom(r.Reader))
if b.IsFull() {
r.buffer = newBytes(Size + 1)
@ -30,8 +31,11 @@ func (r *BytesToBufferReader) readSmall() (MultiBuffer, error) {
if !b.IsEmpty() {
return NewMultiBufferValue(b), nil
}
if err != nil {
b.Release()
return nil, err
}
}
}
// ReadMultiBuffer implements Reader.
@ -40,6 +44,7 @@ func (r *BytesToBufferReader) ReadMultiBuffer() (MultiBuffer, error) {
return r.readSmall()
}
for {
nBytes, err := r.Reader.Read(r.buffer)
if nBytes > 0 {
mb := NewMultiBufferCap(nBytes/Size + 1)
@ -53,9 +58,12 @@ func (r *BytesToBufferReader) ReadMultiBuffer() (MultiBuffer, error) {
}
return mb, nil
}
if err != nil {
freeBytes(r.buffer)
r.buffer = nil
return nil, err
}
}
}
// BufferedReader is a Reader that keeps its internal buffer.