Commit Graph

226 Commits

Author SHA1 Message Date
Tobias Stoeckmann
35295f1902 On success, fgets always terminates the result.
If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2017-04-04 21:27:31 +02:00
Tobias Stoeckmann
b1e7c40b21 Fixed out of boundary write on long lines.
The terminating nul character ('\0') could be written outside the boundary of
the buffer which is used to read characters. If "sizeof(buffer)" characters
are read, the resulting value must not be used as index, because that's an off
by one.

Read sizeof(buffer)-1 bytes instead.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2017-04-02 13:12:03 +02:00
Aaron Marcher
cceeec0efa
loading thresholds state 2017-03-30 17:32:20 +02:00
Aaron Marcher
b11dd2db0e
Fixed XCloseDisplay() which is not reached in keyboard_indicators() 2017-01-23 21:01:41 +01:00
Aaron Marcher
823f2d047f
Added keyboard_indicators (Fixes #31) 2017-01-16 12:10:56 +01:00
Aaron Marcher
3f976aabc0
Makefile fix and vol_perc fix for mute 2017-01-09 12:05:29 +01:00
Aaron Marcher
0d1f19d777
removed ./extern/ 2017-01-07 22:33:28 +01:00
Aaron Marcher
688e2e783d
removed strlcat dependency (was used only once) 2017-01-07 22:31:46 +01:00
Aaron Marcher
32bb92453a
got rid of concat.h 2017-01-07 22:01:49 +01:00
Aaron Marcher
3847911771
happy new year! 2017-01-07 21:28:22 +01:00
Aaron Marcher
8a29374783
run_command: strlen() will not function if string is not null terminated 2017-01-07 21:19:40 +01:00
Aaron Marcher
965a71d678
consistent coding style: usage() declaration, eval is a constant 2016-12-30 23:13:21 +01:00
parazyd
13604963bc Merge branch 'master' into master 2016-12-30 14:21:19 +01:00
parazyd
62f4016430
add vol_perc notes, add braces to singleline statements 2016-12-30 12:16:07 +01:00
Aaron Marcher
8fa6229759
why releases for such a small project? useless and overhead! 2016-12-29 23:36:05 +01:00
Aaron Marcher
b68925dbef
#undef strlcpy not needed anymore 2016-12-29 23:30:53 +01:00
Aaron Marcher
015f832c3a Merge branch 'master' into master 2016-12-29 23:27:44 +01:00
raiz
b231cd90eb add braces to single statements so drkhsh doesn't be upset 2016-12-29 12:40:43 +03:00
Aaron Marcher
7392dbabeb
kernel_release() coding style and position in code fix 2016-12-28 23:59:19 +01:00
parazyd
c2808b6d99
refactor vol_perc to not depend on alsa libraries 2016-12-28 00:41:51 +01:00
raiz
cfb4a5d3ff usage(): return success if -h is called && print more appropriate usage, opts can't be all called at the same time, that's why a separator is required 2016-12-27 20:41:40 +03:00
raiz
e9f738b8b6 whhops, my bad 2016-12-27 20:18:09 +03:00
raiz
94e87eb8ba wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf() 2016-12-27 20:14:45 +03:00
raiz
11fec4fa95 don't allow the use of perc if uninitialized 2016-12-27 20:09:07 +03:00
raiz
8b5b72b65e remove misleading comment 2016-12-27 19:57:16 +03:00
raiz
13772c3979 get rid of set_status() since it's only used once 2016-12-27 19:56:11 +03:00
raiz
3c8717f4e0 allow the use of %* symbols in UNKNOWN_STR 2016-12-27 19:53:46 +03:00
raiz
7db4f5cf67 add extra error tests to swap_*() && fix bytes_read bug 2016-12-27 19:49:31 +03:00
raiz
a36cb96f27 swap_*(): add more error tests 2016-12-27 19:26:04 +03:00
raiz
862d158b7c fix delay in a cleaner way 2016-12-27 19:12:39 +03:00
raiz
6cab2d5719 remove newlines from warn() in swap_*(), those functions already print a newline after printing string stderr 2016-12-27 19:07:19 +03:00
raiz
e1c5476291 inititalize run_command()'s buf to UNKNOWN_STR by default 2016-12-27 18:58:31 +03:00
raiz
b7f4541506 remove newline character from run_command() output accurately 2016-12-27 18:57:27 +03:00
raiz
3bfc3bbcae strtok() has no effect on buf && fgets() should have the full buffer length 2016-12-27 18:54:16 +03:00
raiz
f62d626d9b whhops 2016-12-18 10:36:01 +03:00
raiz
5a218e990c remove unused strlcpy() and reduce the size of output buffer 2016-12-18 10:35:36 +03:00
Mike Coddington
c3eb0c4012 Add "uname -r" functionality 2016-11-16 13:03:15 -06:00
Jody Leonard
9bef4e889a swap: Print UNKNOWN_STR if no swap is allocated 2016-10-15 19:51:19 -04:00
Jody Leonard
c60af317f3 Add functions for measuring swap 2016-10-15 05:48:46 -04:00
Jody Leonard
393b09644a vol_perc: Return "mute" when mixer is muted
This feature was originally removed as part of 52d19f9.
2016-10-13 03:20:36 -04:00
Aaron Marcher
e1b89581d2
add setlocale() (mostly for datetime function) 2016-10-10 18:58:06 +02:00
Aaron Marcher
3971c1f47c
check daemon() return value 2016-10-10 18:52:46 +02:00
Aaron Marcher
6890a27a3a
fixed run_command() 2016-10-10 09:19:44 +02:00
Aaron Marcher
5a70f920f0
fixed run_command() 2016-10-10 09:02:24 +02:00
Aaron Marcher
cc1bb3a344
removed unnecessary fp, shorter return 0 and fixed compiler warning in vol_perc 2016-10-09 14:06:04 +02:00
Ali H. Fardan
4339c8330a hostname: use POSIX routine to get hostname rather than reading from procfs 2016-10-08 19:55:25 +03:00
user
fb440d8f62 vol_perc: return zero if the value of max is set to zero 2016-10-08 19:50:53 +03:00
Aaron Marcher
c5ace949e4 braces for one line statements in smprintf() 2016-09-18 22:01:44 +02:00
Aaron Marcher
bad8dc682d shorter copyright notice and moved back VERSION and _GNU_SOURCE as the man page version number fails 2016-09-18 22:00:50 +02:00
Ali H. Fardan
f4a383382c several changes 2016-09-18 22:27:04 +03:00
Aaron Marcher
0fe8e5a961 suckless coding style -> added back function prototypes argument variable names 2016-09-18 17:26:01 +02:00
Aaron Marcher
14749b6c87 added -v command line option 2016-09-18 17:03:53 +02:00
Aaron Marcher
dcc0cddee4 simpler usage 2016-09-18 16:57:55 +02:00
Aaron Marcher
db07244cb8 do not exit on failed smprintf 2016-09-18 16:54:46 +02:00
Aaron Marcher
9477f3b1d1 n/a for run_command() 2016-09-17 18:16:27 +02:00
Aaron Marcher
c8926634be fuck newlines 2016-09-17 18:10:26 +02:00
Aaron Marcher
37959ca569 moved headers to extern 2016-09-17 18:07:03 +02:00
Aaron Marcher
d73118eaa4 shorter names 2016-09-17 17:06:06 +02:00
Aaron Marcher
2e012d533e only open and close display if output type is dwm 2016-09-17 16:53:45 +02:00
Aaron Marcher
4dcba6b7e8 coding style fixes + better var names 2016-09-17 16:51:21 +02:00
Aaron Marcher
87eae6db03 added daemonization, output possibility to console (for other programs) and moved the code to set WM_NAME to its own function as it is needed two times 2016-09-16 23:31:24 +02:00
Aaron Marcher
887b9bd3e3 fixed run_command() 2016-09-14 18:42:51 +02:00
Ali H. Fardan
561de544e7 variable initialization is back 2016-09-14 17:42:48 +03:00
Ali H. Fardan
35f7862744 simplified run_command() 2016-09-14 16:20:20 +03:00
Ali H. Fardan
56fffbce64 improved hostname() 2016-09-14 12:22:03 +03:00
Aaron Marcher
1ad9f2504d hostname() null terminaiton subtraction *is* needed 2016-09-14 11:04:24 +02:00
Ali H. Fardan
bc38677f47 malloc sucks, you know? 2016-09-14 03:35:53 +03:00
Ali H. Fardan
f28e2682fd * != ** 2016-09-14 03:35:09 +03:00
Ali H. Fardan
3e04f1d910 minor improvements and memory leak fix 2016-09-14 03:31:01 +03:00
Ali H. Fardan
81e8da5d90 Merge branch 'master' of https://github.com/drkh5h/slstatus 2016-09-14 03:24:53 +03:00
Aaron Marcher
f13104156f battery_state() function added 2016-09-13 22:03:36 +02:00
Aaron Marcher
7aad78bd95 fixed vol_perc() typo and added % sign again 2016-09-13 21:11:11 +02:00
Aaron Marcher
87c1377b08 simplified vol_perc() (and with that config.def.h is super clean) 2016-09-13 21:08:44 +02:00
Aaron Marcher
74b6e340f2 lol, battery_perc() is even simpler, fuck this shit :D 2016-09-13 21:05:49 +02:00
Aaron Marcher
2d1bbf0d35 simplified battery_perc() a lot and removed useless options from config.def.h 2016-09-13 20:54:45 +02:00
Aaron Marcher
98e7324010 set old WM_NAME content before exiting 2016-09-13 19:34:25 +02:00
Aaron Marcher
ba2947ae45 sighandle forgot const 2016-09-13 19:21:54 +02:00
Aaron Marcher
67d3f9c540 signal handling to exit gracefully + small coding style fixes 2016-09-13 19:09:01 +02:00
Aaron Marcher
a1c962f8a3 simplify status_string clearing 2016-09-13 18:57:56 +02:00
Aaron Marcher
75b1853313 Fixes issue #15. Forgot to close() a socket in wifi_essid()... 2016-09-13 18:54:15 +02:00
Ali H. Fardan
e6158e300d subtraction is unneeded 2016-09-12 13:51:43 +03:00
Aaron Marcher
d19d4aa2e8 coding style (global variables) 2016-09-12 12:12:11 +02:00
Aaron Marcher
c0647e946f Merge pull request #14 from R41z/master
cpu_perc() workaround
2016-09-12 11:47:48 +02:00
Aaron Marcher
d5fb46e61d fixed wifi_perc() typo 2016-09-12 11:28:54 +02:00
Ali H. Fardan
6cb5af2bd7 fixed (hopefully) the vol_perc() function 2016-09-11 13:57:04 +03:00
Ali H. Fardan
6d23d53d1f fixed cpu_perc() stupidity && added some useful comment for drkh5h 2016-09-11 13:33:35 +03:00
Aaron Marcher
217da011dd brought back update interval 2016-09-09 19:26:06 +02:00
Aaron Marcher
81997b327c removed more unneeded comments 2016-09-09 19:21:26 +02:00
Aaron Marcher
545f1560e6 fixed username function (wtf happened here?) 2016-09-09 19:19:46 +02:00
Aaron Marcher
98f3985d3e fixed run_command behaviour for emtpy command output (uninitialized) 2016-09-09 19:18:14 +02:00
Aaron Marcher
3bfa5fe60d coding style fixes 2016-09-09 19:15:43 +02:00
Ali H. Fardan
9b2dc25348 use warn[x]() instead of long fprintf()s 2016-09-08 04:45:00 +03:00
Ali H. Fardan
2afea97987 used ccat() from concat.h for string concatenation 2016-09-08 04:31:49 +03:00
Ali H. Fardan
113979e5b8 fixed some mistakes 2016-09-05 02:28:18 +03:00
Ali H. Fardan
720328cef9 what kind of weed is that? 2016-09-05 02:17:30 +03:00
Ali H. Fardan
a4beda8eb9 bringed back the loop 2016-09-05 01:21:03 +03:00
Ali H. Fardan
52d19f955e imported a new vol_perc() function, this should fix #12 (UNTESTED) 2016-09-05 01:18:55 +03:00
Ali H. Fardan
9fa858daea added a tool for resetting the status bar && worked around some issues && removed the makefile (we need a better one) 2016-09-05 01:13:48 +03:00
Ali H. Fardan
d3d8b8ee03 added daemonization support 2016-09-04 00:10:49 +03:00
Ali H. Fardan
de4f20ace3 removed UPDATE_INTERVAL, it is neat to have it but removing it is a tradeoff worth making, because the clock would act weird if this used to work with cpu_perc(). 2016-09-03 21:43:05 +03:00