70ffd39562
QA findings from a multi-round review of the FreeDOS submission prep work:
- TUI rendering refactor: src/tui.c emitted ANSI escape sequences via
printf, which displays as raw text on bare FreeDOS (no ANSI.SYS).
Add four HAL ops (tui_enter, tui_leave, render_run, set_cursor_shape)
and route per-cell rendering through them. POSIX backend keeps the
ANSI path; DOS backend drives BIOS INT 10h via the existing
bios_set_cursor / bios_write_char helpers. The TUI's logical cursor
goes through the saved orig_locate to avoid recursing through the
swapped-in gw_hal->locate.
- DOS extended-key mapping: dos_getch returns 0x100 | scancode for
arrows / F-keys; tui_read_key wasn't translating those to its TK_*
constants, so the editor never saw arrow keys or F1-F10 on DOS.
Add a __MSDOS__-conditional translation table in tui_read_key.
- Version banner: GW_VERSION was still 0.16.0 even though the v0.17.0
release prep was already in CHANGES.TXT. Bump.
- Compiler PulseAudio link: gwbasic-compile -c hardcoded
'-lgwrt -lm -lpthread' on the gcc command line. When libgwrt was
built against libpulse-simple (the default on any host with the
PulseAudio dev headers installed), the compile workflow failed with
'undefined reference to pa_simple_drain'. CMake now passes
GWRT_HAS_PULSEAUDIO to gwbasic-compile when libpulse is present, and
the compiler appends -lpulse-simple to the link line.
- FRE("") garbage collection: the interpreter skipped strpool_gc with a
comment 'unsafe during expression eval', but that's exactly what real
GW-BASIC's FRE("") does (and the AOT compiler path already did). Add
the GC call; strpool_pin/unpin is the existing escape hatch if a
caller has live pool pointers on the C stack. Fixes the string_gc
compat test.
- Test harness normalization: run_tests.sh stripped trailing whitespace
on the actual output but not the expected file, causing spurious
mismatches against golden files captured from real GWBASIC.EXE.
Normalize both sides identically. Fixes the peek_gfx mismatch.
- Print_using: snprintf into mantissa[32] with %.*f and an unbounded
dec triggered a -Wformat-truncation warning. Clamp dec to 20 (IEEE
double has at most ~17 significant decimal digits).
- Doc/version consistency: 16-bit binary size reported as 127KB in one
place and 128KB in three; standardize on 128KB. HAL backend count
said '1 file' but is now 2. CI test count said 'all 66 test
programs' but is 72. Add a v0.17.0 row to the development.md table.
Update getting-started.md DOS section to match the BIOS-rendering
reality and add a manual TUI verification checklist.
- dos_init now writes back BIOS-reported cols/rows to dos_hal struct
fields (forward-declared so dos_init can reference it).
After these changes: 72/72 interpreter tests pass, compat 68/68
matched, no warnings on the Linux build.
66 lines
2.1 KiB
Bash
Executable File
66 lines
2.1 KiB
Bash
Executable File
#!/bin/bash
|
|
# Run all .bas test programs and report results.
|
|
# If .expected files exist, also compare output against them.
|
|
set -u
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
PROJECT_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
|
|
GWBASIC="${PROJECT_DIR}/build/gwbasic"
|
|
EXPECTED_DIR="${SCRIPT_DIR}/expected"
|
|
|
|
if [ ! -x "$GWBASIC" ]; then
|
|
echo "ERROR: gwbasic not found at $GWBASIC (run cmake/make first)"
|
|
exit 1
|
|
fi
|
|
|
|
pass=0
|
|
fail=0
|
|
compat_pass=0
|
|
compat_fail=0
|
|
|
|
for bas in "$SCRIPT_DIR"/programs/*.bas; do
|
|
name="$(basename "$bas")"
|
|
stem="${name%.bas}"
|
|
# chain/common targets are not standalone
|
|
[ "$name" = "chain_target.bas" ] && continue
|
|
[ "$name" = "common_target.bas" ] && continue
|
|
|
|
actual=$(mktemp)
|
|
if timeout 5 "$GWBASIC" "$bas" > "$actual" 2>&1; then
|
|
printf " PASS %s" "$name"
|
|
pass=$((pass + 1))
|
|
|
|
# Compare against .expected if available. Normalize both sides
|
|
# the same way (CR removal, trailing whitespace strip, blank-line drop)
|
|
# so trailing spaces in golden captures from real GWBASIC.EXE don't
|
|
# cause spurious mismatches.
|
|
expected="$EXPECTED_DIR/${stem}.expected"
|
|
if [ -f "$expected" ]; then
|
|
normalized=$(mktemp)
|
|
normalized_expected=$(mktemp)
|
|
sed 's/\r//g; s/[[:space:]]*$//' "$actual" | sed '/^$/d' > "$normalized"
|
|
sed 's/\r//g; s/[[:space:]]*$//' "$expected" | sed '/^$/d' > "$normalized_expected"
|
|
if diff -q "$normalized_expected" "$normalized" >/dev/null 2>&1; then
|
|
printf " [compat: ok]"
|
|
compat_pass=$((compat_pass + 1))
|
|
else
|
|
printf " [compat: MISMATCH]"
|
|
compat_fail=$((compat_fail + 1))
|
|
fi
|
|
rm -f "$normalized" "$normalized_expected"
|
|
fi
|
|
printf "\n"
|
|
else
|
|
printf " FAIL %s\n" "$name"
|
|
fail=$((fail + 1))
|
|
fi
|
|
rm -f "$actual"
|
|
done
|
|
|
|
echo ""
|
|
echo "$((pass + fail)) tests: $pass passed, $fail failed"
|
|
if [ "$((compat_pass + compat_fail))" -gt 0 ]; then
|
|
echo "Compat: $compat_pass matched, $compat_fail mismatched"
|
|
fi
|
|
[ "$fail" -eq 0 ] || exit 1
|