70ffd39562
QA findings from a multi-round review of the FreeDOS submission prep work:
- TUI rendering refactor: src/tui.c emitted ANSI escape sequences via
printf, which displays as raw text on bare FreeDOS (no ANSI.SYS).
Add four HAL ops (tui_enter, tui_leave, render_run, set_cursor_shape)
and route per-cell rendering through them. POSIX backend keeps the
ANSI path; DOS backend drives BIOS INT 10h via the existing
bios_set_cursor / bios_write_char helpers. The TUI's logical cursor
goes through the saved orig_locate to avoid recursing through the
swapped-in gw_hal->locate.
- DOS extended-key mapping: dos_getch returns 0x100 | scancode for
arrows / F-keys; tui_read_key wasn't translating those to its TK_*
constants, so the editor never saw arrow keys or F1-F10 on DOS.
Add a __MSDOS__-conditional translation table in tui_read_key.
- Version banner: GW_VERSION was still 0.16.0 even though the v0.17.0
release prep was already in CHANGES.TXT. Bump.
- Compiler PulseAudio link: gwbasic-compile -c hardcoded
'-lgwrt -lm -lpthread' on the gcc command line. When libgwrt was
built against libpulse-simple (the default on any host with the
PulseAudio dev headers installed), the compile workflow failed with
'undefined reference to pa_simple_drain'. CMake now passes
GWRT_HAS_PULSEAUDIO to gwbasic-compile when libpulse is present, and
the compiler appends -lpulse-simple to the link line.
- FRE("") garbage collection: the interpreter skipped strpool_gc with a
comment 'unsafe during expression eval', but that's exactly what real
GW-BASIC's FRE("") does (and the AOT compiler path already did). Add
the GC call; strpool_pin/unpin is the existing escape hatch if a
caller has live pool pointers on the C stack. Fixes the string_gc
compat test.
- Test harness normalization: run_tests.sh stripped trailing whitespace
on the actual output but not the expected file, causing spurious
mismatches against golden files captured from real GWBASIC.EXE.
Normalize both sides identically. Fixes the peek_gfx mismatch.
- Print_using: snprintf into mantissa[32] with %.*f and an unbounded
dec triggered a -Wformat-truncation warning. Clamp dec to 20 (IEEE
double has at most ~17 significant decimal digits).
- Doc/version consistency: 16-bit binary size reported as 127KB in one
place and 128KB in three; standardize on 128KB. HAL backend count
said '1 file' but is now 2. CI test count said 'all 66 test
programs' but is 72. Add a v0.17.0 row to the development.md table.
Update getting-started.md DOS section to match the BIOS-rendering
reality and add a manual TUI verification checklist.
- dos_init now writes back BIOS-reported cols/rows to dos_hal struct
fields (forward-declared so dos_init can reference it).
After these changes: 72/72 interpreter tests pass, compat 68/68
matched, no warnings on the Linux build.
55 lines
1.5 KiB
C
55 lines
1.5 KiB
C
#ifndef GW_HAL_H
|
|
#define GW_HAL_H
|
|
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
|
|
/* Hardware Abstraction Layer vtable */
|
|
typedef struct hal_ops {
|
|
/* Terminal I/O */
|
|
void (*putch)(int ch);
|
|
void (*puts)(const char *s);
|
|
int (*getch)(void); /* blocking read */
|
|
bool (*kbhit)(void); /* key available? */
|
|
void (*locate)(int row, int col);
|
|
int (*get_cursor_row)(void);
|
|
int (*get_cursor_col)(void);
|
|
void (*cls)(void);
|
|
void (*set_width)(int cols);
|
|
|
|
/* Raw mode for INKEY$/INPUT$ */
|
|
void (*enable_raw)(void);
|
|
void (*disable_raw)(void);
|
|
|
|
/* Write raw bytes bypassing cursor tracking (for Sixel, etc.) */
|
|
void (*write_raw)(const char *data, int len);
|
|
|
|
/* TUI rendering (used by src/tui.c). POSIX backend emits ANSI escape
|
|
* sequences; DOS backend drives the BIOS so the editor works on bare
|
|
* FreeDOS without ANSI.SYS. */
|
|
void (*tui_enter)(void);
|
|
void (*tui_leave)(void);
|
|
void (*render_run)(int row, int col,
|
|
const uint8_t *chars, const uint8_t *attrs, int len);
|
|
void (*set_cursor_shape)(int shape); /* 0=hide, 1=block, 2=line */
|
|
|
|
/* Terminal properties */
|
|
int screen_width;
|
|
int screen_height;
|
|
bool is_tty;
|
|
|
|
/* Lifecycle */
|
|
void (*init)(void);
|
|
void (*shutdown)(void);
|
|
} hal_ops_t;
|
|
|
|
extern hal_ops_t *gw_hal;
|
|
|
|
/* Platform implementations */
|
|
hal_ops_t *hal_posix_create(void);
|
|
#ifdef __MSDOS__
|
|
hal_ops_t *hal_dos_create(void);
|
|
#endif
|
|
|
|
#endif
|