70ffd39562
QA findings from a multi-round review of the FreeDOS submission prep work:
- TUI rendering refactor: src/tui.c emitted ANSI escape sequences via
printf, which displays as raw text on bare FreeDOS (no ANSI.SYS).
Add four HAL ops (tui_enter, tui_leave, render_run, set_cursor_shape)
and route per-cell rendering through them. POSIX backend keeps the
ANSI path; DOS backend drives BIOS INT 10h via the existing
bios_set_cursor / bios_write_char helpers. The TUI's logical cursor
goes through the saved orig_locate to avoid recursing through the
swapped-in gw_hal->locate.
- DOS extended-key mapping: dos_getch returns 0x100 | scancode for
arrows / F-keys; tui_read_key wasn't translating those to its TK_*
constants, so the editor never saw arrow keys or F1-F10 on DOS.
Add a __MSDOS__-conditional translation table in tui_read_key.
- Version banner: GW_VERSION was still 0.16.0 even though the v0.17.0
release prep was already in CHANGES.TXT. Bump.
- Compiler PulseAudio link: gwbasic-compile -c hardcoded
'-lgwrt -lm -lpthread' on the gcc command line. When libgwrt was
built against libpulse-simple (the default on any host with the
PulseAudio dev headers installed), the compile workflow failed with
'undefined reference to pa_simple_drain'. CMake now passes
GWRT_HAS_PULSEAUDIO to gwbasic-compile when libpulse is present, and
the compiler appends -lpulse-simple to the link line.
- FRE("") garbage collection: the interpreter skipped strpool_gc with a
comment 'unsafe during expression eval', but that's exactly what real
GW-BASIC's FRE("") does (and the AOT compiler path already did). Add
the GC call; strpool_pin/unpin is the existing escape hatch if a
caller has live pool pointers on the C stack. Fixes the string_gc
compat test.
- Test harness normalization: run_tests.sh stripped trailing whitespace
on the actual output but not the expected file, causing spurious
mismatches against golden files captured from real GWBASIC.EXE.
Normalize both sides identically. Fixes the peek_gfx mismatch.
- Print_using: snprintf into mantissa[32] with %.*f and an unbounded
dec triggered a -Wformat-truncation warning. Clamp dec to 20 (IEEE
double has at most ~17 significant decimal digits).
- Doc/version consistency: 16-bit binary size reported as 127KB in one
place and 128KB in three; standardize on 128KB. HAL backend count
said '1 file' but is now 2. CI test count said 'all 66 test
programs' but is 72. Add a v0.17.0 row to the development.md table.
Update getting-started.md DOS section to match the BIOS-rendering
reality and add a manual TUI verification checklist.
- dos_init now writes back BIOS-reported cols/rows to dos_hal struct
fields (forward-declared so dos_init can reference it).
After these changes: 72/72 interpreter tests pass, compat 68/68
matched, no warnings on the Linux build.
108 lines
2.4 KiB
CMake
108 lines
2.4 KiB
CMake
cmake_minimum_required(VERSION 3.10)
|
|
project(gw-basic-2026 C)
|
|
|
|
set(CMAKE_C_STANDARD 11)
|
|
set(CMAKE_C_STANDARD_REQUIRED ON)
|
|
|
|
# POSIX extensions (opendir, chdir, strcasecmp, etc.)
|
|
add_compile_definitions(_DEFAULT_SOURCE)
|
|
|
|
# Warnings
|
|
add_compile_options(-Wall -Wextra -Wno-unused-parameter)
|
|
|
|
# Include paths
|
|
include_directories(include)
|
|
|
|
# Optional PulseAudio support
|
|
include(FindPkgConfig)
|
|
pkg_check_modules(PULSEAUDIO libpulse-simple)
|
|
|
|
# Source files
|
|
set(SOURCES
|
|
src/main.c
|
|
src/tokens.c
|
|
src/tokenizer.c
|
|
src/error.c
|
|
src/eval.c
|
|
src/interp.c
|
|
src/vars.c
|
|
src/arrays.c
|
|
src/input.c
|
|
src/math_int.c
|
|
src/math_float.c
|
|
src/math_transcend.c
|
|
src/strings.c
|
|
src/print.c
|
|
src/fileio.c
|
|
src/program_io.c
|
|
src/print_using.c
|
|
src/graphics.c
|
|
src/virmem.c
|
|
src/portio.c
|
|
src/strpool.c
|
|
src/sound.c
|
|
src/tui.c
|
|
platform/hal_posix.c
|
|
)
|
|
|
|
add_executable(gwbasic ${SOURCES})
|
|
target_link_libraries(gwbasic m)
|
|
|
|
if(PULSEAUDIO_FOUND)
|
|
target_compile_definitions(gwbasic PRIVATE HAVE_PULSEAUDIO)
|
|
target_include_directories(gwbasic PRIVATE ${PULSEAUDIO_INCLUDE_DIRS})
|
|
target_link_libraries(gwbasic ${PULSEAUDIO_LIBRARIES} pthread)
|
|
endif()
|
|
|
|
# Runtime library for compiled BASIC programs
|
|
set(GWRT_SOURCES
|
|
src/tokens.c
|
|
src/tokenizer.c
|
|
src/error.c
|
|
src/eval.c
|
|
src/interp.c
|
|
src/vars.c
|
|
src/arrays.c
|
|
src/input.c
|
|
src/math_int.c
|
|
src/math_float.c
|
|
src/math_transcend.c
|
|
src/strings.c
|
|
src/print.c
|
|
src/fileio.c
|
|
src/program_io.c
|
|
src/print_using.c
|
|
src/graphics.c
|
|
src/virmem.c
|
|
src/portio.c
|
|
src/strpool.c
|
|
src/sound.c
|
|
src/tui.c
|
|
src/gwrt.c
|
|
platform/hal_posix.c
|
|
)
|
|
|
|
add_library(gwrt STATIC ${GWRT_SOURCES})
|
|
target_link_libraries(gwrt m)
|
|
if(PULSEAUDIO_FOUND)
|
|
target_compile_definitions(gwrt PRIVATE HAVE_PULSEAUDIO)
|
|
target_include_directories(gwrt PRIVATE ${PULSEAUDIO_INCLUDE_DIRS})
|
|
target_link_libraries(gwrt ${PULSEAUDIO_LIBRARIES} pthread)
|
|
endif()
|
|
|
|
# GW-BASIC compiler
|
|
add_executable(gwbasic-compile
|
|
src/compiler_main.c
|
|
src/analysis.c
|
|
src/codegen.c
|
|
src/tokens.c
|
|
src/tokenizer.c
|
|
)
|
|
target_link_libraries(gwbasic-compile m)
|
|
|
|
# Tell the compiler whether libgwrt was built against libpulse-simple, so
|
|
# `gwbasic-compile -c` knows to add -lpulse-simple to the gcc link line.
|
|
if(PULSEAUDIO_FOUND)
|
|
target_compile_definitions(gwbasic-compile PRIVATE GWRT_HAS_PULSEAUDIO)
|
|
endif()
|