openbsd-ports/misc/wordnet/Makefile
sthen f6c9102d1a updated patch from Rob Holland, his commentary:
"Andreas Tille, the Debian WordNet maintainer, noticed a bug in my
patch. The bug is not security related, but causes incorrect behaviour
in WordNet.

I replaced a strncpy(s1, s2, strlen(s2)) with a strcpy forgetting that
strncpy invoked that way would always omit the trailing \0 (as the \0
would always be at strlen(s2) + 1). This resulted in a truncation of
output from WordNet which relied on the previous behavior which it
used to 'patch' s1. I've now adjusted the strncpy to be a memcpy and
added a comment, to make the intent of the code clear. (Using a str*
function when you don't wish any handling of \0 is unintuitive to me,
hence my mistake). [..] Apologies for the error."

thanks Rob for the exemplary handling of this advisory. Notifications
to package maintainers and follow-ups are almost unheard-of and very
welcome.
2008-09-06 21:49:15 +00:00

49 lines
1.2 KiB
Makefile

# $OpenBSD: Makefile,v 1.3 2008/09/06 21:49:15 sthen Exp $
COMMENT= browser for a large lexical database of English
V= 3.0
DISTNAME= WordNet-$V
PKGNAME= wordnet-$Vp1
CATEGORIES= misc
HOMEPAGE= http://wordnet.princeton.edu/
MAINTAINER= Stuart Henderson <sthen@openbsd.org>
# BSD
PERMIT_PACKAGE_CDROM= Yes
PERMIT_PACKAGE_FTP= Yes
PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
WANTLIB += X11 c m Xext Xss
MASTER_SITES= http://wordnet.princeton.edu/3.0/
LIB_DEPENDS+= tcl85:tcl-8.5.*:lang/tcl/8.5 \
tk85:tk-8.5.*:x11/tk/8.5
pre-configure:
@${SUBST_CMD} ${WRKSRC}/include/wn.h ${WRKSRC}/src/wnb
@perl -pi -e 's,/usr/local/WordNet-3.0,${PREFIX}/share/wordnet,; \
s,([0-9])WN,$$1,g' \${WRKSRC}/doc/man/*.[1-9]
CONFIGURE_STYLE= simple
CONFIGURE_ARGS= --prefix='${PREFIX}/share/wordnet' \
--exec-prefix='${PREFIX}' \
--sysconfdir='${SYSCONFDIR}' \
--mandir='${PREFIX}/man' \
--includedir='${PREFIX}/include' \
--with-tcl=${LOCALBASE}/lib/tcl8.5 \
--with-tk=${LOCALBASE}/lib/tk8.5
CFLAGS+= -I${LOCALBASE}/include/tcl8.5 \
-I${LOCALBASE}/include/tk8.5
CONFIGURE_ENV+= CFLAGS="${CFLAGS}"
NO_REGRESS= Yes
.include <bsd.port.mk>