take a stronger stance and remove evutil_secure_rng_add_bytes() from libevent's API. Nothing calls it anyway, and there's even a big scary warning (tm) in libevent's header.. --- You should almost never need to call this function; it should be sufficient to invoke evutil_secure_rng_init(), or let Libevent take care of calling evutil_secure_rng_init() on its own. If you call this function as a _replacement_ for the regular entropy sources, then you need to be sure that your input contains a fairly large amount of strong entropy. Doing so is notoriously hard: most people who try get it wrong. Watch out! --- Bump event_core major, and remove the now useless configure.in patch. Discussed with/ok sthen@
27 lines
1.0 KiB
Plaintext
27 lines
1.0 KiB
Plaintext
$OpenBSD: patch-include_event2_util_h,v 1.1 2013/11/11 21:54:57 landry Exp $
|
|
--- include/event2/util.h.orig Mon Nov 11 22:39:31 2013
|
|
+++ include/event2/util.h Mon Nov 11 22:40:21 2013
|
|
@@ -672,22 +672,6 @@ void evutil_secure_rng_get_bytes(void *buf, size_t n);
|
|
*/
|
|
int evutil_secure_rng_init(void);
|
|
|
|
-/** Seed the random number generator with extra random bytes.
|
|
-
|
|
- You should almost never need to call this function; it should be
|
|
- sufficient to invoke evutil_secure_rng_init(), or let Libevent take
|
|
- care of calling evutil_secure_rng_init() on its own.
|
|
-
|
|
- If you call this function as a _replacement_ for the regular
|
|
- entropy sources, then you need to be sure that your input
|
|
- contains a fairly large amount of strong entropy. Doing so is
|
|
- notoriously hard: most people who try get it wrong. Watch out!
|
|
-
|
|
- @param dat a buffer full of a strong source of random numbers
|
|
- @param datlen the number of bytes to read from datlen
|
|
- */
|
|
-void evutil_secure_rng_add_bytes(const char *dat, size_t datlen);
|
|
-
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|