cpet/openbsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4b78108efb
openbsd-ports/sysutils/cfengine/patches/patch-src_install_c
sturm fec479ae4c update to 2.1.16, removing sbin/vicf which seems to have a security 
problem but is not used anywhere and will probably be removed from
cfengine

from maintainer William Yodlowsky <bsd at openbsd.rutgers.edu>
2005-10-27 21:47:28 +00:00

495 lines
15 KiB
Plaintext
Raw Blame History

$OpenBSD: patch-src_install_c,v 1.5 2005/10/27 21:47:28 sturm Exp $
--- src/install.c.orig Thu Sep 8 09:43:45 2005
+++ src/install.c Fri Oct 21 16:35:56 2005
@@ -113,7 +113,7 @@ else
FatalError("Redefinition of basic system variable");
}
- strcpy(VFACULTY,value);
+ (void)strlcpy(VFACULTY,value,sizeof(VFACULTY));
break;
case cfdomain:
@@ -124,7 +124,7 @@ else
if (strlen(value) > 0)
{
- strcpy(VDOMAIN,value);
+ (void)strlcpy(VDOMAIN,value,sizeof(VDOMAIN));
}
else
{
@@ -134,12 +134,12 @@ else
if (!StrStr(VSYSNAME.nodename,VDOMAIN))
{
snprintf(VFQNAME,CF_BUFSIZE,"%s.%s",VSYSNAME.nodename,ToLowerStr(VDOMAIN));
- strcpy(VUQNAME,VSYSNAME.nodename);
+ (void)strlcpy(VUQNAME,VSYSNAME.nodename,CF_MAXVARSIZE);
}
else
{
int n = 0;
- strcpy(VFQNAME,VSYSNAME.nodename);
+ (void)strlcpy(VFQNAME,VSYSNAME.nodename,CF_MAXVARSIZE);
while(VSYSNAME.nodename[n++] != '.')
{
@@ -155,7 +155,7 @@ else
FatalError("The fully qualified name is longer than CF_MAXVARSIZE!!");
}
- strcpy(buffer,VFQNAME);
+ (void)strlcpy(buffer,VFQNAME,sizeof(buffer));
AddClassToHeap(CanonifyName(buffer));
}
@@ -170,7 +170,7 @@ else
break;
}
- strcpy(VSYSADM,value);
+ (void)strlcpy(VSYSADM,value,sizeof(VSYSADM));
break;
case cfnetmask:
@@ -185,7 +185,7 @@ else
yyerror("Multiple declaration of variable netmask");
FatalError("Redefinition of basic system variable");
}
- strcpy(VNETMASK,value);
+ (void)strlcpy(VNETMASK,value,sizeof(VNETMASK));
AddNetworkClass(VNETMASK);
break;
@@ -347,7 +347,7 @@ else
break;
case cfnfstype:
- strcpy(VNFSTYPE,value);
+ (void)strlcpy(VNFSTYPE,value,sizeof(VNFSTYPE));
break;
case cfmethodname:
@@ -427,7 +427,7 @@ else
{
}
- sprintf(rename,"_%s",CLASSTEXT[VSYSTEMHARDCLASS]);
+ (void)snprintf(rename,sizeof(rename),"_%s",CLASSTEXT[VSYSTEMHARDCLASS]);
AddClassToHeap(rename);
break;
@@ -448,7 +448,7 @@ else
yyerror("Silly interface name, (should be something link eth0)");
}
- strcpy(VIFNAMEOVERRIDE,value);
+ (void)strlcpy(VIFNAMEOVERRIDE,value,sizeof(VIFNAMEOVERRIDE));
VIFDEV[VSYSTEMHARDCLASS] = VIFNAMEOVERRIDE; /* override */
Debug("Overriding interface with %s\n",VIFDEV[VSYSTEMHARDCLASS]);
break;
@@ -548,7 +548,7 @@ switch(GetCommAttribute(item))
case cfowner:
if (strlen(value) < CF_BUFSIZE)
{
- strcpy(VUIDNAME,value);
+ (void)strlcpy(VUIDNAME,value,CF_BUFSIZE);
}
else
{
@@ -559,7 +559,7 @@ switch(GetCommAttribute(item))
case cfgroup:
if (strlen(value) < CF_BUFSIZE)
{
- strcpy(VGIDNAME,value);
+ (void)strlcpy(VGIDNAME,value,CF_MAXVARSIZE);
}
else
{
@@ -641,13 +641,13 @@ switch(GetCommAttribute(item))
break;
case cfflags: ParseFlagString(value,&PLUSFLAG,&MINUSFLAG);
break;
- case cfowner: strcpy(VUIDNAME,value);
+ case cfowner: (void)strlcpy(VUIDNAME,value,CF_BUFSIZE);
break;
- case cfgroup: strcpy(VGIDNAME,value);
+ case cfgroup: (void)strlcpy(VGIDNAME,value,CF_BUFSIZE);
break;
- case cfdest: strcpy(DESTINATION,value);
+ case cfdest: (void)strlcpy(DESTINATION,value,CF_BUFSIZE);
break;
- case cfaction: strcpy(IMAGEACTION,value);
+ case cfaction: (void)strlcpy(IMAGEACTION,value,CF_BUFSIZE);
break;
case cfcompat: HandleCharSwitch("oldserver",value,&COMPATIBILITY);
break;
@@ -820,7 +820,7 @@ Debug1("HandleOptionalMountItem(%s)\n",v
switch(GetCommAttribute(item))
{
case cfmountoptions:
- strcpy(MOUNTOPTS, value);
+ (void)strlcpy(MOUNTOPTS, value, CF_BUFSIZE);
break;
case cfreadonly:
@@ -1007,7 +1007,7 @@ switch(GetCommAttribute(item))
case cfinclude:
case cfpattern:
- strcpy(CURRENTITEM,value);
+ (void)strlcpy(CURRENTITEM,value,CF_BUFSIZE);
if (*value == '/')
{
yyerror("search pattern begins with / must be a relative name");
@@ -1083,9 +1083,9 @@ switch(GetCommAttribute(item))
break;
case cfflags: ParseFlagString(value,&PLUSFLAG,&MINUSFLAG);
break;
- case cfowner: strcpy(VUIDNAME,value);
+ case cfowner: (void)strlcpy(VUIDNAME,value,CF_BUFSIZE);
break;
- case cfgroup: strcpy(VGIDNAME,value);
+ case cfgroup: (void)strlcpy(VGIDNAME,value,CF_BUFSIZE);
break;
case cfdefine: HandleDefine(value);
break;
@@ -1291,9 +1291,9 @@ switch(GetCommAttribute(item))
break;
case cffilter: PrependItem(&VFILTERBUILD,value,CF_ANYCLASS);
break;
- case cfowner: strcpy(VUIDNAME,value);
+ case cfowner: (void)strlcpy(VUIDNAME,value,CF_BUFSIZE);
break;
- case cfgroup: strcpy(VGIDNAME,value);
+ case cfgroup: (void)strlcpy(VGIDNAME,value,CF_BUFSIZE);
break;
case cfchdir: HandleChDir(value);
break;
@@ -1333,7 +1333,7 @@ Debug1("HandleOptionalPackagesAttribute(
switch(GetCommAttribute(item))
{
- case cfversion: strcpy(PKGVER,value);
+ case cfversion: (void)strlcpy(PKGVER,value,CF_BUFSIZE);
break;
case cfcmp: CMPSENSE = (enum cmpsense) GetCmpSense(value);
break;
@@ -1465,9 +1465,9 @@ switch(GetCommAttribute(item))
break;
case cfsetinform: HandleCharSwitch("inform",value,&INFORMP);
break;
- case cfowner: strcpy(VUIDNAME,value);
+ case cfowner: (void)strlcpy(VUIDNAME,value,CF_BUFSIZE);
break;
- case cfgroup: strcpy(VGIDNAME,value);
+ case cfgroup: (void)strlcpy(VGIDNAME,value,CF_BUFSIZE);
break;
case cfdefine: HandleDefine(value);
break;
@@ -1534,7 +1534,7 @@ if (!IsAbsoluteFileName(value))
yyerror("chdir is not an absolute directory name");
}
-strcpy(CHDIR,value);
+(void)strlcpy(CHDIR,value,CF_BUFSIZE);
}
/*******************************************************************/
@@ -1547,7 +1547,7 @@ if (!IsAbsoluteFileName(value))
yyerror("chdir is not an absolute directory name");
}
-strcpy(CHROOT,value);
+(void)strlcpy(CHROOT,value,sizeof(CHROOT));
}
/*******************************************************************/
@@ -1558,7 +1558,7 @@ void HandleFileItem(char *item)
if (strcmp(item,"home") == 0)
{
ACTIONPENDING=true;
- strcpy(CURRENTOBJECT,"home");
+ (void)strlcpy(CURRENTOBJECT,"home",CF_BUFSIZE);
return;
}
@@ -1588,19 +1588,19 @@ if (VBROADCAST[0] != '\0')
if (strcmp("ones",item) == 0)
{
- strcpy(VBROADCAST,"one");
+ (void)strlcpy(VBROADCAST,"one",sizeof(VBROADCAST));
return;
}
if (strcmp("zeroes",item) == 0)
{
- strcpy(VBROADCAST,"zero");
+ (void)strlcpy(VBROADCAST,"zero",sizeof(VBROADCAST));
return;
}
if (strcmp("zeros",item) == 0)
{
- strcpy(VBROADCAST,"zero");
+ (void)strlcpy(VBROADCAST,"zero",sizeof(VBROADCAST));
return;
}
@@ -1880,7 +1880,7 @@ if (VMAILSERVER[0] != '\0')
FatalError("Redefinition of mailserver");
}
-strcpy(VMAILSERVER,path);
+(void)strlcpy(VMAILSERVER,path,sizeof(VMAILSERVER));
Debug1("Installing mailserver (%s) for group (%s)",path,GROUPBUFF);
}
@@ -2598,9 +2598,9 @@ switch (action)
{
switch (MOUNTMODE)
{
- case 'o': strcpy(MOUNTOPTS,"ro");
+ case 'o': (void)strlcpy(MOUNTOPTS,"ro",CF_BUFSIZE);
break;
- case 'w': strcpy(MOUNTOPTS,"rw");
+ case 'w': (void)strlcpy(MOUNTOPTS,"rw",CF_BUFSIZE);
break;
default: printf("Install pending, miscmount, shouldn't happen\n");
MOUNTOPTS[0] = '\0'; /* no mount mode set! */
@@ -2616,8 +2616,8 @@ switch (action)
MOUNTFROM, MOUNTONTO);
return;
}
- strcat(MOUNTOPTS,",");
- strcat(MOUNTOPTS,op->name);
+ (void)strlcat(MOUNTOPTS,",",CF_BUFSIZE);
+ (void)strlcat(MOUNTOPTS,op->name,CF_BUFSIZE);
}
AppendMiscMount(MOUNTFROM,MOUNTONTO,MOUNTOPTS);
}
@@ -3481,11 +3481,11 @@ for (sp = Get2DListEnt(tp); sp != NULL;
if (strlen(type) == 0)
{
- sprintf(ebuff,"all");
+ (void)snprintf(ebuff,sizeof(ebuff),"all");
}
else
{
- sprintf(ebuff,"%s",type);
+ (void)snprintf(ebuff,sizeof(ebuff),"%s",type);
}
if ((ptr->type = strdup(ebuff)) == NULL)
@@ -3613,7 +3613,7 @@ if (!strstr(function,"("))
}
/* First look at bare args to cache an arg fingerprint */
-strcpy(work,function);
+(void)strlcpy(work,function,sizeof(work));
if (work[strlen(work)-1] != ')')
{
@@ -4857,12 +4857,12 @@ Debug1("InstallImageItem (%s) (+%o)(-%o)
if (strlen(action) == 0) /* default action */
{
- strcat(action,"fix");
+ (void)strlcat(action,"fix",CF_BUFSIZE);
}
if (!(strcmp(action,"silent") == 0 || strcmp(action,"warn") == 0 || strcmp(action,"fix") == 0))
{
- sprintf(VBUFF,"Illegal action in image/copy item: %s",action);
+ (void)snprintf(VBUFF,sizeof(VBUFF),"Illegal action in image/copy item: %s",action);
yyerror(VBUFF);
return;
}
@@ -4953,7 +4953,7 @@ for (spl = Get2DListEnt(tp); spl != NULL
if (strlen(destination) == 0)
{
- strcpy(buf2,spl);
+ (void)strlcpy(buf2,spl,sizeof(buf2));
}
else
{
@@ -5284,11 +5284,11 @@ if (strlen(CURRENTITEM) != 0)
if (strcmp(value,"link") == 0 || strcmp(value,"links") == 0)
{
- strcpy(CURRENTITEM,"link");
+ (void)strlcpy(CURRENTITEM,"link",CF_BUFSIZE);
}
else if (strcmp(value,"plain") == 0 || strcmp(value,"file") == 0)
{
- strcpy(CURRENTITEM,"file");
+ (void)strlcpy(CURRENTITEM,"file",CF_BUFSIZE);
}
else
{
@@ -5407,7 +5407,7 @@ void HandleNetmask(char *value)
{
if (strlen(DESTINATION) == 0)
{
- strcpy(DESTINATION,value);
+ (void)strlcpy(DESTINATION,value,CF_BUFSIZE);
}
else
{
@@ -5422,7 +5422,7 @@ void HandleIPAddress(char *value)
{
if (strlen(LINKTO) == 0)
{
- strcpy(LINKTO,value);
+ (void)strlcpy(LINKTO,value,CF_BUFSIZE);
}
else
{
@@ -5443,19 +5443,19 @@ if (strlen(CURRENTOBJECT) != 0)
if (strcmp("ones",value) == 0)
{
- strcpy(CURRENTOBJECT,"one");
+ (void)strlcpy(CURRENTOBJECT,"one",CF_BUFSIZE);
return;
}
if (strcmp("zeroes",value) == 0)
{
- strcpy(CURRENTOBJECT,"zero");
+ (void)strlcpy(CURRENTOBJECT,"zero",CF_BUFSIZE);
return;
}
if (strcmp("zeros",value) == 0)
{
- strcpy(CURRENTOBJECT,"zero");
+ (void)strlcpy(CURRENTOBJECT,"zero",CF_BUFSIZE);
return;
}
@@ -5468,6 +5468,7 @@ void AppendToActionSequence (char *actio
{ int j = 0;
char *sp,cbuff[CF_BUFSIZE],actiontxt[CF_BUFSIZE];
+ size_t tmplen;
Debug1("Installing item (%s) in the action sequence list\n",action);
@@ -5499,8 +5500,10 @@ while (*sp != '\0')
if (IsHardClass(cbuff))
{
- char *tmp = malloc(strlen(action)+30);
- sprintf(tmp,"Error in action sequence: %s\n",action);
+ char *tmp;
+ tmplen = strlen(action)+30;
+ tmp = malloc(tmplen);
+ (void)snprintf(tmp,tmplen,"Error in action sequence: %s\n",action);
yyerror(tmp);
free(tmp);
yyerror("You cannot add a reserved class!");
@@ -5509,7 +5512,7 @@ while (*sp != '\0')
if (j == 1)
{
- strcpy(actiontxt,cbuff);
+ (void)strlcpy(actiontxt,cbuff,sizeof(actiontxt));
continue;
}
else if (!IsSpecialClass(cbuff))
@@ -5536,7 +5539,7 @@ if (isalpha((int)user[0]))
return;
}
- sprintf(id,"%d",pw->pw_uid);
+ (void)snprintf(id,sizeof(id),"%d",pw->pw_uid);
AppendItem(&VACCESSLIST,id,NULL);
}
else
@@ -5634,7 +5637,7 @@ void HandleServer(char *value)
{
Debug("Server in copy set to : %s\n",value);
-strcpy(CFSERVER,value);
+(void)strlcpy(CFSERVER,value,CF_MAXVARSIZE);
}
/*******************************************************************/
@@ -5656,7 +5659,7 @@ if (strlen(value) > CF_BUFSIZE)
yyerror(OUTPUT);
}
*/
-strcpy(ALLCLASSBUFFER,value);
+(void)strlcpy(ALLCLASSBUFFER,value,sizeof(ALLCLASSBUFFER));
for (sp = value; *sp != '\0'; sp++)
{
@@ -5686,7 +5689,7 @@ if (strlen(value) > CF_BUFSIZE)
yyerror("class list too long - can't handle it!");
}
-strcpy(ELSECLASSBUFFER,value);
+(void)strlcpy(ELSECLASSBUFFER,value,sizeof(ELSECLASSBUFFER));
for (sp = value; *sp != '\0'; sp++)
{
@@ -5716,7 +5719,7 @@ if (strlen(value) > CF_BUFSIZE)
yyerror("class list too long - can't handle it!");
}
-strcpy(FAILOVERBUFFER,value);
+(void)strlcpy(FAILOVERBUFFER,value,sizeof(FAILOVERBUFFER));
for (sp = value; *sp != '\0'; sp++)
{
@@ -6329,8 +6332,8 @@ switch(GetCommAttribute(attribute))
{
if (strlen(copyhost)+strlen(VDOMAIN) < CF_MAXVARSIZE-2)
{
- strcat(copyhost,".");
- strcat(copyhost,VDOMAIN);
+ (void)strlcat(copyhost,".",sizeof(copyhost));
+ (void)strlcat(copyhost,VDOMAIN,sizeof(copyhost));
}
else
{
@@ -6363,6 +6366,7 @@ void PrependTidy(struct TidyPattern **li
{ struct TidyPattern *tp;
char *spe = NULL,*sp, buffer[CF_EXPANDSIZE];
+ size_t spelen = 0;
if ((tp = (struct TidyPattern *)malloc(sizeof(struct TidyPattern))) == NULL)
{
@@ -6392,10 +6396,14 @@ if ((tp->elsedef = strdup(buffer)) == NU
AddInstallable(tp->defines);
AddInstallable(tp->elsedef);
-if ((classes!= NULL) && (spe = malloc(strlen(classes)+2)) == NULL)
+if (classes!= NULL)
{
- perror("Can't allocate memory in PrependItem()");
- FatalError("");
+ spelen = strlen(classes)+2;
+ if ((spe = malloc(spelen)) == NULL)
+ {
+ perror("Can't allocate memory in PrependItem()");
+ FatalError("");
+ }
}
if (travlinks == '?')
@@ -6421,7 +6429,7 @@ tp->rmdirs =tidydirs;
if (classes != NULL)
{
- strcpy(spe,classes);
+ (void)strlcpy(spe,classes,spelen);
tp->classes = spe;
}
else
Reference in New Issue View Git Blame Copy Permalink