cpet/openbsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
92,094 Commits 1 Branch 0 Tags
Commit Graph

317 Commits

Author SHA1 Message Date
espie
2cf36ad340 make HISTORY_ONLY work again... I managed to break it twice :) 2014-04-28 12:51:41 +00:00
zhuk
16e5bd473c Check for extra PERMIT_* lines: not critical but shrinks port Makefiles. 2014-04-27 17:57:14 +00:00
zhuk
9319072f33 Fix hardcoded paths detection using perl. Reminded by jasper@, thanks! 
Tests updates to follow.
 2014-04-19 17:20:37 +00:00
afresh1
03fb3296fa Lexical $_ fixes in package tools 
okay espie@
 2014-03-24 15:18:17 +00:00
espie
5a5389697a zap $_ usage 2014-03-21 11:01:43 +00:00
espie
aeb62cfe9c my $_ 2014-03-18 20:39:45 +00:00
espie
a384b0d3a8 my tracer used lexical $_ 2014-03-17 10:49:19 +00:00
espie
bf709a9acc tweak waiting-for-lock mechanism: explicitly keep track of order, 
and have each job relinquishing lock wake up the next one.

To cater for external dpbs, also try to wake up next job if we don't own the
lock.
 2014-03-15 09:51:27 +00:00
espie
c8571e2c0f restore BUILD_ONCE optimization for full ports builds 2014-03-09 19:47:35 +00:00
zhuk
934244224a Warn about empty lines in PLIST/PFRAG files. Idea supported by jasper@. 2014-02-09 19:26:25 +00:00
zhuk
59eeb06308 Rever previous, it actually makes portcheck do not trigger for problematic 
/var paths at all. A better fix will come later, let's go for low hanging
fruits now.
 2014-02-09 18:11:13 +00:00
zhuk
47f5103e9f Do not warn about hardcoded /var/log/*. 2014-02-09 17:24:48 +00:00
zhuk
c95c81bf60 Fix checks for duplicated assignments. Noted while watching at 
portcheck -A output for audio/soundtouch.
 2014-02-09 16:09:55 +00:00
zhuk
0b6bfe437d Use more precise name for variable, to make logic more clear. 2014-02-09 15:44:20 +00:00
zhuk
9189b7341e Fix default ignore list for -A, and add "tests" there. 2014-02-09 15:19:32 +00:00
zhuk
28a1c15db0 Unbreak portimport after previous. Clean up getopts call while there. 2014-02-09 15:10:49 +00:00
espie
9efc37aec8 actual progress display... oh, and for_list does the next too :( 2014-02-08 13:50:58 +00:00
espie
05495d6602 add (pkgpaths) to pkgnames 2014-02-08 13:37:27 +00:00
espie
fe2b03069f for plists, skip directories (history) and report ba plists. 
user improvement:
with an extra -d, also scan the directories for "current" pkgnames,
and display a ! in pkgnames that are current while reporting conflicts.
 2014-02-08 13:17:19 +00:00
espie
72d7c489b2 style 2014-02-08 10:48:42 +00:00
zhuk
7e26be973e Fix inconsistence when printing names of files in pkg/ directories. Found 
by regression suite.
 2014-02-04 21:28:30 +00:00
zhuk
2f6834a234 Face the reality: portcheck(1) is heavily used now, and not only for new 
ports. Given that you import port once but update it a few times, make
the update mode (-CU) default for portcheck, and provide a "new port"
switch (-N) instead.

This commit updates portcheck(1) and portimport(1): code, documentation and
tests. The WWW stuff will be updated separately.

Note: regression suite fails now as it detected an actual misconsistence
in portcheck's output. This will be handled ASAP, too.

Initial prodding by naddy@
 2014-02-04 21:18:14 +00:00
zhuk
b9c33cd718 The only real hard limit for text lines is 80 characters. 72 is good when 
you cite in email, but noone stops you to !fmt the text. This removes the
corresponding parameter from check_long_lines() because it's not needed
anymore.

inspired in chat by bcallah@, idea okayed by sthen@, espie@ and naddy@
 2014-02-03 22:13:55 +00:00
zhuk
59d4eed82a Actually, checking for kdecore in WANTLIB is not such a good idea: it is 
usually added by corresponding MODULE, which, of course, does his work
right. So catch common "kdeui" and "kio" libraries, too. Already run into
this a few times.
 2014-01-26 01:06:40 +00:00
zhuk
0c448f6c84 Warn about *.rc files that won't work in our rc.d(8) framework. 2014-01-25 10:08:00 +00:00
zhuk
1b513eef98 soundserver_idl and vcard are often written wrong in WANTLIB; add checks 
for them, too.
 2014-01-13 11:47:31 +00:00
zhuk
0d3109f115 Add checks for hardcoded /usr/local and /var in MESSAGE, DESCR, README and 
UNMESSAGE files.
 2014-01-11 16:42:01 +00:00
espie
a99c5726b2 bye bye COMMENT, you've been dead for 8 years 2014-01-07 14:30:12 +00:00
espie
06ad0f0baa move to @signer 2014-01-04 00:10:18 +00:00
zhuk
df36fdc9b1 Handle "?=" as well as "=" when searching for duplicated assignments. 2013-12-30 12:29:25 +00:00
zhuk
12b19d3aa2 Catch Samba libraries not written as lib/samba/ as well as Qt and others. 2013-12-29 16:59:06 +00:00
zhuk
4263b12592 Unbreak detection of extra files in ports directory. 
The portcheck starts to really need having regression tests.
 2013-12-29 07:07:25 +00:00
zhuk
15c78efc69 Try to catch some obvious errors like: 
RUN_DEPENDS =
...
RUN_DEPENDS =

This won't catch such problems if they are spread in different files, but
should be helpful anyway now: idea from my recent typo in x11/kde4/runtime.
 2013-12-28 22:29:50 +00:00
espie
0a8e199101 future keyword, shouldn't be registered 2013-12-26 22:33:35 +00:00
zhuk
37a4b2b2f9 Warn about SHARED_LIBS inside .if statements: those could hide some 
problems, and make some other automated checks ineffective. And we
try to have are ports more declarative than imperative, anyway.

The idea was supported by espie@ a while ago.
 2013-12-21 11:47:20 +00:00
zhuk
4f3e41b9d0 Catch duplicated REVISION marks. Idea born after looking at result of 
cvs update devel/boost in my local tree.
 2013-12-21 08:59:30 +00:00
zhuk
1d58015f11 Now that we have portcheck(1), start relying on it instead of doing 
the checks and pkgpath detection ourself in portimport(1).

Sitting on this diff since september, reminded by kirby@.

Tested in the wild by importing many ports, mostly KDE4-related.

Input and okay sthen@

(now committing the right file instead of ports/bin/portcheck)
 2013-12-11 16:11:09 +00:00
zhuk
1769aeb25d Oops, committed to portcheck instead of portimport. This reverts 
the accidental changes that need some discussion.
 2013-12-11 16:07:44 +00:00
zhuk
dab8a6b9ba Fix spurious "coprocess already exists" by adding some "wait" calls. 
From Bitrig via Martin Natano.
 2013-12-11 15:54:03 +00:00
zhuk
8dff51f298 Zap extra word in message. 
From Bitrig via Martin Natano.
 2013-12-11 15:53:07 +00:00
zhuk
12e075e9da Now that we have portcheck(1), start relying on it instead of doing 
the checks and pkgpath detection ourself in portimport(1).

Sitting on this diff since september, reminded by kirby@.

Tested in the wild by importing many ports, mostly KDE4-related.

Input and okay sthen@
 2013-12-11 13:55:34 +00:00
zhuk
ed6a8d0bf3 Catch missing multimedia/phonon in modules. Actual for upcoming KDE4 apps 
outside of KDE SC.
 2013-12-10 19:08:49 +00:00
zhuk
fce9ca5853 Oops, extra colon sneaked in previous commit. 2013-11-28 15:48:29 +00:00
zhuk
74577504a0 Some missing ${portref} in err() calls. Found while checking new KDE ports. 2013-11-28 13:38:01 +00:00
zhuk
7774a27c62 Remove check for files/directories named "core", they are not a problem 
anymore.

Pointed out by sthen@.
 2013-11-12 11:24:21 +00:00
naddy
9b97317187 spelling; ok zhuk@ 2013-11-10 14:56:41 +00:00
naddy
394ea9b42a fix the check for long lines, simplify; ok zhuk@ 2013-11-09 23:27:30 +00:00
ajacoutot
5a2b6c9606 SECURITY files are gone. 
ok zhuk@
 2013-11-07 08:18:16 +00:00
zhuk
3b4d47508a Add checks for maximum line length in some port files. Feel free to correct 
actual numbers if needed.

Suggested by bcallah@ on ports@.
 2013-11-01 10:43:40 +00:00
zhuk
bcc21ce9ca Add a check that we do not end up with WANTLIB in arch-independent package. 2013-10-25 23:32:08 +00:00