Security fix for CVE-2011-1058,

MoinMoin "refuri" Cross-Site Scripting Vulnerability

Note that 'rst' is not the default parser, but available if docutils are installed. For more information see http://moinmo.in/SecurityFixes
This commit is contained in:
jasper 2011-03-07 18:38:06 +00:00
parent 92cf5facfb
commit cc29610abb
2 changed files with 22 additions and 1 deletions

View File

@ -1,10 +1,11 @@
# $OpenBSD: Makefile,v 1.19 2010/09/01 23:24:55 fgsch Exp $
# $OpenBSD: Makefile,v 1.20 2011/03/07 18:38:06 jasper Exp $
COMMENT = wiki engine written in python
MODPY_EGG_VERSION = 1.9.3
DISTNAME = moin-${MODPY_EGG_VERSION}
PKGNAME = moin${DISTNAME}
REVISION = 0
CATEGORIES = www

View File

@ -0,0 +1,20 @@
$OpenBSD: patch-MoinMoin_parser_text_rst_py,v 1.1 2011/03/07 18:38:06 jasper Exp $
Security fix for CVE-2011-1058,
MoinMoin "refuri" Cross-Site Scripting Vulnerability
Patch from upstream Mercurial:
http://hg.moinmo.in/moin/1.9/rev/97208f67798f
--- MoinMoin/parser/text_rst.py.orig Mon Mar 7 19:35:58 2011
+++ MoinMoin/parser/text_rst.py Mon Mar 7 19:36:02 2011
@@ -391,6 +391,9 @@ class MoinTranslator(html4css1.HTMLTranslator):
# for images with targets).
if not [i for i in node.children if i.__class__ == docutils.nodes.image]:
node['classes'].append('interwiki')
+ elif prefix == 'javascript':
+ # is someone trying to do XSS with javascript?
+ node['refuri'] = 'javascript:alert("it does not work")'
elif prefix != '':
# Some link scheme (http, file, https, mailto, etc.), add class
# information if the reference doesn't have a child image (don't