backport important bug-fix from newest ltdl.

There are probably other bad bugs in there, this code is a textbook example
of how NOT to write code if you want it to work.

Between the gnu style that obfuscate the stuff, the various thingies added
"just in case", the misuse of autoconf results, and the really high
abstraction level together with long functions and internal concepts, how
can anyone make sense of this code ? (short answer: it doesn't make actual
sense).

Also, no cookies for the gnu guys who, along with an important bug-fix,
manage *again* to push out 10000+ lines of useless diff thanks to a change
in automake/autoconf itself.

We don't need to make fun of Windows  and its security, the GNU project
manages to produce as many problems on its own...

When will they learn secure practices ? I would bet "not this century",
but then I probably won't be around to collect the bet...
This commit is contained in:
espie 2009-11-17 10:15:35 +00:00
parent 10a3b8f09b
commit 8c1eea771b
2 changed files with 15 additions and 3 deletions

View File

@ -1,4 +1,4 @@
# $OpenBSD: Makefile,v 1.72 2009/11/11 10:47:08 sthen Exp $ # $OpenBSD: Makefile,v 1.73 2009/11/17 10:15:35 espie Exp $
# $FreeBSD: Makefile,v 1.2 1998/09/23 16:15:53 vanilla Exp $ # $FreeBSD: Makefile,v 1.2 1998/09/23 16:15:53 vanilla Exp $
COMMENT-main= generic shared library support script COMMENT-main= generic shared library support script
@ -7,8 +7,8 @@ COMMENT-ltdl= GNU libtool system independent dlopen wrapper
VERSION= 1.5.26 VERSION= 1.5.26
DISTNAME= libtool-${VERSION} DISTNAME= libtool-${VERSION}
PKGNAME-main= ${DISTNAME}p2 PKGNAME-main= ${DISTNAME}p2
PKGNAME-ltdl= libltdl-${VERSION} PKGNAME-ltdl= libltdl-${VERSION}p0
SHARED_LIBS= ltdl 4.4 SHARED_LIBS= ltdl 4.5
MODGNU_SHARED_LIBS= ltdl '-no-undefined' MODGNU_SHARED_LIBS= ltdl '-no-undefined'
CATEGORIES= devel CATEGORIES= devel

View File

@ -0,0 +1,12 @@
$OpenBSD: patch-libltdl_ltdl_c,v 1.4 2009/11/17 10:15:35 espie Exp $
--- libltdl/ltdl.c.orig Mon Nov 16 19:39:41 2009
+++ libltdl/ltdl.c Mon Nov 16 19:39:54 2009
@@ -3225,7 +3225,7 @@ try_dlopen (phandle, filename)
}
#endif
}
- if (!file)
+ else
{
file = fopen (filename, LT_READTEXT_MODE);
}