aircrack-ng: fix the build on powerpc

aircrack-ng uses an old version of John the Ripper, the whole Altivec
acceleration code does not build since the move to clang/compiler_rt;
it fails with ports-gcc as well. John codebase massively changed in
this regard since then, making backports too massive.

Remove AltiVec support and associated PFRAG, with a patch ensuring that
AltiVec and POWER8 are *really* disabled at build time (from upstream).

OK benoit@ (maintainer)

security/aircrack-ng/Makefile

@@ -1,4 +1,4 @@
-# $OpenBSD: Makefile,v 1.29 2019/12/06 14:29:40 sthen Exp $
+# $OpenBSD: Makefile,v 1.30 2020/06/13 17:38:49 cwen Exp $
 
 COMMENT=		802.11 WEP and WPA-PSK keys cracking program
 DISTNAME=		aircrack-ng-1.5.2
@@ -52,10 +52,10 @@ PKG_ARGS+=              -Dx86=0
 #.else
 PKG_ARGS+=              -Darm=0
 #.endif
+# XXX AltiVec optimizations can't be built with clang, and POWER8 ones
+# are useless on powerpc
 .if ${MACHINE_ARCH} == "powerpc"
-PKG_ARGS+=              -Dppc=1
-.else
-PKG_ARGS+=              -Dppc=0
+MAKE_ENV+=              ALTIVEC=false POWER8=false
 .endif
 
 

security/aircrack-ng/patches/patch-build_m4_aircrack_ng_simd_m4

@@ -0,0 +1,25 @@
+$OpenBSD: patch-build_m4_aircrack_ng_simd_m4,v 1.1 2020/06/13 17:38:49 cwen Exp $
+
+Ensure that disabling AltiVec and POWER8 instructions with MAKE_ENV is honoured
+even if the build machine supports them, from:
+https://github.com/aircrack-ng/aircrack-ng/issues/1941
+
+Index: build/m4/aircrack_ng_simd.m4
+--- build/m4/aircrack_ng_simd.m4.orig
++++ build/m4/aircrack_ng_simd.m4
+@@ -132,7 +132,6 @@ then
+     AX_CHECK_COMPILE_FLAG([-maltivec], [
+         AX_APPEND_FLAG(-maltivec, [ppc_altivec_[]_AC_LANG_ABBREV[]flags])
+         AC_SUBST(ppc_altivec_[]_AC_LANG_ABBREV[]flags)
+-        ALTIVEC_FOUND=1
+     ])
+ 
+     AX_CHECK_COMPILE_FLAG([-mabi=altivec], [
+@@ -148,7 +147,6 @@ then
+     AX_CHECK_COMPILE_FLAG([-mpower8-vector], [
+         AX_APPEND_FLAG(-mpower8-vector, [ppc_altivec_[]_AC_LANG_ABBREV[]flags])
+         AC_SUBST(ppc_altivec_[]_AC_LANG_ABBREV[]flags)
+-        POWER8_FOUND=1
+     ])
+ fi
+ 

security/aircrack-ng/pkg/PFRAG.ppc

@@ -1,4 +0,0 @@
-@comment $OpenBSD: PFRAG.ppc,v 1.2 2019/08/12 14:40:04 cwen Exp $
-lib/libaircrack-crypto-ppc-altivec-1.3.0.so
-lib/libaircrack-crypto-ppc-altivec.la
-lib/libaircrack-crypto-ppc-altivec.so

security/aircrack-ng/pkg/PLIST

@@ -1,4 +1,4 @@
-@comment $OpenBSD: PLIST,v 1.4 2019/02/23 22:23:25 sebastia Exp $
+@comment $OpenBSD: PLIST,v 1.5 2020/06/13 17:38:49 cwen Exp $
 @bin bin/aircrack-ng
 @bin bin/airdecap-ng
 @bin bin/airdecloak-ng
@@ -10,7 +10,6 @@
 @bin bin/wpaclean
 lib/libaircrack-crypto-1.3.0.so
 %%x86%%
-%%ppc%%
 %%arm%%
 lib/libaircrack-crypto.la
 lib/libaircrack-crypto.so